Re: [iproute2-next v2 4/4] vdpa: Enable user to set mtu of the vdpa device

2021-12-20 Thread Michael S. Tsirkin
On Mon, Dec 20, 2021 at 02:11:44PM -0700, David Ahern wrote: > On 12/20/21 12:11 PM, Parav Pandit wrote: > >> After consideration, this future proofing seems like a good thing to have. > > Ok. I will first get kernel change merged, after which will send v3 for > > iproute2. > > this set has been

Re: [iproute2-next v2 4/4] vdpa: Enable user to set mtu of the vdpa device

2021-12-20 Thread David Ahern
On 12/20/21 12:11 PM, Parav Pandit wrote: >> After consideration, this future proofing seems like a good thing to have. > Ok. I will first get kernel change merged, after which will send v3 for > iproute2. this set has been committed; not sure what happened to the notification from patchworks bot

RE: [iproute2-next v2 4/4] vdpa: Enable user to set mtu of the vdpa device

2021-12-20 Thread Parav Pandit via Virtualization
> From: Michael S. Tsirkin > Sent: Monday, December 20, 2021 5:33 PM > > On Mon, Dec 20, 2021 at 03:49:21AM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > Sent: Sunday, December 19, 2021 3:37 AM > > > > > > On Sat, Dec 18, 2021 at 01:53:01PM -0700, David Ahern wrote:

Re: [iproute2-next v2 4/4] vdpa: Enable user to set mtu of the vdpa device

2021-12-20 Thread Michael S. Tsirkin
On Mon, Dec 20, 2021 at 03:49:21AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Sunday, December 19, 2021 3:37 AM > > > > On Sat, Dec 18, 2021 at 01:53:01PM -0700, David Ahern wrote: > > > On 12/17/21 1:08 AM, Parav Pandit wrote: > > > > @@ -204,6 +217,8 @@ static void

RE: [iproute2-next v2 4/4] vdpa: Enable user to set mtu of the vdpa device

2021-12-19 Thread Parav Pandit via Virtualization
> From: Michael S. Tsirkin > Sent: Sunday, December 19, 2021 3:37 AM > > On Sat, Dec 18, 2021 at 01:53:01PM -0700, David Ahern wrote: > > On 12/17/21 1:08 AM, Parav Pandit wrote: > > > @@ -204,6 +217,8 @@ static void vdpa_opts_put(struct nlmsghdr *nlh, > struct vdpa *vdpa) > > > if (opts->pr

Re: [iproute2-next v2 4/4] vdpa: Enable user to set mtu of the vdpa device

2021-12-18 Thread Michael S. Tsirkin
On Sat, Dec 18, 2021 at 01:53:01PM -0700, David Ahern wrote: > On 12/17/21 1:08 AM, Parav Pandit wrote: > > @@ -204,6 +217,8 @@ static void vdpa_opts_put(struct nlmsghdr *nlh, struct > > vdpa *vdpa) > > if (opts->present & VDPA_OPT_VDEV_MAC) > > mnl_attr_put(nlh, VDPA_ATTR_DEV_NET_

Re: [iproute2-next v2 4/4] vdpa: Enable user to set mtu of the vdpa device

2021-12-18 Thread David Ahern
On 12/17/21 1:08 AM, Parav Pandit wrote: > @@ -204,6 +217,8 @@ static void vdpa_opts_put(struct nlmsghdr *nlh, struct > vdpa *vdpa) > if (opts->present & VDPA_OPT_VDEV_MAC) > mnl_attr_put(nlh, VDPA_ATTR_DEV_NET_CFG_MACADDR, >sizeof(opts->mac), opts->