Re: Re: [PATCH v2 13/18] mm/compaction: support non-lru movable pagemigration

2016-03-23 Thread Minchan Kim
On Thu, Mar 24, 2016 at 05:26:50AM +0900, Gioh Kim wrote: >Hmmm... But, in failure case, is it safe to call putback_lru_page() for >them? >And, PageIsolated() would be left. Is it okay? It's not symmetric that >isolated page can be freed by decreasing ref count without calling >

RE: Re: [PATCH v2 13/18] mm/compaction: support non-lru movable pagemigration

2016-03-23 Thread Gioh Kim
Hmmm... But, in failure case, is it safe to call putback_lru_page() for them? And, PageIsolated() would be left. Is it okay? It's not symmetric that isolated page can be freed by decreasing ref count without calling putback function. This should be clarified and documented. I agree