Re: [PATCH 1/2] Convert target drivers to use sbitmap

2018-06-12 Thread Matthew Wilcox
On Tue, Jun 12, 2018 at 04:32:03PM +, Bart Van Assche wrote: > On Tue, 2018-06-12 at 09:15 -0700, Matthew Wilcox wrote: > > On Tue, Jun 12, 2018 at 03:22:42PM +, Bart Van Assche wrote: > > > Please introduce functions in the target core for allocating and freeing > > > a tag > > > instead

Re: [PATCH 1/2] Convert target drivers to use sbitmap

2018-06-12 Thread Bart Van Assche
On Tue, 2018-06-12 at 09:15 -0700, Matthew Wilcox wrote: > On Tue, Jun 12, 2018 at 03:22:42PM +, Bart Van Assche wrote: > > On Tue, 2018-05-15 at 09:00 -0700, Matthew Wilcox wrote: > > > diff --git a/drivers/scsi/qla2xxx/qla_target.c > > > b/drivers/scsi/qla2xxx/qla_target.c > > > index

Re: [PATCH 1/2] Convert target drivers to use sbitmap

2018-06-12 Thread Matthew Wilcox
On Tue, Jun 12, 2018 at 03:22:42PM +, Bart Van Assche wrote: > On Tue, 2018-05-15 at 09:00 -0700, Matthew Wilcox wrote: > > diff --git a/drivers/scsi/qla2xxx/qla_target.c > > b/drivers/scsi/qla2xxx/qla_target.c > > index 025dc2d3f3de..cdf671c2af61 100644 > > ---

Re: [PATCH 1/2] Convert target drivers to use sbitmap

2018-06-12 Thread Bart Van Assche
On Tue, 2018-05-15 at 09:00 -0700, Matthew Wilcox wrote: > diff --git a/drivers/scsi/qla2xxx/qla_target.c > b/drivers/scsi/qla2xxx/qla_target.c > index 025dc2d3f3de..cdf671c2af61 100644 > --- a/drivers/scsi/qla2xxx/qla_target.c > +++ b/drivers/scsi/qla2xxx/qla_target.c > @@ -3719,7 +3719,8 @@

Re: [PATCH 1/2] Convert target drivers to use sbitmap

2018-06-11 Thread Matthew Wilcox
On Mon, Jun 11, 2018 at 07:18:55PM -0600, Jens Axboe wrote: > Are you going to push this further? I really think we should. Yes, I'll resubmit it tomorrow. Sorry for dropping the ball on this one. ___ Virtualization mailing list

Re: [PATCH 1/2] Convert target drivers to use sbitmap

2018-06-11 Thread Jens Axboe
On 5/15/18 10:11 AM, Jens Axboe wrote: > On 5/15/18 10:00 AM, Matthew Wilcox wrote: >> From: Matthew Wilcox >> >> The sbitmap and the percpu_ida perform essentially the same task, >> allocating tags for commands. Since the sbitmap is more used than >> the percpu_ida, convert the percpu_ida users

Re: [PATCH 1/2] Convert target drivers to use sbitmap

2018-05-16 Thread kbuild test robot
Hi Matthew, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.17-rc5 next-20180516] [cannot apply to target/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 1/2] Convert target drivers to use sbitmap

2018-05-15 Thread Jens Axboe
On 5/15/18 10:11 AM, Jens Axboe wrote: > On 5/15/18 10:00 AM, Matthew Wilcox wrote: >> From: Matthew Wilcox >> >> The sbitmap and the percpu_ida perform essentially the same task, >> allocating tags for commands. Since the sbitmap is more used than >> the percpu_ida,

Re: [PATCH 1/2] Convert target drivers to use sbitmap

2018-05-15 Thread Jens Axboe
On 5/15/18 10:00 AM, Matthew Wilcox wrote: > From: Matthew Wilcox > > The sbitmap and the percpu_ida perform essentially the same task, > allocating tags for commands. Since the sbitmap is more used than > the percpu_ida, convert the percpu_ida users to the sbitmap API.