Re: [PATCH V3 4/7] mdev: introduce device specific ops

2019-10-17 Thread Jason Wang
On 2019/10/17 下午4:45, Cornelia Huck wrote: On Thu, 17 Oct 2019 16:30:43 +0800 Jason Wang wrote: On 2019/10/17 上午12:53, Alex Williamson wrote: Yet another suggestion: have the class id derive from the function you use to set up the ops. void mdev_set_vfio_ops(struct mdev_device *mdev, const

Re: [PATCH V3 4/7] mdev: introduce device specific ops

2019-10-17 Thread Cornelia Huck
On Thu, 17 Oct 2019 16:30:43 +0800 Jason Wang wrote: > On 2019/10/17 上午12:53, Alex Williamson wrote: > >>> Yet another suggestion: have the class id derive from the function > >>> you use to set up the ops. > >>> > >>> void mdev_set_vfio_ops(struct mdev_device *mdev, const struct > >>>

Re: [PATCH V3 4/7] mdev: introduce device specific ops

2019-10-17 Thread Jason Wang
; kevin.t...@intel.com Subject: Re: [PATCH V3 4/7] mdev: introduce device specific ops On Wed, 16 Oct 2019 05:50:08 + Parav Pandit wrote: Hi Alex, -Original Message- From: Alex Williamson Sent: Tuesday, October 15, 2019 12:27 PM To: Jason Wang Cc: Cornelia Huck ; k

Re: [PATCH V3 4/7] mdev: introduce device specific ops

2019-10-16 Thread Alex Williamson
On Wed, 16 Oct 2019 20:48:06 + Parav Pandit wrote: > > From: Alex Williamson > > On Wed, 16 Oct 2019 15:31:25 + > > Parav Pandit wrote: > > > > From: Cornelia Huck > > > > Parav Pandit wrote: > > > > > > From: Alex Williamson > > > > > > On Tue, 15 Oct 2019 20:17:01 +0800 Jason Wang

Re: [PATCH V3 4/7] mdev: introduce device specific ops

2019-10-16 Thread Alex Williamson
com; fre...@linux.ibm.com; > > lingshan@intel.com; Ido Shamay ; > > epere...@redhat.com; l...@redhat.com; christophe.de.dinec...@gmail.com; > > kevin.t...@intel.com > > Subject: Re: [PATCH V3 4/7] mdev: introduce device specific ops > > > > On Wed, 16 Oct 2019 05:5

Re: [PATCH V3 4/7] mdev: introduce device specific ops

2019-10-16 Thread Cornelia Huck
om; fre...@linux.ibm.com; > > lingshan@intel.com; Ido Shamay ; > > epere...@redhat.com; l...@redhat.com; Parav Pandit > > ; christophe.de.dinec...@gmail.com; > > kevin.t...@intel.com > > Subject: Re: [PATCH V3 4/7] mdev: introduce device specific ops > > > &

Re: [PATCH V3 4/7] mdev: introduce device specific ops

2019-10-15 Thread Alex Williamson
On Tue, 15 Oct 2019 20:17:01 +0800 Jason Wang wrote: > On 2019/10/15 下午6:41, Cornelia Huck wrote: > > On Fri, 11 Oct 2019 16:15:54 +0800 > > Jason Wang wrote: > > > >> Currently, except for the create and remove, the rest of > >> mdev_parent_ops is designed for vfio-mdev driver only and may

Re: [PATCH V3 4/7] mdev: introduce device specific ops

2019-10-15 Thread Jason Wang
On 2019/10/15 下午6:41, Cornelia Huck wrote: On Fri, 11 Oct 2019 16:15:54 +0800 Jason Wang wrote: Currently, except for the create and remove, the rest of mdev_parent_ops is designed for vfio-mdev driver only and may not help for kernel mdev driver. With the help of class id, this patch

Re: [PATCH V3 4/7] mdev: introduce device specific ops

2019-10-15 Thread Cornelia Huck
On Fri, 11 Oct 2019 16:15:54 +0800 Jason Wang wrote: > Currently, except for the create and remove, the rest of > mdev_parent_ops is designed for vfio-mdev driver only and may not help > for kernel mdev driver. With the help of class id, this patch > introduces device specific callbacks inside