Re: [PATCH net] virtio_net: CTRL_GUEST_OFFLOADS depends on CTRL_VQ

2020-01-05 Thread Michael S. Tsirkin
On Mon, Dec 23, 2019 at 12:21:56PM -0800, Alistair Delva wrote: > On Mon, Dec 23, 2019 at 12:12 PM Willem de Bruijn > wrote: > > > > On Mon, Dec 23, 2019 at 2:56 PM Willem de Bruijn > > wrote: > > > > > > 00fffe0ff0 DR7: 0400 > > > > > Call Trace: > > > > > ?

Re: [PATCH net] virtio_net: CTRL_GUEST_OFFLOADS depends on CTRL_VQ

2020-01-05 Thread Michael S. Tsirkin
On Tue, Dec 24, 2019 at 10:49:13AM +0800, Jason Wang wrote: > > On 2019/12/24 上午4:21, Alistair Delva wrote: > > On Mon, Dec 23, 2019 at 12:12 PM Willem de Bruijn > > wrote: > > > On Mon, Dec 23, 2019 at 2:56 PM Willem de Bruijn > > > wrote: > > > > 00fffe0ff0 DR7: 0400 > > > > > >

Re: [PATCH net] virtio_net: CTRL_GUEST_OFFLOADS depends on CTRL_VQ

2019-12-25 Thread Willem de Bruijn
On Mon, Dec 23, 2019 at 3:22 PM Alistair Delva wrote: > > On Mon, Dec 23, 2019 at 12:12 PM Willem de Bruijn > wrote: > > > > On Mon, Dec 23, 2019 at 2:56 PM Willem de Bruijn > > wrote: > > > > > > 00fffe0ff0 DR7: 0400 > > > > > Call Trace: > > > > > ? preempt_count_add+0x58/0xb0 >

Re: [PATCH net] virtio_net: CTRL_GUEST_OFFLOADS depends on CTRL_VQ

2019-12-23 Thread Jason Wang
On 2019/12/24 上午4:21, Alistair Delva wrote: On Mon, Dec 23, 2019 at 12:12 PM Willem de Bruijn wrote: On Mon, Dec 23, 2019 at 2:56 PM Willem de Bruijn wrote: 00fffe0ff0 DR7: 0400 Call Trace: ? preempt_count_add+0x58/0xb0 ? _raw_spin_lock_irqsave+0x36/0x70 ?

Re: [PATCH net] virtio_net: CTRL_GUEST_OFFLOADS depends on CTRL_VQ

2019-12-23 Thread Willem de Bruijn
On Mon, Dec 23, 2019 at 2:56 PM Willem de Bruijn wrote: > > 00fffe0ff0 DR7: 0400 > > > Call Trace: > > > ? preempt_count_add+0x58/0xb0 > > > ? _raw_spin_lock_irqsave+0x36/0x70 > > > ? _raw_spin_unlock_irqrestore+0x1a/0x40 > > > ? __wake_up+0x70/0x190 > > >

Re: [PATCH net] virtio_net: CTRL_GUEST_OFFLOADS depends on CTRL_VQ

2019-12-23 Thread Willem de Bruijn
00fffe0ff0 DR7: 0400 > > Call Trace: > > ? preempt_count_add+0x58/0xb0 > > ? _raw_spin_lock_irqsave+0x36/0x70 > > ? _raw_spin_unlock_irqrestore+0x1a/0x40 > > ? __wake_up+0x70/0x190 > > virtnet_set_features+0x90/0xf0 [virtio_net] > > __netdev_update_features+0x271/0x980 > > ?

Re: [PATCH net] virtio_net: CTRL_GUEST_OFFLOADS depends on CTRL_VQ

2019-12-23 Thread Michael S. Tsirkin
On Mon, Dec 23, 2019 at 09:40:11AM -0800, Alistair Delva wrote: > Hi Michael, > > On Mon, Dec 23, 2019 at 6:09 AM Michael S. Tsirkin wrote: > > > > The only way for guest to control offloads (as enabled by > > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) is by sending commands > > through CTRL_VQ. So it