Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-07-05 Thread Liang Chen
On Wed, Jul 5, 2023 at 2:05 PM Jason Wang wrote: > > On Wed, Jul 5, 2023 at 1:41 PM Liang Chen wrote: > > > > On Fri, Jun 9, 2023 at 10:57 AM Liang Chen > > wrote: > > > > > > On Thu, Jun 8, 2023 at 8:38 AM Jason Wang wrote: > > > > > > > > On Thu, Jun 8, 2023 at 4:17 AM Michael S. Tsirkin

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-07-05 Thread Jason Wang
On Wed, Jul 5, 2023 at 1:41 PM Liang Chen wrote: > > On Fri, Jun 9, 2023 at 10:57 AM Liang Chen wrote: > > > > On Thu, Jun 8, 2023 at 8:38 AM Jason Wang wrote: > > > > > > On Thu, Jun 8, 2023 at 4:17 AM Michael S. Tsirkin wrote: > > > > > > > > On Wed, Jun 07, 2023 at 05:08:59PM +0800, Liang

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-07-04 Thread Liang Chen
On Fri, Jun 9, 2023 at 10:57 AM Liang Chen wrote: > > On Thu, Jun 8, 2023 at 8:38 AM Jason Wang wrote: > > > > On Thu, Jun 8, 2023 at 4:17 AM Michael S. Tsirkin wrote: > > > > > > On Wed, Jun 07, 2023 at 05:08:59PM +0800, Liang Chen wrote: > > > > On Tue, May 30, 2023 at 9:19 AM Liang Chen >

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-06-08 Thread Liang Chen
On Thu, Jun 8, 2023 at 8:38 AM Jason Wang wrote: > > On Thu, Jun 8, 2023 at 4:17 AM Michael S. Tsirkin wrote: > > > > On Wed, Jun 07, 2023 at 05:08:59PM +0800, Liang Chen wrote: > > > On Tue, May 30, 2023 at 9:19 AM Liang Chen > > > wrote: > > > > > > > > On Mon, May 29, 2023 at 5:55 PM

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-06-08 Thread Liang Chen
On Thu, Jun 8, 2023 at 4:17 AM Michael S. Tsirkin wrote: > > On Wed, Jun 07, 2023 at 05:08:59PM +0800, Liang Chen wrote: > > On Tue, May 30, 2023 at 9:19 AM Liang Chen > > wrote: > > > > > > On Mon, May 29, 2023 at 5:55 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, May 29, 2023

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-06-07 Thread Xuan Zhuo
On Thu, 8 Jun 2023 08:38:14 +0800, Jason Wang wrote: > On Thu, Jun 8, 2023 at 4:17 AM Michael S. Tsirkin wrote: > > > > On Wed, Jun 07, 2023 at 05:08:59PM +0800, Liang Chen wrote: > > > On Tue, May 30, 2023 at 9:19 AM Liang Chen > > > wrote: > > > > > > > > On Mon, May 29, 2023 at 5:55 PM

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-06-07 Thread Jason Wang
On Thu, Jun 8, 2023 at 4:17 AM Michael S. Tsirkin wrote: > > On Wed, Jun 07, 2023 at 05:08:59PM +0800, Liang Chen wrote: > > On Tue, May 30, 2023 at 9:19 AM Liang Chen > > wrote: > > > > > > On Mon, May 29, 2023 at 5:55 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, May 29, 2023

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-06-07 Thread Michael S. Tsirkin
On Wed, Jun 07, 2023 at 05:08:59PM +0800, Liang Chen wrote: > On Tue, May 30, 2023 at 9:19 AM Liang Chen wrote: > > > > On Mon, May 29, 2023 at 5:55 PM Michael S. Tsirkin wrote: > > > > > > On Mon, May 29, 2023 at 03:27:56PM +0800, Liang Chen wrote: > > > > On Sun, May 28, 2023 at 2:20 PM

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-06-07 Thread Liang Chen
On Wed, Jun 7, 2023 at 5:36 PM Xuan Zhuo wrote: > > On Wed, 7 Jun 2023 17:08:59 +0800, Liang Chen > wrote: > > On Tue, May 30, 2023 at 9:19 AM Liang Chen > > wrote: > > > > > > On Mon, May 29, 2023 at 5:55 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, May 29, 2023 at 03:27:56PM

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-06-07 Thread Xuan Zhuo
On Wed, 7 Jun 2023 17:08:59 +0800, Liang Chen wrote: > On Tue, May 30, 2023 at 9:19 AM Liang Chen wrote: > > > > On Mon, May 29, 2023 at 5:55 PM Michael S. Tsirkin wrote: > > > > > > On Mon, May 29, 2023 at 03:27:56PM +0800, Liang Chen wrote: > > > > On Sun, May 28, 2023 at 2:20 PM Michael S.

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-06-07 Thread Xuan Zhuo
On Wed, 7 Jun 2023 17:11:44 +0800, Liang Chen wrote: > On Wed, May 31, 2023 at 11:12 AM Xuan Zhuo wrote: > > > > On Mon, 29 May 2023 15:28:17 +0800, Liang Chen > > wrote: > > > On Sun, May 28, 2023 at 2:40 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Sat, May 27, 2023 at 08:35:01PM

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-06-07 Thread Liang Chen
On Wed, May 31, 2023 at 11:12 AM Xuan Zhuo wrote: > > On Mon, 29 May 2023 15:28:17 +0800, Liang Chen > wrote: > > On Sun, May 28, 2023 at 2:40 PM Michael S. Tsirkin wrote: > > > > > > On Sat, May 27, 2023 at 08:35:01PM +0800, Liang Chen wrote: > > > > On Fri, May 26, 2023 at 2:51 PM Jason Wang

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-06-07 Thread Liang Chen
On Tue, May 30, 2023 at 9:19 AM Liang Chen wrote: > > On Mon, May 29, 2023 at 5:55 PM Michael S. Tsirkin wrote: > > > > On Mon, May 29, 2023 at 03:27:56PM +0800, Liang Chen wrote: > > > On Sun, May 28, 2023 at 2:20 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Fri, May 26, 2023 at

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-05-30 Thread Xuan Zhuo
On Mon, 29 May 2023 15:28:17 +0800, Liang Chen wrote: > On Sun, May 28, 2023 at 2:40 PM Michael S. Tsirkin wrote: > > > > On Sat, May 27, 2023 at 08:35:01PM +0800, Liang Chen wrote: > > > On Fri, May 26, 2023 at 2:51 PM Jason Wang wrote: > > > > > > > > On Fri, May 26, 2023 at 1:46 PM Liang

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-05-29 Thread Liang Chen
On Mon, May 29, 2023 at 5:55 PM Michael S. Tsirkin wrote: > > On Mon, May 29, 2023 at 03:27:56PM +0800, Liang Chen wrote: > > On Sun, May 28, 2023 at 2:20 PM Michael S. Tsirkin wrote: > > > > > > On Fri, May 26, 2023 at 01:46:18PM +0800, Liang Chen wrote: > > > > The implementation at the moment

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-05-29 Thread Michael S. Tsirkin
On Mon, May 29, 2023 at 03:27:56PM +0800, Liang Chen wrote: > On Sun, May 28, 2023 at 2:20 PM Michael S. Tsirkin wrote: > > > > On Fri, May 26, 2023 at 01:46:18PM +0800, Liang Chen wrote: > > > The implementation at the moment uses one page per packet in both the > > > normal and XDP path. In

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-05-29 Thread Liang Chen
On Sun, May 28, 2023 at 2:40 PM Michael S. Tsirkin wrote: > > On Sat, May 27, 2023 at 08:35:01PM +0800, Liang Chen wrote: > > On Fri, May 26, 2023 at 2:51 PM Jason Wang wrote: > > > > > > On Fri, May 26, 2023 at 1:46 PM Liang Chen > > > wrote: > > > > > > > > The implementation at the moment

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-05-29 Thread Liang Chen
On Sun, May 28, 2023 at 2:27 PM Michael S. Tsirkin wrote: > > On Sat, May 27, 2023 at 12:11:25AM +0800, kernel test robot wrote: > > Hi Liang, > > > > kernel test robot noticed the following build errors: > > > > [auto build test ERROR on net-next/main] > > > > url: > >

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-05-29 Thread Liang Chen
On Sun, May 28, 2023 at 2:20 PM Michael S. Tsirkin wrote: > > On Fri, May 26, 2023 at 01:46:18PM +0800, Liang Chen wrote: > > The implementation at the moment uses one page per packet in both the > > normal and XDP path. In addition, introducing a module parameter to enable > > or disable the

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-05-28 Thread Michael S. Tsirkin
On Sat, May 27, 2023 at 08:35:01PM +0800, Liang Chen wrote: > On Fri, May 26, 2023 at 2:51 PM Jason Wang wrote: > > > > On Fri, May 26, 2023 at 1:46 PM Liang Chen > > wrote: > > > > > > The implementation at the moment uses one page per packet in both the > > > normal and XDP path. > > > > It's

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-05-28 Thread Michael S. Tsirkin
On Sat, May 27, 2023 at 12:11:25AM +0800, kernel test robot wrote: > Hi Liang, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on net-next/main] > > url: >

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-05-28 Thread Michael S. Tsirkin
On Fri, May 26, 2023 at 01:46:18PM +0800, Liang Chen wrote: > The implementation at the moment uses one page per packet in both the > normal and XDP path. In addition, introducing a module parameter to enable > or disable the usage of page pool (disabled by default). > > In single-core vm testing

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-05-27 Thread Liang Chen
On Fri, May 26, 2023 at 2:51 PM Jason Wang wrote: > > On Fri, May 26, 2023 at 1:46 PM Liang Chen wrote: > > > > The implementation at the moment uses one page per packet in both the > > normal and XDP path. > > It's better to explain why we need a page pool and how it can help the > performance.

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-05-26 Thread kernel test robot
Hi Liang, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Liang-Chen/virtio_net-Add-page_pool-support-to-improve-performance/20230526-135805 base: net-next/main patch link:

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-05-26 Thread Jason Wang
On Fri, May 26, 2023 at 1:46 PM Liang Chen wrote: > > The implementation at the moment uses one page per packet in both the > normal and XDP path. It's better to explain why we need a page pool and how it can help the performance. > In addition, introducing a module parameter to enable > or