Re: memory leak in vhost_net_ioctl

2019-07-24 Thread Jeremy Sowden
On 2019-06-13, at 20:04:01 -0700, syzbot wrote: > syzbot has tested the proposed patch but the reproducer still > triggered crash: memory leak in batadv_tvlv_handler_register There's already a fix for this batman leak: https://lore.kernel.org/netdev/17d64c058965f...@google.com/

Re: memory leak in vhost_net_ioctl

2019-07-24 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: memory leak in batadv_tvlv_handler_register 484.626788][ T156] bond0 (unregistering): Releasing backup interface bond_slave_1 Warning: Permanently added '10.128.0.87' (ECDSA) to the list of known

memory leak in vhost_net_ioctl

2019-07-24 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:788a0249 Merge tag 'arc-5.2-rc4' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15dc9ea6a0 kernel config: https://syzkaller.appspot.com/x/.config?x=d5c73825cbdc7326

Re: memory leak in vhost_net_ioctl

2019-07-24 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: memory leak in vhost_net_ioctl ANGE): hsr_slave_1: link becomes ready 2019/06/13 18:24:57 executed programs: 18 BUG: memory leak unreferenced object 0x88811cbc6ac0 (size 64): comm "syz-execu

Re: memory leak in vhost_net_ioctl

2019-07-24 Thread Hillf Danton
Hello Syzbot On Fri, 14 Jun 2019 11:04:03 +0800 syzbot wrote: > >Hello, > >syzbot has tested the proposed patch but the reproducer still triggered crash: >memory leak in batadv_tvlv_handler_register > > 484.626788][ T156] bond0 (unregistering): Releasing backup interface > bond_slave_1

Re: memory leak in vhost_net_ioctl

2019-07-24 Thread Hillf Danton
Hello Syzbot On Fri, 14 Jun 2019 11:04:03 +0800 syzbot wrote: > >Hello, > >syzbot has tested the proposed patch but the reproducer still triggered crash: >memory leak in batadv_tvlv_handler_register > It is not ubuf leak which is addressed in this thread. Good news. I will see this new leak

Re: memory leak in vhost_net_ioctl

2019-07-24 Thread Hillf Danton
Hello Syzbot On Fri, 14 Jun 2019 02:26:02 +0800 syzbot wrote: > > Hello, > > syzbot has tested the proposed patch but the reproducer still triggered crash: > memory leak in vhost_net_ioctl > Oh sorry for my poor patch. > ANGE): hsr_slave_1: link becomes ready > 2019

Re: memory leak in vhost_net_ioctl

2019-07-24 Thread Hillf Danton
Hello Dmitry On Thu, 13 Jun 2019 20:12:06 +0800 Dmitry Vyukov wrote: > On Thu, Jun 13, 2019 at 2:07 PM Hillf Danton wrote: > > > > Hello Jason > > > > On Thu, 13 Jun 2019 17:10:39 +0800 Jason Wang wrote: > > > > > > This is basically a kfree(ubuf) after the second vhost_net_flush() in > > >

Re: memory leak in vhost_net_ioctl

2019-07-24 Thread Hillf Danton
Hello Jason On Thu, 13 Jun 2019 17:10:39 +0800 Jason Wang wrote: > > This is basically a kfree(ubuf) after the second vhost_net_flush() in > vhost_net_release(). > Fairly good catch. > Could you please post a formal patch? > I'd like very much to do that; but I wont, I am afraid, until I

Re: memory leak in vhost_net_ioctl

2019-07-24 Thread Hillf Danton
On Wed, 05 Jun 2019 16:42:05 -0700 (PDT) syzbot wrote: Hello, syzbot found the following crash on: HEAD commit:788a0249 Merge tag 'arc-5.2-rc4' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15dc9ea6a0 kernel config:

Re: memory leak in vhost_net_ioctl

2019-06-13 Thread Dmitry Vyukov via Virtualization
On Thu, Jun 13, 2019 at 4:15 PM Hillf Danton wrote: > > > Hello Dmitry > > On Thu, 13 Jun 2019 20:12:06 +0800 Dmitry Vyukov wrote: > > On Thu, Jun 13, 2019 at 2:07 PM Hillf Danton wrote: > > > > > > Hello Jason > > > > > > On Thu, 13 Jun 2019 17:10:39 +0800 Jason Wang wrote: > > > > > > > > This

Re: memory leak in vhost_net_ioctl

2019-06-13 Thread Dmitry Vyukov via Virtualization
On Thu, Jun 13, 2019 at 2:07 PM Hillf Danton wrote: > > > Hello Jason > > On Thu, 13 Jun 2019 17:10:39 +0800 Jason Wang wrote: > > > > This is basically a kfree(ubuf) after the second vhost_net_flush() in > > vhost_net_release(). > > > Fairly good catch. > > > Could you please post a formal

Re: memory leak in vhost_net_ioctl

2019-06-13 Thread Jason Wang
On 2019/6/6 下午10:40, Hillf Danton wrote: On Wed, 05 Jun 2019 16:42:05 -0700 (PDT) syzbot wrote: Hello, syzbot found the following crash on: HEAD commit:    788a0249 Merge tag 'arc-5.2-rc4' of git://git.kernel.org/p.. git tree:   upstream console output: