Re: [Qemu-devel] Re: [PATCH] virtio-spec: document block CMD and FLUSH

2010-05-05 Thread Neil Brown
On Wed, 5 May 2010 14:28:41 +0930 Rusty Russell ru...@rustcorp.com.au wrote: On Wed, 5 May 2010 05:47:05 am Jamie Lokier wrote: Jens Axboe wrote: On Tue, May 04 2010, Rusty Russell wrote: ISTR someone mentioning a desire for such an API years ago, so CC'ing the usual I/O

question on virtio

2010-05-05 Thread Michael S. Tsirkin
Hi! I see this in virtio_ring.c: /* Put entry in available array (but don't update avail-idx * until they do sync). */ Why is it done this way? It seems that updating the index straight away would be simpler, while this might allow the host to specilatively look up the buffer

Re: RFC: Network Plugin Architecture (NPA) for vmxnet3

2010-05-05 Thread Pankaj Thakkar
The purpose of this email is to introduce the architecture and the design principles. The overall project involves more than just changes to vmxnet3 driver and hence we though an overview email would be better. Once people agree to the design in general we intend to provide the code changes to

Re: RFC: Network Plugin Architecture (NPA) for vmxnet3

2010-05-05 Thread Pankaj Thakkar
Sure. We have been working on NPA for a while and have the code internally up and running. Let me sync up internally on how and when we can provide the vmxnet3 driver code so that people can look at it. On Tue, May 04, 2010 at 05:32:36PM -0700, David Miller wrote: Date: Tue, 4 May 2010 17:32:36

Re: RFC: Network Plugin Architecture (NPA) for vmxnet3

2010-05-05 Thread Christoph Hellwig
On Tue, May 04, 2010 at 04:02:25PM -0700, Pankaj Thakkar wrote: The plugin image is provided by the IHVs along with the PF driver and is packaged in the hypervisor. The plugin image is OS agnostic and can be loaded either into a Linux VM or a Windows VM. The plugin is written against the

Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3

2010-05-05 Thread Christoph Hellwig
On Wed, May 05, 2010 at 10:35:28AM -0700, Dmitry Torokhov wrote: Yes, with the exception that the only body of code that will be accepted by the shell should be GPL-licensed and thus open and available for examining. This is not different from having a standard kernel module that is loaded

RE: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3

2010-05-05 Thread Pankaj Thakkar
-Original Message- From: Christoph Hellwig [mailto:h...@infradead.org] Sent: Wednesday, May 05, 2010 10:40 AM To: Dmitry Torokhov Cc: Christoph Hellwig; pv-driv...@vmware.com; Pankaj Thakkar; net...@vger.kernel.org; linux-ker...@vger.kernel.org;

Re: RFC: Network Plugin Architecture (NPA) for vmxnet3

2010-05-05 Thread Pankaj Thakkar
On Tue, May 04, 2010 at 05:58:52PM -0700, Chris Wright wrote: Date: Tue, 4 May 2010 17:58:52 -0700 From: Chris Wright chr...@sous-sol.org To: Pankaj Thakkar pthak...@vmware.com CC: linux-ker...@vger.kernel.org linux-ker...@vger.kernel.org, net...@vger.kernel.org net...@vger.kernel.org,

[PATCH 1/1] staging: hv: Add Time Sync feature to hv_utils module

2010-05-05 Thread Haiyang Zhang
From: Haiyang Zhang haiya...@microsoft.com Subject: Add Time Sync feature to hv_utils module. The Time Sync feature synchronizes guest time to host UTC time after reboot, and restore from saved/paused state. Cc: Greg Kroah-Hartman gre...@suse.de Signed-off-by: Hank Janssen hjans...@microsoft.com

Re: RFC: Network Plugin Architecture (NPA) for vmxnet3

2010-05-05 Thread Pankaj Thakkar
On Wed, May 05, 2010 at 10:59:51AM -0700, Avi Kivity wrote: Date: Wed, 5 May 2010 10:59:51 -0700 From: Avi Kivity a...@redhat.com To: Pankaj Thakkar pthak...@vmware.com CC: linux-ker...@vger.kernel.org linux-ker...@vger.kernel.org, net...@vger.kernel.org net...@vger.kernel.org,

Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3

2010-05-05 Thread Arnd Bergmann
On Wednesday 05 May 2010 19:47:10 Pankaj Thakkar wrote: Forget about the licensing. Loading binary blobs written to a shim layer is a complete pain in the ass and totally unsupportable, and also uninteresting because of the overhead. [PT] Why do you think it is unsupportable? How

[PATCH 3/3] virtio: console: Accept console size along with resize control message

2010-05-05 Thread Amit Shah
The VIRTIO_CONSOLE_RESIZE control message sent to us by the host now contains the new {rows, cols} values for the console. This ensures each console port gets its own size, and we don't depend on the config-space rows and cols values at all now. Signed-off-by: Amit Shah amit.s...@redhat.com CC:

[PATCH RFC] virtio: put last seen used index into ring itself

2010-05-05 Thread Michael S. Tsirkin
Generally, the Host end of the virtio ring doesn't need to see where Guest is up to in consuming the ring. However, to completely understand what's going on from the outside, this information must be exposed. For example, host can reduce the number of interrupts by detecting that the guest is

Re: question on virtio

2010-05-05 Thread Michael S. Tsirkin
On Wed, May 05, 2010 at 02:40:15PM -0500, Anthony Liguori wrote: On 05/05/2010 06:09 AM, Michael S. Tsirkin wrote: Hi! I see this in virtio_ring.c: /* Put entry in available array (but don't update avail-idx * until they do sync). */ Why is it done this way? It seems that

Re: [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-05 Thread Dor Laor
On 05/05/2010 11:58 PM, Michael S. Tsirkin wrote: Generally, the Host end of the virtio ring doesn't need to see where Guest is up to in consuming the ring. However, to completely understand what's going on from the outside, this information must be exposed. For example, host can reduce the

Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3

2010-05-05 Thread Arnd Bergmann
On Wednesday 05 May 2010 22:36:31 Dmitry Torokhov wrote: On Wednesday 05 May 2010 01:09:48 pm Arnd Bergmann wrote: If you have any interesting in developing this further, do: (1) move the limited VF drivers directly into the kernel tree, talk to them through a normal ops

Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3

2010-05-05 Thread Dmitry Torokhov
On Wednesday 05 May 2010 10:23:16 am Christoph Hellwig wrote: On Tue, May 04, 2010 at 04:02:25PM -0700, Pankaj Thakkar wrote: The plugin image is provided by the IHVs along with the PF driver and is packaged in the hypervisor. The plugin image is OS agnostic and can be loaded either into a

Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3

2010-05-05 Thread Dmitry Torokhov
On Wednesday 05 May 2010 10:31:20 am Christoph Hellwig wrote: On Wed, May 05, 2010 at 10:29:40AM -0700, Dmitry Torokhov wrote: We're not going to add any kind of loader for binry blobs into kernel space, sorry. Don't even bother wasting your time on this. It would not be a binary blob

Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3

2010-05-05 Thread Dmitry Torokhov
On Wednesday 05 May 2010 01:09:48 pm Arnd Bergmann wrote: If you have any interesting in developing this further, do: (1) move the limited VF drivers directly into the kernel tree, talk to them through a normal ops vector [PT] This assumes that all the VF drivers would

Re: virtio: put last_used and last_avail index into ring itself.

2010-05-05 Thread Rusty Russell
On Wed, 5 May 2010 03:52:36 am Michael S. Tsirkin wrote: virtio: put last_used and last_avail index into ring itself. Generally, the other end of the virtio ring doesn't need to see where you're up to in consuming the ring. However, to completely understand what's going on from the

Re: [PATCH 1/1] staging: hv: Add Time Sync feature to hv_utils module

2010-05-05 Thread Joe Perches
On Wed, 2010-05-05 at 19:23 +, Haiyang Zhang wrote: From: Haiyang Zhang haiya...@microsoft.com Subject: Add Time Sync feature to hv_utils module. The Time Sync feature synchronizes guest time to host UTC time after reboot, and restore from saved/paused state. +static void

Re: question on virtio

2010-05-05 Thread Rusty Russell
On Wed, 5 May 2010 08:39:47 pm Michael S. Tsirkin wrote: Hi! I see this in virtio_ring.c: /* Put entry in available array (but don't update avail-idx * until they do sync). */ Why is it done this way? It seems that updating the index straight away would be simpler, while

RE: [PATCH 1/1] staging: hv: Add Time Sync feature to hv_utils module

2010-05-05 Thread Joe Perches
On Thu, 2010-05-06 at 01:42 +, Haiyang Zhang wrote: Why a maximum of 50 samples? After reboot the flag ICTIMESYNCFLAG_SYNC is included in the first time message after the timesync channel is opened. Since the hv_utils module is loaded after hv_vmbus, the first message is usually

Re: [PATCH 0/3] virtio: console: Handle multiple console port resizes

2010-05-05 Thread Rusty Russell
On Thu, 6 May 2010 06:05:06 am Amit Shah wrote: Hello, This series adds resize support for multiple console ports. The size for each console is stored in its structure and the host informs the guest about size changes via the VIRTIO_CONSOLE_RESIZE control message. Thanks, applied! Rusty.

Re: [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-05 Thread Rusty Russell
On Thu, 6 May 2010 06:28:14 am Michael S. Tsirkin wrote: Rusty, this is a simplified form of a patch you posted in the past. I have a vhost patch that, using this feature, shows external to host bandwidth grow from 5 to 7 GB/s, by avoiding an interrupt in the window after previous interrupt