various vmbus review comments

2011-05-03 Thread Greg KH
I just took a quick look at the vmbus code, and have the following comments: - why is count_hv_channel() even a function? - your .h files need to be consolidated and renamed. You will need a single hyperv.h file for include/linux/ that will contain some of what

RE: various vmbus review comments

2011-05-03 Thread KY Srinivasan
-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Tuesday, May 03, 2011 4:47 PM To: KY Srinivasan Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org Subject: various vmbus review comments I just took a

Re: various vmbus review comments

2011-05-03 Thread Greg KH
On Tue, May 03, 2011 at 09:00:01PM +, KY Srinivasan wrote: You had also suggested that I should ask for a community review once you had had applied my last set of patches. Now that you have applied all my patches, should I formally ask for this review? I said something like after my review

RE: various vmbus review comments

2011-05-03 Thread KY Srinivasan
-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Tuesday, May 03, 2011 6:04 PM To: KY Srinivasan Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org Subject: Re: various vmbus review comments On Tue, May