Re: [PATCH 006/117] Staging: hv: blkvsc: Use the newly introduced vmbus ID in the blockvsc driver

2011-08-23 Thread Greg KH
On Fri, Jul 15, 2011 at 10:45:54AM -0700, K. Y. Srinivasan wrote: Use the newly introduced vmbus ID in the blockvsc driver. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c | 16 1

Re: [PATCH 036/117] Staging: hv: vmbus: Make class_id attribute a human readable string

2011-08-23 Thread Greg KH
On Fri, Jul 15, 2011 at 10:46:24AM -0700, K. Y. Srinivasan wrote: Now that we have a human readable device_type, use that and get rid of the guid based device type. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com ---

Re: [PATCH 012/117] Staging: hv: blkvsc: Add the MODULE_DEVICE_TABLE() line

2011-08-23 Thread Greg KH
On Fri, Jul 15, 2011 at 10:46:00AM -0700, K. Y. Srinivasan wrote: Add the MODULE_DEVICE_TABLE() line in blkvsc_drv.c. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c |1 + 1 files changed, 1

Re: [PATCH 035/117] Staging: hv: vmbus: Introduce a function to map the dev_type guid to a name

2011-08-23 Thread Greg KH
On Fri, Jul 15, 2011 at 10:46:23AM -0700, K. Y. Srinivasan wrote: To support human readable sysfs attribute, introduce a function to map the dev_type guid to a string. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com ---

Re: [PATCH 027/117] Staging: hv: blkvsc: Get rid of the dev_type guid from blkvsc_drv.c

2011-08-23 Thread Greg KH
On Fri, Jul 15, 2011 at 10:46:15AM -0700, K. Y. Srinivasan wrote: Get rid of the dev_type guid from blkvsc_drv.c as it is no longer used. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c |9

Re: [PATCH 003/117] Staging: hv: Add struct hv_vmbus_device_id to mod_devicetable.h

2011-08-23 Thread Greg KH
On Fri, Jul 15, 2011 at 10:45:51AM -0700, K. Y. Srinivasan wrote: In preparation for implementing vmbus aliases for auto-loading Hyper-V drivers, define vmbus specific device ID. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com ---

Re: [PATCH 020/117] Staging: hv: vmbus: Support the notion of id tables in vmbus_match()

2011-08-23 Thread Greg KH
On Fri, Jul 15, 2011 at 10:46:08AM -0700, K. Y. Srinivasan wrote: Introduce code to handle driver specific id tables to the vmbus core (vmbus_match). This would allow us to handle more than one device type with a given driver. Signed-off-by: K. Y. Srinivasan k...@microsoft.com

Re: [PATCH 037/117] Staging: hv: vmbus: Get rid of the device_id attribute

2011-08-23 Thread Greg KH
On Fri, Jul 15, 2011 at 10:46:25AM -0700, K. Y. Srinivasan wrote: The guid based instance data is not very useful. There is enough information to identify the device. Get rid of this attribute. But userspace probably wants to see this at times, don't remove it, someone is going to need it,

Re: [PATCH 081/117] Staging: hv: vmbus: Introduce a lock to protect the ext field in hv_device

2011-08-23 Thread Greg KH
On Fri, Jul 15, 2011 at 10:47:09AM -0700, K. Y. Srinivasan wrote: The current mechanism for handling references in broken. Introduce a lock to protect the ext field in hv_device. Why would that lock ever be needed? How can things change to this pointer in different ways like you are thinking

Re: [PATCH 017/117] Staging: hv: mouse: Do not auto-load the mouse driver

2011-08-23 Thread Greg KH
On Fri, Jul 15, 2011 at 10:46:05AM -0700, K. Y. Srinivasan wrote: The mouse driver is not functional and so, prevent auto-loading of this driver. Earlier we added the MODULE_DEVICE_TABLE() line to verify that the appropriate module alias was generated. Signed-off-by: K. Y. Srinivasan

Re: [PATCH 086/117] Staging: hv: storvsc: Leverage the spinlock to manage ref_cnt

2011-08-23 Thread Greg KH
On Fri, Jul 15, 2011 at 10:47:14AM -0700, K. Y. Srinivasan wrote: Now that we have a spin lock protecting access to the stor device pointer, use it manage the reference count as well. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com ---

Re: [PATCH 040/117] Staging: hv: vmbus: Cleanup error handling in hv_init()

2011-08-23 Thread Greg KH
On Fri, Jul 15, 2011 at 10:46:28AM -0700, K. Y. Srinivasan wrote: Use standard Linux error codes. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com --- drivers/staging/hv/hv.c |4 ++-- 1 files changed, 2 insertions(+), 2

Re: [PATCH 019/117] Staging: hv: vmbus: Cleanup vmbus_uevent() code

2011-08-23 Thread Greg KH
On Fri, Jul 15, 2011 at 10:46:07AM -0700, K. Y. Srinivasan wrote: Now generate appropriate uevent based on the modalias string. As part of this, cleanup the existing uevent code. Note, you just change the user api here, did you have tools that relied on the old format? If so, they just broke

Re: [PATCH 0000/0117] Staging: hv: Driver cleanup

2011-08-23 Thread Greg KH
On Fri, Jul 15, 2011 at 10:47:04AM -0700, K. Y. Srinivasan wrote: Further cleanup of the hv drivers. Back in June I had sent two patch sets to address these issues. I have addressed the comments I got from the community on my earlier patches here: 1) Implement code for autoloading the

Re: [PATCH 011/117] Staging: hv: util: Use the newly introduced vmbus ID in util driver

2011-08-23 Thread Greg KH
On Fri, Jul 15, 2011 at 10:45:59AM -0700, K. Y. Srinivasan wrote: Use the newly introduced vmbus ID in util driver. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com --- drivers/staging/hv/hv_util.c | 38

Re: [PATCH 1/8] Staging: hv: vmbus: Fix a checkpatch warning in ring_buffer.c

2011-08-23 Thread Greg KH
On Tue, Jul 19, 2011 at 11:44:18AM -0700, K. Y. Srinivasan wrote: Fix a checkpatch warning in ring_buffer.c (line over 80 characters). Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com --- drivers/staging/hv/ring_buffer.c |3 ++- 1

Re: [PATCH 4/8] Staging: hv: vmbus: Fix checkpatch warnings

2011-08-23 Thread Greg KH
On Tue, Jul 19, 2011 at 11:44:21AM -0700, K. Y. Srinivasan wrote: Fix checkpatch warnings in hv.c Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com --- drivers/staging/hv/hv.c |4 ++-- 1 files changed, 2 insertions(+), 2

RE: [PATCH 019/117] Staging: hv: vmbus: Cleanup vmbus_uevent() code

2011-08-23 Thread KY Srinivasan
-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Tuesday, August 23, 2011 6:50 PM To: KY Srinivasan Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang Subject: Re: [PATCH 019/117] Staging: hv:

RE: [PATCH 003/117] Staging: hv: Add struct hv_vmbus_device_id to mod_devicetable.h

2011-08-23 Thread KY Srinivasan
-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Tuesday, August 23, 2011 6:42 PM To: KY Srinivasan Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang Subject: Re: [PATCH 003/117] Staging: hv:

RE: [PATCH 081/117] Staging: hv: vmbus: Introduce a lock to protect the ext field in hv_device

2011-08-23 Thread KY Srinivasan
-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Tuesday, August 23, 2011 7:08 PM To: KY Srinivasan Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang Subject: Re: [PATCH 081/117] Staging: hv:

RE: [PATCH 086/117] Staging: hv: storvsc: Leverage the spinlock to manage ref_cnt

2011-08-23 Thread KY Srinivasan
-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Tuesday, August 23, 2011 7:10 PM To: KY Srinivasan Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang Subject: Re: [PATCH 086/117] Staging: hv:

RE: [PATCH 0000/0117] Staging: hv: Driver cleanup

2011-08-23 Thread KY Srinivasan
-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Tuesday, August 23, 2011 7:11 PM To: KY Srinivasan Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org Subject: Re: [PATCH /0117] Staging: hv: Driver

RE: [PATCH 4/8] Staging: hv: vmbus: Fix checkpatch warnings

2011-08-23 Thread KY Srinivasan
-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Tuesday, August 23, 2011 7:17 PM To: KY Srinivasan Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang Subject: Re: [PATCH 4/8] Staging: hv:

Re: [PATCH 019/117] Staging: hv: vmbus: Cleanup vmbus_uevent() code

2011-08-23 Thread Greg KH
On Wed, Aug 24, 2011 at 12:38:09AM +, KY Srinivasan wrote: -Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Tuesday, August 23, 2011 6:50 PM To: KY Srinivasan Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;

Re: [PATCH 081/117] Staging: hv: vmbus: Introduce a lock to protect the ext field in hv_device

2011-08-23 Thread Greg KH
On Wed, Aug 24, 2011 at 12:55:12AM +, KY Srinivasan wrote: -Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Tuesday, August 23, 2011 7:08 PM To: KY Srinivasan Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;

Re: [PATCH 003/117] Staging: hv: Add struct hv_vmbus_device_id to mod_devicetable.h

2011-08-23 Thread Greg KH
On Wed, Aug 24, 2011 at 12:44:38AM +, KY Srinivasan wrote: -Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Tuesday, August 23, 2011 6:42 PM To: KY Srinivasan Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;

Re: [PATCH 086/117] Staging: hv: storvsc: Leverage the spinlock to manage ref_cnt

2011-08-23 Thread Greg KH
On Wed, Aug 24, 2011 at 12:58:36AM +, KY Srinivasan wrote: -Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Tuesday, August 23, 2011 7:10 PM To: KY Srinivasan Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;

Re: [PATCH 0000/0117] Staging: hv: Driver cleanup

2011-08-23 Thread Greg KH
On Wed, Aug 24, 2011 at 01:01:26AM +, KY Srinivasan wrote: Thank you for your comments. I will try to re-submit these patches as soon as I possibly can. If I were to get these patches re-spun and sent to you in the next couple of days, can I still make this current merge window? You ever