-Original Message-
From: Greg KH [mailto:g...@kroah.com]
Sent: Wednesday, August 24, 2011 10:40 PM
To: KY Srinivasan
Cc: de...@linuxdriverproject.org; Haiyang Zhang; gre...@suse.de; linux-
ker...@vger.kernel.org; virtualizat...@lists.osdl.org
Subject: Re: [PATCH 003/117] Staging:
The patch is against 3.0.
Signed-off-by: Wang Sheng-Hui shh...@gmail.com
---
include/linux/virtio.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/virtio.h b/include/linux/virtio.h
index 7108857..e0a1973 100644
--- a/include/linux/virtio.h
+++
Now that we have implemented a vmbus specific mechanism for auto-loading,
get rid of the PCI signature.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/netvsc_drv.c |8
1 files changed, 0 insertions(+), 8
Use the newly introduced vmbus ID in the blockvsc driver. Also, do
the associated cleanup.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/blkvsc_drv.c | 23 ++-
1 files changed, 14 insertions(+),
Now that we have implemented a vmbus specific mechanism for auto-loading,
get rid of the DMI signature.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/storvsc_drv.c | 22 --
1 files changed, 0
Use the newly introduced vmbus ID in netvsc driver. Also, do the associated
cleanup.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/netvsc.c | 10 --
drivers/staging/hv/netvsc_drv.c | 16
Now that we have implemented a vmbus specific mechanism for auto-loading,
get rid of the PCI signature.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/hv_util.c |8
1 files changed, 0 insertions(+), 8
Cleanup unnecessary comments in hv.c.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/hv.c |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/hv/hv.c
Get rid of the unused name field in struct hv_driver.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/hyperv.h |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/hv/hyperv.h
Get rid of the function dump_gpadl_body() since it adds no value and actually is
in the data path.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/channel.c | 20
1 files changed, 0
Get rid of unnecessary comments in channel.c.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/channel.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/hv/channel.c
Initialize the driver name directly in netvsc_drv.c and do the necessary
adjustments.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/netvsc.c |5 -
drivers/staging/hv/netvsc_drv.c |4 +++-
2 files
In preparation for supporting auto-loading Hyper-V drivers
using vmbus specific aliases, introduce vmbus ID space in struct hv_driver.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/hyperv.h |2 ++
1 files
Introduce code to handle driver specific id tables to the vmbus core
(vmbus_match). This would allow us to handle more than one device type
with a given driver.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
Rename openMsg to open_msg in channel.c.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/channel.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git
Use standard Linux error codes.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/hv.c |7 +++
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/hv/hv.c b/drivers/staging/hv/hv.c
Use standard Linux error values and cleanup error handling. I would like
to acknowledge Andre Bartke (andre.bar...@gmail.com) for highlighting this
problem.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/storvsc.c |
Get rid of the function dump_gpadl_header() as this adds no value.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/channel.c | 28
1 files changed, 0 insertions(+), 28 deletions(-)
diff
Now generate appropriate uevent based on the modalias string. As part of this,
cleanup the existing uevent code.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/vmbus_drv.c | 60
Use the newly introduced vmbus ID in mouse driver. Also, do the associated
cleanup. Since the mouse driver is not functional, we disable the
autoloading of this driver.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
VMBUS is an ACPI enumerated device, get rid of the PCI signature.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/vmbus_drv.c | 13 -
1 files changed, 0 insertions(+), 13 deletions(-)
diff --git
Change the variable name openInfo to open_info in channel.c.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/channel.c | 24
1 files changed, 12 insertions(+), 12 deletions(-)
diff --git
Use standard Linux errno values.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/channel.c |2 +-
drivers/staging/hv/hv_mouse.c |2 +-
drivers/staging/hv/netvsc.c |2 +-
3 files changed, 3 insertions(+),
Use the newly introduced vmbus ID in storvsc driver. Also, do the
assciated cleanup.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/storvsc_drv.c | 25 ++---
1 files changed, 14 insertions(+), 11
Further cleanup of the hv drivers.
1) Implement code for autoloading the vmbus drivers without using PCI
or DMI
signatures. I have implemented this based on Greg's feedback on my
earlier
implementation.
2) Cleanup error handling across the board and use
Add code to parse struct hv_vmbus_device_id table.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
scripts/mod/file2alias.c | 25 +
1 files changed, 25 insertions(+), 0 deletions(-)
diff --git
Use standard Linux error codes.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/storvsc_drv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/hv/storvsc_drv.c
Change the jump label Cleanup to cleanup.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/hv_mouse.c | 22 +++---
1 files changed, 11 insertions(+), 11 deletions(-)
diff --git
Use standard Linux error codes.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/netvsc_drv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/hv/netvsc_drv.c
Cleanup error return codes in netvsc_destroy_recv_buf().
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/netvsc.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/hv/netvsc.c
Get rid of some unnecessary DPRINTs from storvsc.c.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/storvsc.c | 16
1 files changed, 0 insertions(+), 16 deletions(-)
diff --git
The function hv_post_msg() can fail because of transient resource
conditions. It may be useful to retry the operation.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
arch/x86/include/asm/hyperv.h |1 +
Use standard Linux error codes.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/rndis_filter.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/hv/rndis_filter.c
Use standard Linux error codes.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/storvsc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/hv/storvsc.c
Use standard Linux error codes.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/netvsc.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/hv/netvsc.c
Get rid of unnecessay comments in connection.c.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/connection.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/hv/connection.c
Use standard Linux error codes.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/netvsc.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/hv/netvsc.c
Now that we have implemented a vmbus specific mechanism for auto-loading,
get rid of the DMI signature.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/hv_util.c | 20
1 files changed, 0
Use standard Linux errno values in ringbuffer.c and do the associated
cleanup in the clients.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/blkvsc_drv.c |2 +-
drivers/staging/hv/netvsc.c |2 +-
Now, get rid of the empty function netvsc_initialize().
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/hyperv_net.h |1 -
drivers/staging/hv/netvsc.c |9 -
drivers/staging/hv/netvsc_drv.c |3
Get rid of an unnecessary print statement in netvsc_probe(). Furthermore,
this fixes a bug since netdev_err is being invoked after the device has
been freed.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/netvsc_drv.c
Change the jump label Cleanup to cleanup.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/rndis_filter.c | 28 ++--
1 files changed, 14 insertions(+), 14 deletions(-)
diff --git
Use standard Linux error codes.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/netvsc.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/hv/netvsc.c
Use standard Linux error codes.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/storvsc_drv.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/hv/storvsc_drv.c
Use standard Linux error codes and cleanup some error paths.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/rndis_filter.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git
Use standard Linux error codes.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/rndis_filter.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/hv/rndis_filter.c
Use standard Linux error codes.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/storvsc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/hv/storvsc.c
Change the jump lable Exit to exit.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/rndis_filter.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/hv/rndis_filter.c
Get rid of an unnecessary include line in vmbus_drv.c.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/vmbus_drv.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/hv/vmbus_drv.c
Use standard Linux error codes.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/storvsc_drv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/hv/storvsc_drv.c
Use standard Linux error codes.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/rndis_filter.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/hv/rndis_filter.c
Cleanup error handling in storvsc_connect_to_vsp().
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/storvsc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/hv/storvsc.c
Use the preferred mechanism to compare guids in vmbus_match().
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/vmbus_drv.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git
On Thu, Aug 25, 2011 at 02:24:28PM -0700, Greg KH wrote:
On Thu, Aug 25, 2011 at 09:48:48AM -0700, K. Y. Srinivasan wrote:
Get rid of the unused name field in struct hv_driver.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
On Thu, Aug 25, 2011 at 09:48:48AM -0700, K. Y. Srinivasan wrote:
Get rid of the unused name field in struct hv_driver.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
---
drivers/staging/hv/hyperv.h |2 --
1 files changed, 0
On Thu, Aug 25, 2011 at 02:28:20PM -0700, Greg KH wrote:
Man, if you want something done right, you have to do it yourself, let
me go make these changes so you don't have to do any new work at this
point in time, hopefully your other patches will apply...
What,
-Original Message-
From: Greg KH [mailto:g...@kroah.com]
Sent: Thursday, August 25, 2011 5:00 PM
To: KY Srinivasan
Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang
Subject: Re: [PATCH 12/59] Staging: hv:
-Original Message-
From: Greg KH [mailto:g...@kroah.com]
Sent: Thursday, August 25, 2011 5:15 PM
To: KY Srinivasan
Cc: de...@linuxdriverproject.org; Haiyang Zhang; gre...@suse.de; linux-
ker...@vger.kernel.org; virtualizat...@lists.osdl.org
Subject: Re: [PATCH 12/59] Staging: hv:
On Thu, Aug 25, 2011 at 10:14:05PM +, KY Srinivasan wrote:
-Original Message-
From: Greg KH [mailto:g...@kroah.com]
Sent: Thursday, August 25, 2011 5:00 PM
To: KY Srinivasan
Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
de...@linuxdriverproject.org;
-Original Message-
From: Greg KH [mailto:g...@kroah.com]
Sent: Thursday, August 25, 2011 5:28 PM
To: KY Srinivasan
Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang
Subject: Re: [PATCH 22/59] Staging: hv:
On Thu, Aug 25, 2011 at 10:20:32PM +, KY Srinivasan wrote:
I have to edit this to get it to work properly with the fact that I
added the driver_data field to hv_vmbus_device_id.
You should have a copy of the patch I applied in your inbox now, can you
verify I didn't mess it up?
On Thu, Aug 25, 2011 at 10:27:40PM +, KY Srinivasan wrote:
This was existing code and I realized it did not conform to the Linux
Driver Model. I fixed it in the patch set I had sent earlier (110/117).
Yesterday I only got up to 74 of the 117 patches that you commented on.
I was planning to
-Original Message-
From: Greg KH [mailto:g...@kroah.com]
Sent: Thursday, August 25, 2011 6:28 PM
To: KY Srinivasan
Cc: de...@linuxdriverproject.org; Haiyang Zhang; gre...@suse.de; linux-
ker...@vger.kernel.org; virtualizat...@lists.osdl.org
Subject: Re: [PATCH 12/59] Staging: hv:
On Thu, 25 Aug 2011 21:04:05 +0800, Wang Sheng-Hui shh...@gmail.com wrote:
The patch is against 3.0.
Signed-off-by: Wang Sheng-Hui shh...@gmail.com
Thanks, applied!
Cheers,
Rusty.
___
Virtualization mailing list
64 matches
Mail list logo