Re: [PATCH v2 09/11] virtio: net: Add freeze, restore handlers to support S4

2011-11-15 Thread Amit Shah
On (Sun) 02 Oct 2011 [11:33:26], Michael S. Tsirkin wrote: On Thu, Sep 29, 2011 at 09:19:40PM +0530, Amit Shah wrote: Remove all the vqs on hibernation and re-create them after restoring from a hibernated image. This keeps networking working across hibernation. Signed-off-by: Amit

Re: [PATCH v2 09/11] virtio: net: Add freeze, restore handlers to support S4

2011-11-15 Thread Michael S. Tsirkin
On Tue, Nov 15, 2011 at 05:59:36PM +0530, Amit Shah wrote: On (Sun) 02 Oct 2011 [11:33:26], Michael S. Tsirkin wrote: On Thu, Sep 29, 2011 at 09:19:40PM +0530, Amit Shah wrote: Remove all the vqs on hibernation and re-create them after restoring from a hibernated image. This keeps

Re: [PATCH 00/11] virtio: Support for hibernation (S4)

2011-11-15 Thread Amit Shah
On (Tue) 04 Oct 2011 [10:36:05], Rusty Russell wrote: On Sun, 2 Oct 2011 11:49:21 +0200, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Sep 29, 2011 at 08:55:56PM +0530, Amit Shah wrote: Hello, These patches add support for S4 to virtio (pci) and all drivers. The patches are

Re: [RFC 0/5] virtio-pci,kvm tools: Support new virtio-pci spec in kvm tools

2011-11-15 Thread Michael S. Tsirkin
On Tue, Nov 15, 2011 at 01:43:12AM +0200, Sasha Levin wrote: This patch series contains two fixes for the RFC patch send by Michael. These patches are pretty basic and should probably be merged into the next version of that patch. Yes, will do, thanks! Other two patches add support to the

[PATCH] virtio-mmio: Correct the name of the guest features selector

2011-11-15 Thread Sasha Levin
Guest features selector spelling mistake. Cc: Pawel Moll pawel.m...@arm.com Cc: Rusty Russell ru...@rustcorp.com.au Cc: virtualization@lists.linux-foundation.org Signed-off-by: Sasha Levin levinsasha...@gmail.com --- Hopefully not too late to fix, should possibly be done in one of the next RCs

Re: [PATCH v2 09/11] virtio: net: Add freeze, restore handlers to support S4

2011-11-15 Thread Michael S. Tsirkin
On Tue, Nov 15, 2011 at 07:33:46PM +0530, Amit Shah wrote: On (Tue) 15 Nov 2011 [14:51:27], Michael S. Tsirkin wrote: On Tue, Nov 15, 2011 at 05:59:36PM +0530, Amit Shah wrote: On (Sun) 02 Oct 2011 [11:33:26], Michael S. Tsirkin wrote: On Thu, Sep 29, 2011 at 09:19:40PM +0530, Amit Shah

Re: [PATCH v2 09/11] virtio: net: Add freeze, restore handlers to support S4

2011-11-15 Thread Michael S. Tsirkin
On Tue, Nov 15, 2011 at 08:01:49PM +0530, Amit Shah wrote: On (Tue) 15 Nov 2011 [16:23:00], Michael S. Tsirkin wrote: On Tue, Nov 15, 2011 at 07:33:46PM +0530, Amit Shah wrote: On (Tue) 15 Nov 2011 [14:51:27], Michael S. Tsirkin wrote: On Tue, Nov 15, 2011 at 05:59:36PM +0530, Amit Shah

Re: [PATCH] virtio-mmio: Correct the name of the guest features selector

2011-11-15 Thread Pawel Moll
On Tue, 2011-11-15 at 14:17 +, Sasha Levin wrote: Guest features selector spelling mistake. diff --git a/include/linux/virtio_mmio.h b/include/linux/virtio_mmio.h index 27c7ede..5c7b6f0 100644 --- a/include/linux/virtio_mmio.h +++ b/include/linux/virtio_mmio.h @@ -63,7 +63,7 @@

Re: [RFC] kvm tools: Implement multiple VQ for virtio-net

2011-11-15 Thread Sasha Levin
On Tue, 2011-11-15 at 10:14 +0530, Krishna Kumar2 wrote: Sasha Levin levinsasha...@gmail.com wrote on 11/14/2011 03:45:40 PM: Why both the bandwidth and latency performance are dropping so dramatically with multiple VQ? It looks like theres no hash sync between host and guest, which

Re: [PATCHv2 RFC] virtio-spec: flexible configuration layout

2011-11-15 Thread Rusty Russell
On Sun, 13 Nov 2011 17:14:27 +0200, Michael S. Tsirkin m...@redhat.com wrote: On Fri, Nov 11, 2011 at 02:54:31PM +1030, Rusty Russell wrote: Indeed, I'd like to see two changes to your proposal: (1) It should be all or nothing. If a driver can find the virtio header capability, it

Re: [PATCHv2 RFC] virtio-spec: flexible configuration layout

2011-11-15 Thread Rusty Russell
On Fri, 11 Nov 2011 09:39:13 +0200, Sasha Levin levinsasha...@gmail.com wrote: On Fri, Nov 11, 2011 at 6:24 AM, Rusty Russell ru...@rustcorp.com.au wrote: (2) There's no huge win in keeping the same layout.  Let's make some    cleanups.  There are more users ahead of us then behind us (I    

Re: [PATCH] virtio-mmio: Correct the name of the guest features selector

2011-11-15 Thread Rusty Russell
On Tue, 15 Nov 2011 14:25:22 +, Pawel Moll pawel.m...@arm.com wrote: On Tue, 2011-11-15 at 14:17 +, Sasha Levin wrote: Guest features selector spelling mistake. diff --git a/include/linux/virtio_mmio.h b/include/linux/virtio_mmio.h index 27c7ede..5c7b6f0 100644 ---

Re: [PATCH] virtio-mmio: Devices parameter parsing

2011-11-15 Thread Rusty Russell
On Tue, 15 Nov 2011 13:53:05 +, Pawel Moll pawel.m...@arm.com wrote: +static char *virtio_mmio_cmdline_devices; +module_param_named(devices, virtio_mmio_cmdline_devices, charp, 0); This is the wrong way to do this. Don't put things in a charp and process it later. It's lazy. You should

Re: [PATCH 5 of 5] virtio: expose added descriptors immediately

2011-11-15 Thread Rusty Russell
On Mon, 14 Nov 2011 08:56:06 +0200, Michael S. Tsirkin m...@redhat.com wrote: On Sun, Nov 13, 2011 at 11:03:13PM +0200, Michael S. Tsirkin wrote: On Thu, Nov 03, 2011 at 06:12:53PM +1030, Rusty Russell wrote: A virtio driver does virtqueue_add_buf() multiple times before finally calling

Re: [RFC] kvm tools: Implement multiple VQ for virtio-net

2011-11-15 Thread jason wang
On 11/15/2011 12:44 PM, Krishna Kumar2 wrote: Sasha Levin levinsasha...@gmail.com wrote on 11/14/2011 03:45:40 PM: Why both the bandwidth and latency performance are dropping so dramatically with multiple VQ? It looks like theres no hash sync between host and guest, which makes the RX VQ

Re: [PATCHv2 RFC] virtio-spec: flexible configuration layout

2011-11-15 Thread Michael S. Tsirkin
On Wed, Nov 16, 2011 at 10:28:05AM +1030, Rusty Russell wrote: On Sun, 13 Nov 2011 17:14:27 +0200, Michael S. Tsirkin m...@redhat.com wrote: On Fri, Nov 11, 2011 at 02:54:31PM +1030, Rusty Russell wrote: Indeed, I'd like to see two changes to your proposal: (1) It should be all or

Re: [PATCH 5 of 5] virtio: expose added descriptors immediately

2011-11-15 Thread Michael S. Tsirkin
On Wed, Nov 16, 2011 at 10:51:26AM +1030, Rusty Russell wrote: On Mon, 14 Nov 2011 08:56:06 +0200, Michael S. Tsirkin m...@redhat.com wrote: On Sun, Nov 13, 2011 at 11:03:13PM +0200, Michael S. Tsirkin wrote: On Thu, Nov 03, 2011 at 06:12:53PM +1030, Rusty Russell wrote: A virtio

Re: [PATCHv2 RFC] virtio-spec: flexible configuration layout

2011-11-15 Thread Michael S. Tsirkin
On Wed, Nov 16, 2011 at 10:28:52AM +1030, Rusty Russell wrote: On Fri, 11 Nov 2011 09:39:13 +0200, Sasha Levin levinsasha...@gmail.com wrote: On Fri, Nov 11, 2011 at 6:24 AM, Rusty Russell ru...@rustcorp.com.au wrote: (2) There's no huge win in keeping the same layout.  Let's make some

Re: [RFC] kvm tools: Implement multiple VQ for virtio-net

2011-11-15 Thread Michael S. Tsirkin
On Wed, Nov 16, 2011 at 10:34:42AM +1030, Rusty Russell wrote: On Mon, 14 Nov 2011 15:05:07 +0200, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Nov 14, 2011 at 02:25:17PM +0200, Pekka Enberg wrote: On Mon, Nov 14, 2011 at 4:04 AM, Asias He asias.he...@gmail.com wrote: Why both the