Re: [PATCH] virtio_console: Don't access uninitialized data.
On (Mon) 04 Feb 2013 [10:09:05], Rusty Russell wrote: > Amit Shah writes: > > On (Thu) 17 Jan 2013 [13:21:32], sjur.brandel...@stericsson.com wrote: > >> From: Sjur Brændeland > >> > >> Don't access uninitialized work-queue when removing device. > >> The work queue is initialized only if the device multi-queue. > >> So don't call cancel_work unless this is a multi-queue device. > >> > >> This fixes the following panic: > > > > [snip] > > > >> Signed-off-by: Sjur Brændeland > > > > Acked-by: Amit Shah > > > >> This fix is intended of v3.8. > > > > Should also be CC'ed to stable@ > > Sorry, I was at linux.conf.au all last week. > > I've already sent it to Linus. Sjur said: "This fix is intended of > v3.8.". If it needs to be in -stable, please tell me and I'll fwd it > manually. This can result in a panic when removing the device or module (when not using multiport). I'd vote for submitting to stable. Amit ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[PATCH 8/8] drivers:net:misc: Remove unnecessary alloc/OOM messages
alloc failures already get standardized OOM
messages and a dump_stack.
Signed-off-by: Joe Perches
---
drivers/net/hamradio/dmascc.c | 7 +--
drivers/net/phy/spi_ks8995.c | 4 +---
drivers/net/virtio_net.c | 4 +---
3 files changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/net/hamradio/dmascc.c b/drivers/net/hamradio/dmascc.c
index ce555d9..6636022 100644
--- a/drivers/net/hamradio/dmascc.c
+++ b/drivers/net/hamradio/dmascc.c
@@ -463,13 +463,8 @@ static int __init setup_adapter(int card_base, int type,
int n)
/* Initialize what is necessary for write_scc and write_scc_data */
info = kzalloc(sizeof(struct scc_info), GFP_KERNEL | GFP_DMA);
- if (!info) {
- printk(KERN_ERR "dmascc: "
- "could not allocate memory for %s at %#3x\n",
- hw[type].name, card_base);
+ if (!info)
goto out;
- }
-
info->dev[0] = alloc_netdev(0, "", dev_setup);
if (!info->dev[0]) {
diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c
index 41eb8ff..5c87eef 100644
--- a/drivers/net/phy/spi_ks8995.c
+++ b/drivers/net/phy/spi_ks8995.c
@@ -275,10 +275,8 @@ static int ks8995_probe(struct spi_device *spi)
pdata = spi->dev.platform_data;
ks = kzalloc(sizeof(*ks), GFP_KERNEL);
- if (!ks) {
- dev_err(&spi->dev, "no memory for private data\n");
+ if (!ks)
return -ENOMEM;
- }
mutex_init(&ks->lock);
ks->pdata = pdata;
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index eda2042..381a2d8 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -976,10 +976,8 @@ static void virtnet_set_rx_mode(struct net_device *dev)
buf = kzalloc(((uc_count + mc_count) * ETH_ALEN) +
(2 * sizeof(mac_data->entries)), GFP_ATOMIC);
mac_data = buf;
- if (!buf) {
- dev_warn(&dev->dev, "No memory for MAC address buffer\n");
+ if (!buf)
return;
- }
sg_init_table(sg, 2);
--
1.8.0.dirty
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[PATCH 0/8] drivers/net: Remove unnecessary alloc/OOM messages
Remove all the OOM messages that follow kernel alloc failures as there is already a generic equivalent to these messages in the mm subsystem. Joe Perches (8): caif: Remove unnecessary alloc/OOM messages can: Remove unnecessary alloc/OOM messages ethernet: Remove unnecessary alloc/OOM messages, alloc cleanups drivers: net: usb: Remove unnecessary alloc/OOM messages wan: Remove unnecessary alloc/OOM messages wimax: Remove unnecessary alloc/OOM messages, alloc cleanups wireless: Remove unnecessary alloc/OOM messages, alloc cleanups drivers:net:misc: Remove unnecessary alloc/OOM messages drivers/net/caif/caif_shmcore.c| 6 - drivers/net/can/sja1000/ems_pci.c | 1 - drivers/net/can/sja1000/peak_pci.c | 5 +--- drivers/net/can/sja1000/peak_pcmcia.c | 1 - drivers/net/can/sja1000/plx_pci.c | 1 - drivers/net/can/usb/ems_usb.c | 4 +--- drivers/net/can/usb/kvaser_usb.c | 2 -- drivers/net/can/usb/peak_usb/pcan_usb_core.c | 5 drivers/net/can/usb/usb_8dev.c | 4 +--- drivers/net/ethernet/atheros/atl1c/atl1c_main.c| 6 ++--- drivers/net/ethernet/atheros/atl1e/atl1e_main.c| 2 -- drivers/net/ethernet/broadcom/b44.c| 4 +--- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 6 ++--- drivers/net/ethernet/broadcom/cnic.c | 6 ++--- drivers/net/ethernet/broadcom/tg3.c| 4 +--- drivers/net/ethernet/freescale/gianfar_ethtool.c | 9 drivers/net/ethernet/ibm/ehea/ehea_main.c | 4 +--- drivers/net/ethernet/ibm/ehea/ehea_qmr.c | 19 +-- drivers/net/ethernet/ibm/emac/mal.c| 7 ++ drivers/net/ethernet/ibm/ibmveth.c | 1 - drivers/net/ethernet/intel/igb/igb_main.c | 5 ++-- drivers/net/ethernet/intel/igbvf/netdev.c | 8 +++ drivers/net/ethernet/marvell/mv643xx_eth.c | 8 +++ drivers/net/ethernet/marvell/mvmdio.c | 1 - drivers/net/ethernet/marvell/skge.c| 5 ++-- drivers/net/ethernet/marvell/sky2.c| 4 +--- drivers/net/ethernet/mellanox/mlx4/en_main.c | 4 +--- drivers/net/ethernet/mellanox/mlx4/main.c | 4 +--- drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 5 ++-- .../net/ethernet/qlogic/netxen/netxen_nic_ctx.c| 5 +--- drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c | 18 --- .../net/ethernet/qlogic/netxen/netxen_nic_init.c | 27 -- .../net/ethernet/qlogic/netxen/netxen_nic_main.c | 5 +--- drivers/net/ethernet/qlogic/qla3xxx.c | 10 .../net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c | 14 --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c | 6 ++--- drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c | 26 +++-- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 19 +-- .../net/ethernet/qlogic/qlcnic/qlcnic_minidump.c | 7 ++ drivers/net/ethernet/qlogic/qlge/qlge_main.c | 1 - drivers/net/ethernet/rdc/r6040.c | 3 +-- drivers/net/ethernet/renesas/sh_eth.c | 10 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 11 + drivers/net/ethernet/sun/niu.c | 2 +- drivers/net/ethernet/ti/cpsw.c | 8 +++ drivers/net/ethernet/ti/davinci_mdio.c | 4 +--- drivers/net/ethernet/xilinx/ll_temac_main.c| 6 ++--- drivers/net/hamradio/dmascc.c | 7 +- drivers/net/phy/spi_ks8995.c | 4 +--- drivers/net/usb/ax88172a.c | 6 ++--- drivers/net/usb/hso.c | 25 ++-- drivers/net/usb/sierra_net.c | 10 +++- drivers/net/usb/smsc75xx.c | 6 ++--- drivers/net/usb/smsc95xx.c | 6 ++--- drivers/net/usb/usbnet.c | 5 +--- drivers/net/virtio_net.c | 4 +--- drivers/net/wan/cosa.c | 9 drivers/net/wan/farsync.c | 6 ++--- drivers/net/wan/hdlc.c | 9 drivers/net/wan/x25_asy.c | 1 - drivers/net/wimax/i2400m/rx.c | 16 - drivers/net/wimax/i2400m/usb-notif.c | 1 - drivers/net/wireless/airo_cs.c | 5 ++-- drivers/net/wireless/at76c50x-usb.c| 4 +--- .../net/wireless/ath/ath9k/dfs_pattern_detector.c | 6 ++--- drivers/net/wireless/atmel_cs.c| 5 ++-- drivers/net/wireless/ipw2x00/ipw2100.c | 9 +++- drivers/net/wireless/libertas/cfg.c| 4 +--- drivers/net/wireless/mwifiex/11n.c
Re: [PATCH] virtio_console: Don't access uninitialized data.
Amit Shah writes: > On (Thu) 17 Jan 2013 [13:21:32], sjur.brandel...@stericsson.com wrote: >> From: Sjur Brændeland >> >> Don't access uninitialized work-queue when removing device. >> The work queue is initialized only if the device multi-queue. >> So don't call cancel_work unless this is a multi-queue device. >> >> This fixes the following panic: > > [snip] > >> Signed-off-by: Sjur Brændeland > > Acked-by: Amit Shah > >> This fix is intended of v3.8. > > Should also be CC'ed to stable@ Sorry, I was at linux.conf.au all last week. I've already sent it to Linus. Sjur said: "This fix is intended of v3.8.". If it needs to be in -stable, please tell me and I'll fwd it manually. Thanks, Rusty. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH][trivial] virtio-mmio: fix wrong comment about register offset
Pawel Moll writes: > On Sat, 2013-01-26 at 08:54 +, Ryota Ozaki wrote: >> The register offset of InterruptACK is 0x064, not 0x060. >> Fix it. >> >> Signed-off-by: Ryota Ozaki >> CC: Pawel Moll >> CC: Rusty Russell >> CC: Jiri Kosina >> --- >> drivers/virtio/virtio_mmio.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c >> index 31f966f..833e6db 100644 >> --- a/drivers/virtio/virtio_mmio.c >> +++ b/drivers/virtio/virtio_mmio.c >> @@ -75,7 +75,7 @@ >> * >> * 0x050 W QueueNotify Queue notifier >> * 0x060 R InterruptStatus Interrupt status register >> - * 0x060 W InterruptACK Interrupt acknowledge register >> + * 0x064 W InterruptACK Interrupt acknowledge register >> * 0x070 RW Status Device status register >> * >> * 0x100+ RW Device-specific configuration space > > Acked-by: Pawel Moll > > Thanks! > > Pawel Applied. Thanks, Rusty. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
CISTI'2013 Doctoral Symposium - CFP, Lisbon; Deadline: February 15
*** CISTI'2013 DOCTORAL SYMPOSIUM 8th Iberian Conference on Information Systems and Technologies Lisbon, Portugal, June 19 - 23, 2013 http://www.aisti.eu/cisti2013/index.php?option=com_content&view=article&id=64&Itemid=68&lang=en *** INTRODUCTION The purpose of CISTI'2013s Doctoral Symposium (http://www.aisti.eu/cisti2013/index.php?option=com_content&view=article&id=64&Itemid=68&lang=en) is to provide graduate students a setting where they can, informally, expose and discuss their work, collecting valuable expert opinions and sharing new ideas, methods and applications. The Doctoral Symposium is an excellent opportunity for PhD students to present and discuss their work in a Workshop format. Each presentation will be evaluated by a panel composed by at least three Information Systems and Technologies experts. CONTRIBUTIONS SUBMISSION The Doctoral Symposium is opened to PhD students whose research area includes the themes proposed for this Conference. Submissions must include an extended abstract (maximum 4 pages), following the Conference style guide. All selected contributions will be handed out along with the Conference Proceedings, in CD with an ISBN. These contributions will be send for indexation by EBSCO, and EI-Compendex. Submissions must include the field, the PhD institution and the number of months devoted to the development of the work. Additionally, they should include in a clear and succinct manner: The problem approached and its significance or relevance The research objectives and related investigation topics A brief display of what is already known A proposed solution methodology for the problem Expected results IMPORTANT DATES Proposal submission deadline: 15th of February 2013 Acceptance notification: 29th of March 2013 Final submission deadline: 12th of April 2013 Registration payment, to ensure the inclusion of the accepted contribution in the Conference Proceedings: 12th of April 2013 SCIENTIFIC AND ORGANIZING COMMITTEE Manuel Pérez Cota, Universidad de Vigo (Chair) Adolfo Lozano Tello, Universidad de Extremadura Alberto J. Bugarín Diz, Universidad de Santiago de Compostela Álvaro Rocha, Universidade do Porto, LIACC Ana Maria Ramalho Correia, Universidade Nova de Lisboa, ISEGI António Palma dos Reis, Universidade Técnica de Lisboa, ISEG António Pereira, Instituto Politécnico de Leiria Arturo Mendez Penín, Universidade de Vigo Carlos Ferrás Sexto, Universidad de Santiago de Compostela David Fonseca, Universidad Ramón Llul Ernesto Redondo, Universidad Politécnica de Cataluña Feliz Gouveia, Universidade Fernando Pessoa Francisco Restivo, Universidade Católica Portuguesa - Braga Guilhermina Miranda, Universidade de Lisboa Gonzalo Cuevas Agustín, Universidad Politécnica de Madrid Héctor Jorge García Neder, Universidad Tecnológica NacioNal João Álvaro Carvalho, Universidade do Minho João Barroso, Universidade de Trás-os-Montes e Alto Douro Jörg Thomaschewski, University of Applied Sciences of Emden-Leer José Antonio Calvo-Manzano Villalón, Universidad Politécnica de Madrid José Bulas Cruz, Universidade de Trás-os-Montes e Alto Douro José Tribolet, Universidade Técnica de Lisboa, IST Leandro Rodríguez Liñares, Universidade de Vigo Luís Paulo Reis, Universidade do Minho María José Lado Touriño, Universidade de Vigo Maria Manuela Cruz Cunha, Instituto Politécnico do Cávado e do Ave Marco Painho, Universidade Nova de Lisboa, ISEGI Mario Alberto Groppo, Universidad Tecnológica Nacional Nuno Ribeiro, Universidade Fernando Pessoa Pilar Mareca, Universidade Politécnica de Madrid Ramiro Gonçalves, Universidade de Trás-os-Montes e Alto Douro Tomas San Feliu Gilabert, Universidad Politécnica de Madrid Vicente Alcober, Universidad Politécnica de Madrid - CISTI'2013 Team http://www.aisti.eu/cisti2013 cistim...@gmail.com --- ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
