Re: [PATCH v3 01/16] mm: use put_page to free page instead of putback_lru_page

2016-04-05 Thread Naoya Horiguchi
On Tue, Apr 05, 2016 at 10:20:50AM +0200, Vlastimil Babka wrote: > On 04/05/2016 03:54 AM, Naoya Horiguchi wrote: > > On Mon, Apr 04, 2016 at 04:46:31PM +0200, Vlastimil Babka wrote: > >> On 04/04/2016 06:45 AM, Naoya Horiguchi wrote: > >>> On Mon, Apr 04, 2016 at 10:39:17AM +0900, Minchan Kim

Re: [PATCH v4 6/6] hwmon: use smp_call_on_cpu() for dell-smm i8k

2016-04-05 Thread Guenter Roeck
On Tue, Apr 05, 2016 at 07:10:07AM +0200, Juergen Gross wrote: > Use the smp_call_on_cpu() function to call system management > mode on cpu 0. > Make call secure by adding get_online_cpus() to avoid e.g. suspend > resume cycles in between. > > Signed-off-by: Juergen Gross > ---

Re: [PATCH v4 6/6] hwmon: use smp_call_on_cpu() for dell-smm i8k

2016-04-05 Thread Pali Rohár
On Tuesday 05 April 2016 16:54:14 Guenter Roeck wrote: > On Tue, Apr 05, 2016 at 07:10:07AM +0200, Juergen Gross wrote: > > Use the smp_call_on_cpu() function to call system management > > mode on cpu 0. > > Make call secure by adding get_online_cpus() to avoid e.g. suspend > > resume cycles in

Re: [PATCH v2] drm/virtio: send vblank event after crtc updates

2016-04-05 Thread Gustavo Padovan
Hi, Any comment on this? Gustavo 2016-03-22 Gustavo Padovan : > From: Gustavo Padovan > > virtio_gpu was failing to send vblank events when using the atomic IOCTL > with the DRM_MODE_PAGE_FLIP_EVENT flag set. This patch fixes each

Re: [PATCH] virtio: fix "warning: ‘queue’ may be used uninitialized"

2016-04-05 Thread Michael S. Tsirkin
On Tue, Apr 05, 2016 at 09:34:24AM -0400, Jeff Mahoney wrote: > On 4/5/16 4:04 AM, Michael S. Tsirkin wrote: > > On Mon, Apr 04, 2016 at 02:14:19PM -0400, Jeff Mahoney wrote: > >> This fixes the following warning: > >> drivers/virtio/virtio_ring.c:1032:5: warning: ‘queue’ may be used > >>

Re: [PATCH] virtio: fix "warning: ‘queue’ may be used uninitialized"

2016-04-05 Thread Jeff Mahoney
On 4/5/16 4:04 AM, Michael S. Tsirkin wrote: > On Mon, Apr 04, 2016 at 02:14:19PM -0400, Jeff Mahoney wrote: >> This fixes the following warning: >> drivers/virtio/virtio_ring.c:1032:5: warning: ‘queue’ may be used >> uninitialized in this function >> >> The conditions that govern when queue is

Re: [PATCH v3 04/16] mm/balloon: use general movable page feature into balloon

2016-04-05 Thread Vlastimil Babka
On 03/30/2016 09:12 AM, Minchan Kim wrote: Now, VM has a feature to migrate non-lru movable pages so balloon doesn't need custom migration hooks in migrate.c and compact.c. Instead, this patch implements page->mapping ->{isolate|migrate|putback} functions. With that, we could remove hooks for

Re: [PATCH v4 3/6] smp: add function to execute a function synchronously on a cpu

2016-04-05 Thread Juergen Gross
On 05/04/16 10:11, Peter Zijlstra wrote: > On Tue, Apr 05, 2016 at 07:10:04AM +0200, Juergen Gross wrote: >> +int smp_call_on_cpu(unsigned int cpu, bool pin, int (*func)(void *), void >> *par) > > Why .pin and not .phys? .pin does not (to me) reflect the > hypervisor/physical-cpu thing. I don't

Re: [Xen-devel] [PATCH v4 4/6] xen: add xen_pin_vcpu() to support calling functions on a dedicated pcpu

2016-04-05 Thread David Vrabel
On 05/04/16 11:01, Juergen Gross wrote: > > No, I don't think this is a good idea. In the EINVAL or EBUSY case a > simple Xen admin command might be enough to make the next call succeed. > I don't want to disable pinning in this case. Ok. Acked-by: David Vrabel David

Re: [Xen-devel] [PATCH v4 4/6] xen: add xen_pin_vcpu() to support calling functions on a dedicated pcpu

2016-04-05 Thread Juergen Gross
On 05/04/16 11:45, David Vrabel wrote: > On 05/04/16 06:10, Juergen Gross wrote: >> Some hardware models (e.g. Dell Studio 1555 laptops) require calls to >> the firmware to be issued on cpu 0 only. As Dom0 might have to use >> these calls, add xen_pin_vcpu() to achieve this functionality. >> >> In

Re: [Xen-devel] [PATCH v4 4/6] xen: add xen_pin_vcpu() to support calling functions on a dedicated pcpu

2016-04-05 Thread David Vrabel
On 05/04/16 06:10, Juergen Gross wrote: > Some hardware models (e.g. Dell Studio 1555 laptops) require calls to > the firmware to be issued on cpu 0 only. As Dom0 might have to use > these calls, add xen_pin_vcpu() to achieve this functionality. > > In case either the domain doesn't have the

Re: [Xen-devel] [PATCH v4 1/6] xen: sync xen header

2016-04-05 Thread David Vrabel
On 05/04/16 06:10, Juergen Gross wrote: > Import the actual version of include/xen/interface/sched.h from Xen. Acked-by: David Vrabel David ___ Virtualization mailing list Virtualization@lists.linux-foundation.org

[PATCH] VSOCK: Detach QP check should filter out non matching QPs.

2016-04-05 Thread Jorgen Hansen
The check in vmci_transport_peer_detach_cb should only allow a detach when the qp handle of the transport matches the one in the detach message. Testing: Before this change, a detach from a peer on a different socket would cause an active stream socket to register a detach. Reviewed-by: George

Re: [PATCH v3 01/16] mm: use put_page to free page instead of putback_lru_page

2016-04-05 Thread Vlastimil Babka
On 04/05/2016 03:54 AM, Naoya Horiguchi wrote: > On Mon, Apr 04, 2016 at 04:46:31PM +0200, Vlastimil Babka wrote: >> On 04/04/2016 06:45 AM, Naoya Horiguchi wrote: >>> On Mon, Apr 04, 2016 at 10:39:17AM +0900, Minchan Kim wrote: > ... > > Also (but not your fault) the put_page() preceding

Re: [PATCH v4 3/6] smp: add function to execute a function synchronously on a cpu

2016-04-05 Thread Peter Zijlstra
On Tue, Apr 05, 2016 at 07:10:04AM +0200, Juergen Gross wrote: > +int smp_call_on_cpu(unsigned int cpu, bool pin, int (*func)(void *), void > *par) Why .pin and not .phys? .pin does not (to me) reflect the hypervisor/physical-cpu thing. Also, as per smp_call_function_single() would it not be

Re: [PATCH] virtio: fix "warning: ‘queue’ may be used uninitialized"

2016-04-05 Thread Michael S. Tsirkin
On Mon, Apr 04, 2016 at 02:14:19PM -0400, Jeff Mahoney wrote: > This fixes the following warning: > drivers/virtio/virtio_ring.c:1032:5: warning: ‘queue’ may be used > uninitialized in this function > > The conditions that govern when queue is set aren't apparent to gcc. > > Setting queue = NULL