RE: [PATCH v8 1/1] crypto: add virtio-crypto driver

2017-01-12 Thread Gonglei (Arei)
> > On Thu, Jan 12, 2017 at 03:10:25PM +0100, Christian Borntraeger wrote: > > On 01/10/2017 01:56 PM, Christian Borntraeger wrote: > > > On 01/10/2017 01:36 PM, Gonglei (Arei) wrote: > > >> Hi, > > >> > > >>> > > >>> On 12/15/2016 03:03 AM, Gonglei wrote: > > >>> [...] > > + > >

Re: [patch] vhost/scsi: silence uninitialized variable warning

2017-01-12 Thread Jason Wang
On 2017年01月13日 02:45, Dan Carpenter wrote: This is to silence an uninitialized variable warning in debug output. The problem is this line: pr_debug("vhost_get_vq_desc: head: %d, out: %u in: %u\n", head, out, in); If "head == vq->num" is true on the first iteration

Re: [PATCH v2] x86, locking/spinlocks: Remove paravirt_ticketlocks_enabled

2017-01-12 Thread Boris Ostrovsky
> diff --git a/arch/x86/xen/spinlock.c b/arch/x86/xen/spinlock.c > index e8a9ea7..25a7c43 100644 > --- a/arch/x86/xen/spinlock.c > +++ b/arch/x86/xen/spinlock.c > @@ -141,25 +141,6 @@ void __init xen_init_spinlocks(void) > pv_lock_ops.vcpu_is_preempted = PV_CALLEE_SAVE(xen_vcpu_stolen); >

Re: [PATCH] virtio_mmio: expose header to userspace

2017-01-12 Thread Jason Wang
On 2017年01月13日 05:37, Michael S. Tsirkin wrote: It's handy for userspace emulators like QEMU. Signed-off-by: Michael S. Tsirkin --- drivers/virtio/virtio_mmio.c | 2 +- include/{ => uapi}/linux/virtio_mmio.h | 0 2 files changed, 1 insertion(+), 1 deletion(-)

[PATCH] virtio_mmio: expose header to userspace

2017-01-12 Thread Michael S. Tsirkin
It's handy for userspace emulators like QEMU. Signed-off-by: Michael S. Tsirkin --- drivers/virtio/virtio_mmio.c | 2 +- include/{ => uapi}/linux/virtio_mmio.h | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename include/{ => uapi}/linux/virtio_mmio.h (100%)

Re: [PATCH v2 2/2] vring: Force use of DMA API for ARM-based systems

2017-01-12 Thread Michael S. Tsirkin
On Wed, Jan 11, 2017 at 10:01:39AM +, Will Deacon wrote: > On Wed, Jan 11, 2017 at 01:33:31AM +0200, Michael S. Tsirkin wrote: > > On Tue, Jan 10, 2017 at 05:51:18PM +, Robin Murphy wrote: > > > From: Will Deacon > > > > > > Booting Linux on an ARM fastmodel

[PATCH 1/2] virtio_mmio: add standard header file

2017-01-12 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- include/standard-headers/linux/virtio_mmio.h | 141 +++ 1 file changed, 141 insertions(+) create mode 100644 include/standard-headers/linux/virtio_mmio.h diff --git a/include/standard-headers/linux/virtio_mmio.h

[PATCH 2/2] virtio-mmio: switch to linux headers

2017-01-12 Thread Michael S. Tsirkin
Switch to virtio_mmio.h from Linux - will make it easier to implement virtio 1. Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-mmio.c | 95 +++-- 1 file changed, 37 insertions(+), 58 deletions(-) diff --git

Re: [PATCH v8 1/1] crypto: add virtio-crypto driver

2017-01-12 Thread Michael S. Tsirkin
On Thu, Jan 12, 2017 at 03:10:25PM +0100, Christian Borntraeger wrote: > On 01/10/2017 01:56 PM, Christian Borntraeger wrote: > > On 01/10/2017 01:36 PM, Gonglei (Arei) wrote: > >> Hi, > >> > >>> > >>> On 12/15/2016 03:03 AM, Gonglei wrote: > >>> [...] > + > +static struct crypto_alg

Re: [PATCH v8 1/1] crypto: add virtio-crypto driver

2017-01-12 Thread Christian Borntraeger
On 01/10/2017 01:56 PM, Christian Borntraeger wrote: > On 01/10/2017 01:36 PM, Gonglei (Arei) wrote: >> Hi, >> >>> >>> On 12/15/2016 03:03 AM, Gonglei wrote: >>> [...] + +static struct crypto_alg virtio_crypto_algs[] = { { + .cra_name = "cbc(aes)", + .cra_driver_name =

Re: [PATCH] virtio_mmio: expose header to userspace

2017-01-12 Thread Christoph Hellwig
On Thu, Jan 12, 2017 at 11:37:22PM +0200, Michael S. Tsirkin wrote: > It's handy for userspace emulators like QEMU. But it's not actually a userspace API - it's an on the write protocol. so: NAK. ___ Virtualization mailing list

[PATCH] virtio-crypto: adjust priority of algorithm

2017-01-12 Thread Gonglei
Some hardware accelerators (like intel aseni or the s390 cpacf functions) have lower priorities than virtio crypto, and those drivers are faster than the same in the host via virtio. So let's lower the priority of virtio-crypto's algorithm, make it's higher than sofeware implimentations but lower

Re: [PATCH] x86, locking/spinlocks: Remove paravirt_ticketlocks_enabled

2017-01-12 Thread Boris Ostrovsky
> diff --git a/arch/x86/xen/spinlock.c b/arch/x86/xen/spinlock.c > index e8a9ea7..a822606 100644 > --- a/arch/x86/xen/spinlock.c > +++ b/arch/x86/xen/spinlock.c > @@ -155,7 +155,6 @@ static __init int xen_init_spinlocks_jump(void) > if (!xen_domain()) > return 0; > > -

[patch] vhost/scsi: silence uninitialized variable warning

2017-01-12 Thread Dan Carpenter
This is to silence an uninitialized variable warning in debug output. The problem is this line: pr_debug("vhost_get_vq_desc: head: %d, out: %u in: %u\n", head, out, in); If "head == vq->num" is true on the first iteration then "out" and "in" aren't initialized. We

Re: [PATCH v6 kernel 2/5] virtio-balloon: define new feature bit and head struct

2017-01-12 Thread Michael S. Tsirkin
On Wed, Dec 21, 2016 at 02:52:25PM +0800, Liang Li wrote: > Add a new feature which supports sending the page information > with range array. The current implementation uses PFNs array, > which is not very efficient. Using ranges can improve the > performance of inflating/deflating significantly.