RE: [PATCH v33 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-15 Thread Wang, Wei W
On Friday, June 15, 2018 10:29 PM, Michael S. Tsirkin wrote: > On Fri, Jun 15, 2018 at 02:11:23PM +, Wang, Wei W wrote: > > On Friday, June 15, 2018 7:42 PM, Michael S. Tsirkin wrote: > > > On Fri, Jun 15, 2018 at 12:43:11PM +0800, Wei Wang wrote: > > > > Negotiation of the

Re: [RFC V2] virtio: Add platform specific DMA API translation for virito devices

2018-06-15 Thread Benjamin Herrenschmidt
On Fri, 2018-06-15 at 02:16 -0700, Christoph Hellwig wrote: > On Wed, Jun 13, 2018 at 11:11:01PM +1000, Benjamin Herrenschmidt wrote: > > Actually ... the stuff in lib/dma-direct.c seems to be just it, no ? > > > > There's no cache flushing and there's no architecture hooks that I can > > see

Re: [PATCH v33 1/4] mm: add a function to get free page blocks

2018-06-15 Thread Matthew Wilcox
On Fri, Jun 15, 2018 at 12:43:10PM +0800, Wei Wang wrote: > +/** > + * get_from_free_page_list - get free page blocks from a free page list > + * @order: the order of the free page list to check > + * @buf: the array to store the physical addresses of the free page blocks > + * @size: the array

RE: [PATCH v33 1/4] mm: add a function to get free page blocks

2018-06-15 Thread Wang, Wei W
On Saturday, June 16, 2018 7:09 AM, Linus Torvalds wrote: > On Fri, Jun 15, 2018 at 2:08 PM Wei Wang wrote: > > > > This patch adds a function to get free pages blocks from a free page > > list. The obtained free page blocks are hints about free pages, > > because there is no guarantee that they

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-15 Thread Michael S. Tsirkin
On Fri, Jun 15, 2018 at 11:32:42AM +0200, Cornelia Huck wrote: > On Fri, 15 Jun 2018 05:34:24 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, Jun 14, 2018 at 12:02:31PM +0200, Cornelia Huck wrote: > > > > > > I am not all that familiar with how Qemu manages network devices. If > > > > > we

Re: [PATCH v33 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-15 Thread Michael S. Tsirkin
On Fri, Jun 15, 2018 at 12:43:11PM +0800, Wei Wang wrote: > Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_HINT feature indicates the > support of reporting hints of guest free pages to host via virtio-balloon. > > Host requests the guest to report free page hints by sending a command > to the

Re: [PATCH v33 0/4] Virtio-balloon: support free page reporting

2018-06-15 Thread Michael S. Tsirkin
On Fri, Jun 15, 2018 at 12:43:09PM +0800, Wei Wang wrote: > - remove the cmd id related interface. Now host can just send a free > page hint command to the guest (via the host_cmd config register) > to start the reporting. Here we go again. And what if reporting was already

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-15 Thread Cornelia Huck
On Thu, 14 Jun 2018 18:57:11 -0700 Siwei Liu wrote: > Thank you for sharing your thoughts, Cornelia. With questions below, I > think you raised really good points, some of which I don't have answer > yet and would also like to explore here. > > First off, I don't want to push the discussion to

RE: [PATCH v33 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-15 Thread Wang, Wei W
On Friday, June 15, 2018 7:42 PM, Michael S. Tsirkin wrote: > On Fri, Jun 15, 2018 at 12:43:11PM +0800, Wei Wang wrote: > > Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_HINT feature indicates > > the support of reporting hints of guest free pages to host via > > virtio-balloon. > > > > Host

Re: [PATCH v33 0/4] Virtio-balloon: support free page reporting

2018-06-15 Thread Michael S. Tsirkin
On Fri, Jun 15, 2018 at 02:28:49PM +, Wang, Wei W wrote: > On Friday, June 15, 2018 7:30 PM, Michael S. Tsirkin wrote: > > On Fri, Jun 15, 2018 at 12:43:09PM +0800, Wei Wang wrote: > > > - remove the cmd id related interface. Now host can just send a free > > > page hint command

Re: [PATCH v33 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-15 Thread Michael S. Tsirkin
On Fri, Jun 15, 2018 at 02:11:23PM +, Wang, Wei W wrote: > On Friday, June 15, 2018 7:42 PM, Michael S. Tsirkin wrote: > > On Fri, Jun 15, 2018 at 12:43:11PM +0800, Wei Wang wrote: > > > Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_HINT feature indicates > > > the support of reporting hints

Re: [PATCH v33 0/4] Virtio-balloon: support free page reporting

2018-06-15 Thread Luiz Capitulino
On Fri, 15 Jun 2018 12:43:09 +0800 Wei Wang wrote: > This patch series is separated from the previous "Virtio-balloon > Enhancement" series. The new feature, VIRTIO_BALLOON_F_FREE_PAGE_HINT, > implemented by this series enables the virtio-balloon driver to report > hints of guest free pages to

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-15 Thread Siwei Liu
On Fri, Jun 15, 2018 at 4:48 AM, Cornelia Huck wrote: > On Thu, 14 Jun 2018 18:57:11 -0700 > Siwei Liu wrote: > >> Thank you for sharing your thoughts, Cornelia. With questions below, I >> think you raised really good points, some of which I don't have answer >> yet and would also like to

Re: [PATCH v33 1/4] mm: add a function to get free page blocks

2018-06-15 Thread Linus Torvalds
On Fri, Jun 15, 2018 at 2:08 PM Wei Wang wrote: > > This patch adds a function to get free pages blocks from a free page > list. The obtained free page blocks are hints about free pages, because > there is no guarantee that they are still on the free page list after > the function returns. Ack.

Re: [PATCH 0/3] Use sbitmap instead of percpu_ida

2018-06-15 Thread Christoph Hellwig
Btw, if you are on a spree to remove almost unused data structures from target code, the lib/btree.c code is only used by the qla2xxx target code, and doesn't really look like the best fit for it either. ___ Virtualization mailing list

Re: [RFC V2] virtio: Add platform specific DMA API translation for virito devices

2018-06-15 Thread Christoph Hellwig
On Wed, Jun 13, 2018 at 11:11:01PM +1000, Benjamin Herrenschmidt wrote: > Actually ... the stuff in lib/dma-direct.c seems to be just it, no ? > > There's no cache flushing and there's no architecture hooks that I can > see other than the AMD security stuff which is probably fine. > > Or am I

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-15 Thread Cornelia Huck
On Fri, 15 Jun 2018 05:34:24 +0300 "Michael S. Tsirkin" wrote: > On Thu, Jun 14, 2018 at 12:02:31PM +0200, Cornelia Huck wrote: > > > > I am not all that familiar with how Qemu manages network devices. If we > > > > can > > > > do all the > > > > required management of the primary/standby