Re: [PATCH net-next 09/11] tuntap: accept an array of XDP buffs through sendmsg()

2018-09-07 Thread Jason Wang
On 2018年09月07日 01:51, Michael S. Tsirkin wrote: On Thu, Sep 06, 2018 at 12:05:24PM +0800, Jason Wang wrote: This patch implement TUN_MSG_PTR msg_control type. This type allows the caller to pass an array of XDP buffs to tuntap through ptr field of the tun_msg_control. If an XDP program is

Re: [PATCH -next] drm/virtio: Remove set but not used variable 'bo'

2018-09-07 Thread Gerd Hoffmann
On Fri, Sep 07, 2018 at 02:03:57AM +, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/virtio/virtgpu_display.c: In function > 'virtio_gpu_framebuffer_init': > drivers/gpu/drm/virtio/virtgpu_display.c:78:28: warning: > variable 'bo' set but not used

[PATCH] virtio: add unlikely() to WARN_ON_ONCE()

2018-09-07 Thread Igor Stoppa
The condition to test is unlikely() to be true. Add the hint. Signed-off-by: Igor Stoppa Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: Virtualization@lists.linux-foundation.org Cc: linux-ker...@vger.kernel.org --- tools/virtio/linux/kernel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH net-next 11/11] vhost_net: batch submitting XDP buffers to underlayer sockets

2018-09-07 Thread Michael S. Tsirkin
On Fri, Sep 07, 2018 at 03:41:52PM +0800, Jason Wang wrote: > > > @@ -556,10 +667,14 @@ static void handle_tx_copy(struct vhost_net *net, > > > struct socket *sock) > > > size_t len, total_len = 0; > > > int err; > > > int sent_pkts = 0; > > > + bool bulking =

Re: [PATCH v36 0/5] Virtio-balloon: support free page reporting

2018-09-07 Thread Dr. David Alan Gilbert
* Wei Wang (wei.w.w...@intel.com) wrote: > On 07/23/2018 10:36 PM, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Fri, Jul 20, 2018 at 04:33:00PM +0800, Wei Wang wrote: > > > > This patch series is separated from the previous "Virtio-balloon > > > >

Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring

2018-09-07 Thread Michael S. Tsirkin
On Fri, Sep 07, 2018 at 09:22:25AM +0800, Tiwei Bie wrote: > On Mon, Aug 27, 2018 at 05:00:40PM +0300, Michael S. Tsirkin wrote: > > Are there still plans to test the performance with vost pmd? > > vhost doesn't seem to show a performance gain ... > > > > I tried some performance tests with

Re: [PATCH net-next 06/11] tuntap: split out XDP logic

2018-09-07 Thread Michael S. Tsirkin
On Fri, Sep 07, 2018 at 11:29:34AM +0800, Jason Wang wrote: > > > + if (act != XDP_PASS) > > > + goto out; > > likely? > > It depends on the XDP program, so I tend not to use it. Point is XDP_PASS is already slow. -- MST ___

Re: [PATCH net-next v2 3/5] virtio_ring: add packed ring support

2018-09-07 Thread Michael S. Tsirkin
On Wed, Jul 11, 2018 at 10:27:09AM +0800, Tiwei Bie wrote: > This commit introduces the support (without EVENT_IDX) for > packed ring. > > Signed-off-by: Tiwei Bie > --- > drivers/virtio/virtio_ring.c | 495 ++- > 1 file changed, 487 insertions(+), 8 deletions(-)

Re: [PATCH net-next v2 2/5] virtio_ring: support creating packed ring

2018-09-07 Thread Michael S. Tsirkin
On Wed, Jul 11, 2018 at 10:27:08AM +0800, Tiwei Bie wrote: > This commit introduces the support for creating packed ring. > All split ring specific functions are added _split suffix. > Some necessary stubs for packed ring are also added. > > Signed-off-by: Tiwei Bie I'd rather have a patch just

Re: [PATCH net-next v2 4/5] virtio_ring: add event idx support in packed ring

2018-09-07 Thread Michael S. Tsirkin
On Wed, Jul 11, 2018 at 10:27:10AM +0800, Tiwei Bie wrote: > This commit introduces the EVENT_IDX support in packed ring. > > Signed-off-by: Tiwei Bie Besides the usual comment about hard-coded constants like <<15: does this actually do any good for performance? We don't have to if we do not

Re: [PATCH net-next v2 1/5] virtio: add packed ring definitions

2018-09-07 Thread Michael S. Tsirkin
On Wed, Jul 11, 2018 at 10:27:07AM +0800, Tiwei Bie wrote: > Signed-off-by: Tiwei Bie > --- > include/uapi/linux/virtio_config.h | 3 +++ > include/uapi/linux/virtio_ring.h | 43 ++ > 2 files changed, 46 insertions(+) > > diff --git

Re: [PATCH net-next 04/11] tuntap: simplify error handling in tun_build_skb()

2018-09-07 Thread Michael S. Tsirkin
On Fri, Sep 07, 2018 at 11:22:00AM +0800, Jason Wang wrote: > > > @@ -1668,6 +1668,9 @@ static struct sk_buff *tun_build_skb(struct > > > tun_struct *tun, > > > if (copied != len) > > > return ERR_PTR(-EFAULT); > > > + get_page(alloc_frag->page); > > > +

Re: [PATCH] bochs: convert to drm_fb_helper_fbdev_setup/teardown

2018-09-07 Thread kbuild test robot
/linux/commits/Peter-Wu/bochs-convert-to-drm_fb_helper_fbdev_setup-teardown/20180907-154819 config: i386-randconfig-x006-201835 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new

Re: [PATCH net-next 11/11] vhost_net: batch submitting XDP buffers to underlayer sockets

2018-09-07 Thread Jason Wang
On 2018年09月07日 00:46, Michael S. Tsirkin wrote: On Thu, Sep 06, 2018 at 12:05:26PM +0800, Jason Wang wrote: This patch implements XDP batching for vhost_net. The idea is first to try to do userspace copy and build XDP buff directly in vhost. Instead of submitting the packet immediately,

Re: [PATCH] x86/paravirt: Get rid of patch_site label

2018-09-07 Thread Borislav Petkov
On Fri, Sep 07, 2018 at 12:49:17PM +0200, Borislav Petkov wrote: > From: Borislav Petkov > > When CONFIG_PARAVIRT_SPINLOCKS=n, it fires > > arch/x86/kernel/paravirt_patch_64.c: In function ‘native_patch’: > arch/x86/kernel/paravirt_patch_64.c:89:1: warning: label ‘patch_site’ > defined but

[PATCH] x86/paravirt: Get rid of patch_site label

2018-09-07 Thread Borislav Petkov
From: Borislav Petkov When CONFIG_PARAVIRT_SPINLOCKS=n, it fires arch/x86/kernel/paravirt_patch_64.c: In function ‘native_patch’: arch/x86/kernel/paravirt_patch_64.c:89:1: warning: label ‘patch_site’ defined but not used [-Wunused-label] patch_site: but that label can simply be removed

[PATCH v2] x86/paravirt: Get rid of patch_site and patch_default labels

2018-09-07 Thread Borislav Petkov
On Fri, Sep 07, 2018 at 12:51:12PM +0200, Borislav Petkov wrote: > Whoops, no, it is still being used. Lemme see if I can remove all the > labels in that function. Ok, I think I've gotten rid of them all, in both 32- and 64-bit versions. It boots here and a bunch of all*config builds pass. ---

Re: [PATCH v2] x86/paravirt: Get rid of patch_site and patch_default labels

2018-09-07 Thread Juergen Gross
On 07/09/18 22:10, Borislav Petkov wrote: > On Fri, Sep 07, 2018 at 12:51:12PM +0200, Borislav Petkov wrote: >> Whoops, no, it is still being used. Lemme see if I can remove all the >> labels in that function. > > Ok, I think I've gotten rid of them all, in both 32- and 64-bit > versions. It

RE: [PATCH v36 0/5] Virtio-balloon: support free page reporting

2018-09-07 Thread Wang, Wei W
On Friday, September 7, 2018 8:30 PM, Dr. David Alan Gilbert wrote: > OK, that's much better. > The ~50% reducton with a 8G VM and a real workload is great, and it does > what you expect when you put a lot more RAM in and see the 84% reduction > on a guest with 128G RAM - 54s vs ~9s is a big win!