Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-10 Thread Anton Ivanov
On 11/02/2020 02:51, Jason Wang wrote: On 2020/2/11 上午12:55, Anton Ivanov wrote: On 09/12/2019 10:48, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov Some of the frames marked as GSO which arrive at virtio_net_hdr_from_skb() have no GSO_TYPE, no fragments (data_len = 0) and

Re: [PATCH v2] tools/virtio: option to build an out of tree module

2020-02-10 Thread Jason Wang
On 2020/2/7 下午3:35, Michael S. Tsirkin wrote: Handy for testing with distro kernels. Warn that the resulting module is completely unsupported, and isn't intended for production use. Usage: make oot # builds vhost_test.ko, vhost.ko make oot-clean # cleans out files created

Re: [PATCH V2 5/5] vdpasim: vDPA device simulator

2020-02-10 Thread Jason Wang
On 2020/2/10 下午7:23, Michael S. Tsirkin wrote: On Mon, Feb 10, 2020 at 11:56:08AM +0800, Jason Wang wrote: This patch implements a software vDPA networking device. The datapath is implemented through vringh and workqueue. The device has an on-chip IOMMU which translates IOVA to PA. For kernel

Re: [PATCH V2 4/5] virtio: introduce a vDPA based transport

2020-02-10 Thread Jason Wang
On 2020/2/10 下午9:34, Jason Gunthorpe wrote: On Mon, Feb 10, 2020 at 11:56:07AM +0800, Jason Wang wrote: This patch introduces a vDPA transport for virtio. This is used to use kernel virtio driver to drive the mediated device that is capable of populating virtqueue directly. Is this comment

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-10 Thread Jason Wang
On 2020/2/11 上午12:55, Anton Ivanov wrote: On 09/12/2019 10:48, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov Some of the frames marked as GSO which arrive at virtio_net_hdr_from_skb() have no GSO_TYPE, no fragments (data_len = 0) and length significantly shorter than the MTU

Re: [PULL] vhost: cleanups and fixes

2020-02-10 Thread Linus Torvalds
On Sun, Feb 9, 2020 at 10:03 PM Michael S. Tsirkin wrote: > > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus Hmm? Pull request re-send? This already got merged on Friday as commit e0f121c5cc2c, as far as I can tell. It looks like the pr-tracker-bot didn't reply

Re: [PATCH v2 2/2] drm/qxl: add drm_driver.release callback.

2020-02-10 Thread Noralf Trønnes
(adding back Daniel) Den 10.02.2020 17.57, skrev Noralf Trønnes: > > > Den 10.02.2020 16.06, skrev Daniel Vetter: >> On Mon, Feb 10, 2020 at 12:37:52PM +0100, Gerd Hoffmann wrote: >>> Move final cleanups to qxl_drm_release() callback. >>> Add drm_atomic_helper_shutdown() call to

Re: [PATCH v2 2/2] drm/qxl: add drm_driver.release callback.

2020-02-10 Thread Noralf Trønnes
Den 10.02.2020 16.06, skrev Daniel Vetter: > On Mon, Feb 10, 2020 at 12:37:52PM +0100, Gerd Hoffmann wrote: >> Move final cleanups to qxl_drm_release() callback. >> Add drm_atomic_helper_shutdown() call to qxl_pci_remove(). >> >> Signed-off-by: Gerd Hoffmann >> --- >>

Re: [PATCH] virtio: Work around frames incorrectly marked as gso

2020-02-10 Thread Anton Ivanov
On 09/12/2019 10:48, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov Some of the frames marked as GSO which arrive at virtio_net_hdr_from_skb() have no GSO_TYPE, no fragments (data_len = 0) and length significantly shorter than the MTU (752 in my experiments). This is observed on

Re: [PATCH v2 2/2] drm/qxl: add drm_driver.release callback.

2020-02-10 Thread Daniel Vetter
On Mon, Feb 10, 2020 at 12:37:52PM +0100, Gerd Hoffmann wrote: > Move final cleanups to qxl_drm_release() callback. > Add drm_atomic_helper_shutdown() call to qxl_pci_remove(). > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/qxl/qxl_drv.c | 26 +++--- > 1 file

Re: [PATCH v2] drm/bochs: add drm_driver.release callback.

2020-02-10 Thread Daniel Vetter
On Mon, Feb 10, 2020 at 10:38:01AM +0100, Gerd Hoffmann wrote: > Call drm_dev_unregister() first in bochs_pci_remove(). Hook > bochs_unload() into the new .release callback, to make sure cleanup > is done when all users are gone. > > Add ready bool to state struct and move bochs_hw_fini() call

Re: [PATCH V2 4/5] virtio: introduce a vDPA based transport

2020-02-10 Thread Jason Gunthorpe
On Mon, Feb 10, 2020 at 11:56:07AM +0800, Jason Wang wrote: > This patch introduces a vDPA transport for virtio. This is used to > use kernel virtio driver to drive the mediated device that is capable > of populating virtqueue directly. Is this comment still right? Is there a mediated device

[PATCH v2 1/2] drm/qxl: reorder calls in qxl_device_fini().

2020-02-10 Thread Gerd Hoffmann
Reorder calls in qxl_device_fini(). Cleaning up gem & ttm might trigger qxl commands, so we should do that before releaseing command rings. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_kms.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v2 2/2] drm/qxl: add drm_driver.release callback.

2020-02-10 Thread Gerd Hoffmann
Move final cleanups to qxl_drm_release() callback. Add drm_atomic_helper_shutdown() call to qxl_pci_remove(). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_drv.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git

Re: [PATCH V2 5/5] vdpasim: vDPA device simulator

2020-02-10 Thread Michael S. Tsirkin
On Mon, Feb 10, 2020 at 11:56:08AM +0800, Jason Wang wrote: > This patch implements a software vDPA networking device. The datapath > is implemented through vringh and workqueue. The device has an on-chip > IOMMU which translates IOVA to PA. For kernel virtio drivers, vDPA > simulator driver

Re: vhost changes (batched) in linux-next after 12/13 trigger random crashes in KVM guests after reboot

2020-02-10 Thread Christian Borntraeger
On 10.02.20 10:47, Eugenio Perez Martin wrote: > Hi Christian. > > I'm not able to reproduce the failure with > eccb852f1fe6bede630e2e4f1a121a81e34354ab commit. Could you add more data? > Your configuration (libvirt or qemu line), and host's dmesg output if any? > > Thanks! If it was not

Re: [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}()

2020-02-10 Thread kbuild test robot
Hi Thomas, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.6-rc1 next-20200210] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base

Re: vhost changes (batched) in linux-next after 12/13 trigger random crashes in KVM guests after reboot

2020-02-10 Thread Christian Borntraeger
On 10.02.20 10:40, Eugenio Perez Martin wrote: > Hi Christian. > > I'm not able to reproduce the failure with > eccb852f1fe6bede630e2e4f1a121a81e34354ab commit. Could you add more data? > Your configuration (libvirt or qemu line), and host's dmesg output if any? I do the following in the

[PATCH v2] drm/virtio: add drm_driver.release callback.

2020-02-10 Thread Gerd Hoffmann
Split virtio_gpu_deinit(), move the drm shutdown and release to virtio_gpu_release(). Also free vbufs in case we can't queue them. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 1 + drivers/gpu/drm/virtio/virtgpu_display.c | 1 -

[PATCH v2] drm/cirrus: add drm_driver.release callback.

2020-02-10 Thread Gerd Hoffmann
Move final cleanups from cirrus_pci_remove() to the new callback. Add drm_atomic_helper_shutdown() call to cirrus_pci_remove(). Set pointers to NULL after iounmap() and check them before using them to make sure we don't touch released hardware. Signed-off-by: Gerd Hoffmann ---

[PATCH v2] drm/bochs: add drm_driver.release callback.

2020-02-10 Thread Gerd Hoffmann
Call drm_dev_unregister() first in bochs_pci_remove(). Hook bochs_unload() into the new .release callback, to make sure cleanup is done when all users are gone. Add ready bool to state struct and move bochs_hw_fini() call from bochs_unload() to bochs_pci_remove() to make sure hardware is not

Re: [PATCH] virtio_balloon: Fix unused label warning

2020-02-10 Thread David Hildenbrand
On 10.02.20 10:33, Borislav Petkov wrote: > From: Borislav Petkov > > Fix > > drivers/virtio/virtio_balloon.c: In function ‘virtballoon_probe’: > drivers/virtio/virtio_balloon.c:963:1: warning: label ‘out_del_vqs’ defined > but not used [-Wunused-label] > 963 | out_del_vqs: > |

[PATCH] virtio_balloon: Fix unused label warning

2020-02-10 Thread Borislav Petkov
From: Borislav Petkov Fix drivers/virtio/virtio_balloon.c: In function ‘virtballoon_probe’: drivers/virtio/virtio_balloon.c:963:1: warning: label ‘out_del_vqs’ defined but not used [-Wunused-label] 963 | out_del_vqs: | ^~ The CONFIG_BALLOON_COMPACTION ifdeffery should enclose

Re: [PATCH 5/6] drm/qxl: Use simple encoder

2020-02-10 Thread kbuild test robot
Hi Thomas, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.6-rc1 next-20200210] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option