On Sun, Aug 09, 2020 at 06:34:04AM +, Eli Cohen wrote:
> Acked-by: Eli Cohen
>
> BTW, vdpa_sim has the same bug.
>
I sent a patch for that on April 6.
[PATCH 2/2] vdpa: Fix pointer math bug in vdpasim_get_config()
Jason acked the patch but it wasn't applied.
regards,
dan carpenter
There is a pointer math bug here: the variable cast is a struct so the
offset is in units of struct size. If "offset" is non-zero this will
copy memory from beyond the end of the array.
fixes: 2c53d0f64c06 ("vdpasim: vDPA device simulator")
Reported-by: Dan Carpenter
Signed-off-by: Michael S.
The patch adding the iommu lock did not initialize it.
The struct is zero-initialized so this is mostly a problem
when using lockdep.
Reported-by: kernel test robot
Cc: Max Gurtovoy
Fixes: 0ea9ee430e74 ("vdpasim: protect concurrent access to iommu iotlb")
Signed-off-by: Michael S. Tsirkin
---
VDPA mlx5 accesses config space as native endian - this is
wrong since it's a modern device and actually uses LE.
It only supports modern guests so we could punt and
just force LE, but let's use the full virtio APIs since people
tend to copy/paste code, and this is not data path anyway.
On Mon, Aug 10, 2020 at 01:31:47PM +0300, Dan Carpenter wrote:
> On Sun, Aug 09, 2020 at 06:34:04AM +, Eli Cohen wrote:
> > Acked-by: Eli Cohen
> >
> > BTW, vdpa_sim has the same bug.
> >
>
> I sent a patch for that on April 6.
>
> [PATCH 2/2] vdpa: Fix pointer math bug in
On Tue, Aug 04, 2020 at 05:19:17PM +0200, Guennadi Liakhovetski wrote:
> On Tue, Aug 04, 2020 at 10:27:08AM -0400, Michael S. Tsirkin wrote:
> > On Wed, Jul 22, 2020 at 05:09:27PM +0200, Guennadi Liakhovetski wrote:
> > > Linux supports running the RPMsg protocol over the VirtIO transport
> > >
On Thu, Aug 06, 2020 at 03:43:54PM +0300, Eli Cohen wrote:
> On Thu, Aug 06, 2020 at 08:29:22AM -0400, Michael S. Tsirkin wrote:
> > On Thu, Aug 06, 2020 at 03:03:55PM +0300, Eli Cohen wrote:
> > > On Wed, Aug 05, 2020 at 08:51:56AM -0400, Michael S. Tsirkin wrote:
> > > > On Wed, Jun 17, 2020 at
On Mon, Aug 10, 2020 at 09:29:47AM +0200, Miklos Szeredi wrote:
> On Fri, Aug 7, 2020 at 9:55 PM Vivek Goyal wrote:
> >
>
> > Most of the changes are limited to fuse/virtiofs. There are couple
> > of changes needed in generic dax infrastructure and couple of changes
> > in virtio to be able to
On Sun, Aug 09, 2020 at 09:03:47AM +0300, Eli Cohen wrote:
> On Thu, Aug 06, 2020 at 05:08:28PM +0100, Colin King wrote:
> Acked by: Eli Cohen
That should be Acked-by: (with a dash).
___
Virtualization mailing list
On Wed, Aug 05, 2020 at 10:16:16AM +0800, Jason Wang wrote:
>
> On 2020/8/4 下午5:21, Michael S. Tsirkin wrote:
> > > > > > +struct vhost_vring_call {
> > > > > > + struct eventfd_ctx *ctx;
> > > > > > + struct irq_bypass_producer producer;
> > > > > > + spinlock_t ctx_lock;
> > > > >
On 8/10/20 12:39 AM, Jürgen Groß wrote:
> On 09.08.20 04:34, Boris Ostrovsky wrote:
>> On 8/7/20 4:38 AM, Juergen Gross wrote:
>>> @@ -377,10 +373,7 @@ static inline pte_t __pte(pteval_t val)
>>> {
>>> pteval_t ret;
>>> - if (sizeof(pteval_t) > sizeof(long))
>>> - ret =
On 10.08.20 18:53, Boris Ostrovsky wrote:
On 8/10/20 12:39 AM, Jürgen Groß wrote:
On 09.08.20 04:34, Boris Ostrovsky wrote:
On 8/7/20 4:38 AM, Juergen Gross wrote:
@@ -377,10 +373,7 @@ static inline pte_t __pte(pteval_t val)
{
pteval_t ret;
- if (sizeof(pteval_t) >
On 8/9/20 9:10 PM, Stephen Rothwell wrote:
> Hi all,
>
on i386:
Lots (63) of left shift warnings: {not all are shown here}
CC drivers/vdpa/mlx5/net/mlx5_vnet.o
In file included from ../include/linux/bits.h:6:0,
from ../include/linux/bitops.h:5,
from
On 2020/8/10 下午9:37, Michael S. Tsirkin wrote:
On Wed, Aug 05, 2020 at 10:16:16AM +0800, Jason Wang wrote:
On 2020/8/4 下午5:21, Michael S. Tsirkin wrote:
+struct vhost_vring_call {
+ struct eventfd_ctx *ctx;
+ struct irq_bypass_producer producer;
+ spinlock_t ctx_lock;
It's not
On 2020/8/10 下午8:05, Michael S. Tsirkin wrote:
On Thu, Aug 06, 2020 at 03:43:54PM +0300, Eli Cohen wrote:
On Thu, Aug 06, 2020 at 08:29:22AM -0400, Michael S. Tsirkin wrote:
On Thu, Aug 06, 2020 at 03:03:55PM +0300, Eli Cohen wrote:
On Wed, Aug 05, 2020 at 08:51:56AM -0400, Michael S.
On Mon, 10 Aug 2020 09:56:32 +0200 David Hildenbrand wrote:
> On 04.08.20 21:41, David Hildenbrand wrote:
> > @Andrew can we give this a churn and consider it for v5.9 in case there
> > are no more comments?
>
> @Andrew, Ping, so I assume we'll target v5.10?
Yep, sorry. Merging a significant
vDPA is an independent subsystem, so use a dedicated entry for that.
Signed-off-by: Jason Wang
---
MAINTAINERS | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4e2698cc7e23..314398f0e276 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@
Cc: Eli Cohen
Signed-off-by: Jason Wang
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 314398f0e276..ed1851413fcc 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18186,6 +18186,12 @@ S: Maintained
F: drivers/vdpa/
F:
On 2020/8/10 下午8:48, Michael S. Tsirkin wrote:
The patch adding the iommu lock did not initialize it.
The struct is zero-initialized so this is mostly a problem
when using lockdep.
Reported-by: kernel test robot
Cc: Max Gurtovoy
Fixes: 0ea9ee430e74 ("vdpasim: protect concurrent access to
On 04.08.20 21:41, David Hildenbrand wrote:
> @Andrew can we give this a churn and consider it for v5.9 in case there
> are no more comments?
@Andrew, Ping, so I assume we'll target v5.10?
>
> Patch #1-#4,#6 have RBss or ACKs, patch #5 is virtio-mem stuff maintained
> by me (and MST is aware).
On 05.08.20 15:44, Michael S. Tsirkin wrote:
> Virtio mem is modern-only. Use LE accessors for config space.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> drivers/virtio/virtio_mem.c | 30 +++---
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git
21 matches
Mail list logo
