Re: [PATCH linux-next v3 2/6] vdpa: Introduce query of device config layout

2021-06-24 Thread Jason Wang
在 2021/6/24 下午3:59, Parav Pandit 写道: From: Jason Wang Sent: Thursday, June 24, 2021 12:35 PM Consider we had a mature set of virtio specific uAPI for config space. It would be a burden if we need an unnecessary translation layer of netlink in the middle: [vDPA parent (virtio_net_config)]

Re: [PATCH v8 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-06-24 Thread Jason Wang
在 2021/6/24 下午5:16, Yongji Xie 写道: On Thu, Jun 24, 2021 at 4:14 PM Jason Wang wrote: 在 2021/6/24 下午12:46, Yongji Xie 写道: So we need to deal with both FEATURES_OK and reset, but probably not DRIVER_OK. OK, I see. Thanks for the explanation. One more question is how about clearing the

Re: [PATCH v4 13/16] dt-bindings: arm: Add virtio transport for SCMI

2021-06-24 Thread Rob Herring
On Fri, 11 Jun 2021 17:59:34 +0100, Cristian Marussi wrote: > From: Igor Skalkin > > Document the properties for arm,scmi-virtio compatible nodes. > The backing virtio SCMI device is described in patch [1]. > > While doing that, make shmem property required only for pre-existing > mailbox and

Re: [PATCH 1/3] kthread: allow caller to pass in user_struct

2021-06-24 Thread Mike Christie
On 6/23/21 11:34 PM, kernel test robot wrote: >>> kernel/kthread.c:466:6: warning: function 'kthread_create_for_user' might >>> be a candidate for 'gnu_printf' format attribute >>> [-Wsuggest-attribute=format] > 466 | namefmt, args); > | ^~~ > Will add a __printf(4,

Re: [PATCH 3/3] vhost: pass kthread user to check RLIMIT_NPROC

2021-06-24 Thread Mike Christie
On 6/24/21 3:26 AM, kernel test robot wrote: >>> drivers/vhost/vhost.c:599:57: sparse: sparse: dereference of noderef >>> expression > vim +599 drivers/vhost/vhost.c > >581 >582/* Caller should have device mutex */ >583long vhost_dev_set_owner(struct vhost_dev

Re: [PATCH] drm/qxl: Remove empty qxl_gem_prime_mmap()

2021-06-24 Thread Gerd Hoffmann
On Thu, Jun 24, 2021 at 11:05:00AM +0200, Thomas Zimmermann wrote: > The function qxl_gem_prime_mmap() returns an error. The two callers > of gem_prime_mmap are drm_fbdev_fb_mmap() and drm_gem_dmabuf_mmap(), > which both already handle NULL-callbacks with an error code. So clear > gem_prime_mmap

[PATCH] drm/qxl: Remove empty qxl_gem_prime_mmap()

2021-06-24 Thread Thomas Zimmermann
The function qxl_gem_prime_mmap() returns an error. The two callers of gem_prime_mmap are drm_fbdev_fb_mmap() and drm_gem_dmabuf_mmap(), which both already handle NULL-callbacks with an error code. So clear gem_prime_mmap in qxl and remove qxl_gem_prime_mmap(). Signed-off-by: Thomas Zimmermann

Re: [PATCH 3/3] vhost: pass kthread user to check RLIMIT_NPROC

2021-06-24 Thread kernel test robot
submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Mike-Christie/kthread-pass-in-user-and-check-RLIMIT_NPROC/20210624-110925 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux

Re: [PATCH v8 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-06-24 Thread Jason Wang
在 2021/6/24 下午12:46, Yongji Xie 写道: So we need to deal with both FEATURES_OK and reset, but probably not DRIVER_OK. OK, I see. Thanks for the explanation. One more question is how about clearing the corresponding status bit in get_status() rather than making set_status() fail. Since the spec

RE: [PATCH linux-next v3 2/6] vdpa: Introduce query of device config layout

2021-06-24 Thread Parav Pandit
> From: Jason Wang > Sent: Thursday, June 24, 2021 12:35 PM > > >> Consider we had a mature set of virtio specific uAPI for config space. > >> It would be a burden if we need an unnecessary translation layer of > >> netlink in the middle: > >> > >> [vDPA parent (virtio_net_config)] <->

Re: [PATCH 0/3] kthread: pass in user and check RLIMIT_NPROC

2021-06-24 Thread Michael S. Tsirkin
On Wed, Jun 23, 2021 at 10:08:01PM -0500, Mike Christie wrote: > The vhost driver will create a kthread when userspace does a > VHOST_SET_OWNER ioctl, but the thread is charged to the kthreadd thread. > We can then end up violating the userspace process's RLIMIT_NPROC. This > patchset allows

Re: [PATCH linux-next v3 2/6] vdpa: Introduce query of device config layout

2021-06-24 Thread Jason Wang
在 2021/6/24 下午2:29, Parav Pandit 写道: From: Jason Wang Sent: Thursday, June 24, 2021 11:13 AM 在 2021/6/23 下午12:22, Parav Pandit 写道: From: Jason Wang Sent: Wednesday, June 23, 2021 9:39 AM 在 2021/6/22 下午10:03, Parav Pandit 写道: Is it better to use a separate enum for net specific

RE: [PATCH linux-next v3 2/6] vdpa: Introduce query of device config layout

2021-06-24 Thread Parav Pandit
> From: Jason Wang > Sent: Thursday, June 24, 2021 11:13 AM > > 在 2021/6/23 下午12:22, Parav Pandit 写道: > > > >> From: Jason Wang > >> Sent: Wednesday, June 23, 2021 9:39 AM > >> > >> 在 2021/6/22 下午10:03, Parav Pandit 写道: > Is it better to use a separate enum for net specific attributes? >