Re: [PATCH v2 4/5] vdpa: add new vdpa attribute VDPA_ATTR_DEV_F_VERSION_1

2021-09-15 Thread Michael S. Tsirkin
On Wed, Sep 15, 2021 at 04:06:57PM +0800, Jason Wang wrote: > On Wed, Sep 15, 2021 at 3:38 PM Michael S. Tsirkin wrote: > > > > On Wed, Sep 15, 2021 at 11:18:06AM +0800, Jason Wang wrote: > > > On Tue, Sep 14, 2021 at 8:58 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Tue, Sep 14, 2021

Re: [PATCH v2 5/5] eni_vdpa: add vDPA driver for Alibaba ENI

2021-09-15 Thread kernel test robot
Hi Wu, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.15-rc1 next-20210915] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented

Re: [PATCH] vhost_vdpa: unset vq irq before freeing irq

2021-09-15 Thread Michael S. Tsirkin
On Wed, Sep 15, 2021 at 03:52:32PM +0800, Wu Zongyong wrote: > On Wed, Sep 15, 2021 at 03:26:41AM -0400, Michael S. Tsirkin wrote: > > On Wed, Sep 15, 2021 at 02:39:32PM +0800, Wu Zongyong wrote: > > > Currently we unset vq irq after freeing irq and that will result in > > > error messages: > > >

Re: [PATCH v2 4/5] vdpa: add new vdpa attribute VDPA_ATTR_DEV_F_VERSION_1

2021-09-15 Thread Michael S. Tsirkin
On Wed, Sep 15, 2021 at 04:05:49PM +0800, Jason Wang wrote: > On Wed, Sep 15, 2021 at 3:31 PM Michael S. Tsirkin wrote: > > > > On Wed, Sep 15, 2021 at 11:24:53AM +0800, Wu Zongyong wrote: > > > On Tue, Sep 14, 2021 at 08:58:28AM -0400, Michael S. Tsirkin wrote: > > > > On Tue, Sep 14, 2021 at

[PATCH 1/1] virtio/s390: fix vritio-ccw device teardown

2021-09-15 Thread Halil Pasic
Since commit 48720ba56891 ("virtio/s390: use DMA memory for ccw I/O and classic notifiers") we were supposed to make sure that virtio_ccw_release_dev() completes before the ccw device, and the attached dma pool are torn down, but unfortunately we did not. Before that commit it used to be OK to

Re: [PATCH 1/1] virtio/s390: fix vritio-ccw device teardown

2021-09-15 Thread Halil Pasic
s/vritio/virtio/ (subject) [..] On Wed, 15 Sep 2021 23:57:42 +0200 Halil Pasic wrote: > Since commit 48720ba56891 ("virtio/s390: use DMA memory for ccw I/O and > classic notifiers") we were supposed to make sure that > virtio_ccw_release_dev() completes before the ccw device, and the >

Re: [PATCH v2 4/5] vdpa: add new vdpa attribute VDPA_ATTR_DEV_F_VERSION_1

2021-09-15 Thread Jason Wang
On Wed, Sep 15, 2021 at 7:09 PM Michael S. Tsirkin wrote: > > On Wed, Sep 15, 2021 at 04:06:57PM +0800, Jason Wang wrote: > > On Wed, Sep 15, 2021 at 3:38 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Sep 15, 2021 at 11:18:06AM +0800, Jason Wang wrote: > > > > On Tue, Sep 14, 2021 at 8:58 PM

Re: [PATCH v2 4/5] vdpa: add new vdpa attribute VDPA_ATTR_DEV_F_VERSION_1

2021-09-15 Thread Jason Wang
On Wed, Sep 15, 2021 at 8:12 PM Wu Zongyong wrote: > > On Wed, Sep 15, 2021 at 07:08:51AM -0400, Michael S. Tsirkin wrote: > > On Wed, Sep 15, 2021 at 04:06:57PM +0800, Jason Wang wrote: > > > On Wed, Sep 15, 2021 at 3:38 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Wed, Sep 15, 2021

Re: [PATCH 1/2] drm/qxl: User page size macro for qxl release bo

2021-09-15 Thread Gerd Hoffmann
On Tue, Sep 14, 2021 at 02:23:51AM -0400, bibo mao wrote: > Some architectures have different default page size, this patch > replaces hardcoded 4096 with PAGE_SIZE macro, since cmd bo size > is page aligned. > > Signed-off-by: bibo mao Pushed to drm-misc-next. thanks, Gerd

Re: [PATCH] drm/bochs: add Bochs PCI ID for Simics model

2021-09-15 Thread Gerd Hoffmann
On Thu, Sep 09, 2021 at 06:06:55PM -0700, H. Peter Anvin (Intel) wrote: > Current (and older) Simics models for the Bochs VGA used the wrong PCI > vendor ID (0x4321 instead of 0x1234). Although this can hopefully be > fixed in the future, it is a problem for users of the current version, > not

Re: [PATCH 2/2] drm/qxl: Add qxl dma fence release function

2021-09-15 Thread Gerd Hoffmann
On Tue, Sep 14, 2021 at 02:23:52AM -0400, bibo mao wrote: > Add qxl dma fence release function, previously default dma fence > release function is used, and fence pointer is used to free > the memory. With this patch, actual qxl release pointer is used > to free memory, so that dma fence can put

Re: [PATCH] vhost_vdpa: unset vq irq before freeing irq

2021-09-15 Thread Michael S. Tsirkin
On Wed, Sep 15, 2021 at 02:39:32PM +0800, Wu Zongyong wrote: > Currently we unset vq irq after freeing irq and that will result in > error messages: > > pi_update_irte: failed to update PI IRTE > irq bypass consumer (token 5a07a12b) unregistration fails: -22 > > This patch solves

Re: [PATCH v2 4/5] vdpa: add new vdpa attribute VDPA_ATTR_DEV_F_VERSION_1

2021-09-15 Thread Michael S. Tsirkin
On Wed, Sep 15, 2021 at 11:24:53AM +0800, Wu Zongyong wrote: > On Tue, Sep 14, 2021 at 08:58:28AM -0400, Michael S. Tsirkin wrote: > > On Tue, Sep 14, 2021 at 08:24:51PM +0800, Wu Zongyong wrote: > > > This new attribute advertises whether the vdpa device is legacy or not. > > > Users can pick

Re: [PATCH v2 4/5] vdpa: add new vdpa attribute VDPA_ATTR_DEV_F_VERSION_1

2021-09-15 Thread Michael S. Tsirkin
On Wed, Sep 15, 2021 at 11:18:06AM +0800, Jason Wang wrote: > On Tue, Sep 14, 2021 at 8:58 PM Michael S. Tsirkin wrote: > > > > On Tue, Sep 14, 2021 at 08:24:51PM +0800, Wu Zongyong wrote: > > > This new attribute advertises whether the vdpa device is legacy or not. > > > Users can pick right

Re: [PATCH v2 4/5] vdpa: add new vdpa attribute VDPA_ATTR_DEV_F_VERSION_1

2021-09-15 Thread Jason Wang
On Wed, Sep 15, 2021 at 3:31 PM Michael S. Tsirkin wrote: > > On Wed, Sep 15, 2021 at 11:24:53AM +0800, Wu Zongyong wrote: > > On Tue, Sep 14, 2021 at 08:58:28AM -0400, Michael S. Tsirkin wrote: > > > On Tue, Sep 14, 2021 at 08:24:51PM +0800, Wu Zongyong wrote: > > > > This new attribute

Re: [PATCH] vhost_vdpa: unset vq irq before freeing irq

2021-09-15 Thread Jason Wang
On Wed, Sep 15, 2021 at 2:39 PM Wu Zongyong wrote: > > Currently we unset vq irq after freeing irq and that will result in > error messages: Nit: I think for 'we', it actually means the parent driver can free the irq during reset, set_status(0). vp_vdpa is one example for this. > >

Re: [PATCH v2 4/5] vdpa: add new vdpa attribute VDPA_ATTR_DEV_F_VERSION_1

2021-09-15 Thread Jason Wang
On Wed, Sep 15, 2021 at 3:38 PM Michael S. Tsirkin wrote: > > On Wed, Sep 15, 2021 at 11:18:06AM +0800, Jason Wang wrote: > > On Tue, Sep 14, 2021 at 8:58 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Sep 14, 2021 at 08:24:51PM +0800, Wu Zongyong wrote: > > > > This new attribute advertises