Re: [PATCH] virtio-blk: support polling I/O

On Tue, Mar 15, 2022 at 10:43 PM Suwan Kim wrote: > > On Tue, Mar 15, 2022 at 04:59:23PM +0800, Jason Wang wrote: > > On Mon, Mar 14, 2022 at 8:33 PM Suwan Kim wrote: > > > > > On Mon, Mar 14, 2022 at 02:14:53PM +0800, Jason Wang wrote: > > > > > > > > 在 2022/3/11 下午11:28, Suwan Kim 写道: > > > >

Re: [PATCH v4 05/11] PCI: Use driver_set_override() instead of open-coding

On Sat, Mar 12, 2022 at 4:09 PM Krzysztof Kozlowski wrote: > > Use a helper to set driver_override to reduce amount of duplicated code. the amount > Make the driver_override field const char, because it is not modified by > the core and it matches other subsystems. Seems like mine #4 here

Re: [PATCH v4 01/11] driver: platform: Add helper for safer setting of driver_override

On Sat, Mar 12, 2022 at 5:16 PM Krzysztof Kozlowski wrote: > > Several core drivers and buses expect that driver_override is a > dynamically allocated memory thus later they can kfree() it. > > However such assumption is not documented, there were in the past and > there are already users setting

Re: [GIT PULL] virtio: a last minute regression fix

The pull request you sent on Mon, 14 Mar 2022 07:59:51 -0400: > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6665ca15746dc34606b5d79fae278a101a368437 Thank you! -- Deet-doot-dot, I am a

Re: [PATCH] vDPA/ifcvf: match pointer check to use

On Tue, Mar 15, 2022 at 08:03:26AM -0700, Tom Rix wrote: > > On 3/15/22 6:28 AM, Michael S. Tsirkin wrote: > > On Tue, Mar 15, 2022 at 05:41:30AM -0700, t...@redhat.com wrote: > > > From: Tom Rix > > > > > > Clang static analysis reports this issue > > > ifcvf_main.c:49:4: warning: Called

Re: [PATCH] virtio-blk: support polling I/O

On Tue, Mar 15, 2022 at 11:43:18PM +0900, Suwan Kim wrote: > On Tue, Mar 15, 2022 at 04:59:23PM +0800, Jason Wang wrote: > > On Mon, Mar 14, 2022 at 8:33 PM Suwan Kim wrote: > > > > > On Mon, Mar 14, 2022 at 02:14:53PM +0800, Jason Wang wrote: > > > > > > > > 在 2022/3/11 下午11:28, Suwan Kim 写道: >

Re: [PATCH] vDPA/ifcvf: match pointer check to use

On Tue, Mar 15, 2022 at 05:41:30AM -0700, t...@redhat.com wrote: > From: Tom Rix > > Clang static analysis reports this issue > ifcvf_main.c:49:4: warning: Called function > pointer is null (null dereference) > vf->vring->cb.callback(vring->cb.private); >

Re: [PATCH] vDPA/ifcvf: match pointer check to use

On Tue, Mar 15, 2022 at 05:41:30AM -0700, t...@redhat.com wrote: > From: Tom Rix > > Clang static analysis reports this issue > ifcvf_main.c:49:4: warning: Called function > pointer is null (null dereference) > vf->vring->cb.callback(vring->cb.private); >

Re: [RFC PATCH v1 3/3] af_vsock: SOCK_SEQPACKET broken buffer test

On Tue, Mar 15, 2022 at 12:43:13PM +, Krasnov Arseniy Vladimirovich wrote: On 15.03.2022 12:35, Arseniy Krasnov wrote: On 15.03.2022 11:36, Stefano Garzarella wrote: On Fri, Mar 11, 2022 at 10:58:32AM +, Krasnov Arseniy Vladimirovich wrote: Add test where sender sends two message,

Re: [PATCH v2 0/8] Add memory shrinker to VirtIO-GPU DRM driver

On Mon, 14 Mar 2022 at 22:44, Dmitry Osipenko wrote: > Dmitry Osipenko (8): > drm/virtio: Correct drm_gem_shmem_get_sg_table() error handling > drm/virtio: Check whether transferred 2D BO is shmem > drm/virtio: Unlock GEM reservations in error code path These three are legitimate fixes

Re: [PATCH v2 7/8] drm/virtio: Support memory shrinking

Greetings everyone, Food for thought: Would it make sense to have the madvise ioctl as generic DRM one? Looking around - i915, msm & panfrost already have one and the virtio implementation [below] seems as generic as it gets. On Mon, 14 Mar 2022 at 22:44, Dmitry Osipenko wrote: > +#define

Re: [RFC PATCH v1 3/3] af_vsock: SOCK_SEQPACKET broken buffer test

On Tue, Mar 15, 2022 at 09:34:35AM +, Krasnov Arseniy Vladimirovich wrote: On 15.03.2022 11:36, Stefano Garzarella wrote: Is this the right behavior? If read() fails because the buffer is invalid, do we throw out the whole packet? I was expecting the packet not to be consumed, have you

Re: [PATCH v2 3/3] vdpa: support exposing the count of vqs to userspace

On Tue, Mar 15, 2022 at 11:25:53AM +0800, Longpeng(Mike) wrote: From: Longpeng - GET_VQS_COUNT: the count of virtqueues that exposed Signed-off-by: Longpeng --- drivers/vhost/vdpa.c | 13 + include/uapi/linux/vhost.h | 3 +++ 2 files changed, 16 insertions(+) diff --git

Re: [PATCH v2 2/3] vdpa: change the type of nvqs to u32

On Tue, Mar 15, 2022 at 11:25:52AM +0800, Longpeng(Mike) wrote: From: Longpeng Change vdpa_device.nvqs and vhost_vdpa.nvqs to use u32 Signed-off-by: Longpeng --- drivers/vdpa/vdpa.c | 6 +++--- drivers/vhost/vdpa.c | 10 ++ include/linux/vdpa.h | 6 +++--- 3 files changed, 12

Re: [PATCH v2 1/3] vdpa: support exposing the config size to userspace

On Tue, Mar 15, 2022 at 11:25:51AM +0800, Longpeng(Mike) wrote: From: Longpeng - GET_CONFIG_SIZE: return the size of the virtio config space. The size contains the fields which are conditional on feature bits. Acked-by: Jason Wang Signed-off-by: Longpeng --- drivers/vhost/vdpa.c | 17

Re: [bug report] vDPA/ifcvf: implement shared IRQ feature

What I really want is to re-enable GCC's uninitialized variable warning. $ rm drivers/vdpa/ifcvf/ifcvf_main.o $ make W=2 drivers/vdpa/ifcvf/ifcvf_main.o It prints a ton of output but this is the relevant bit. drivers/vdpa/ifcvf/ifcvf_main.c: In function ‘ifcvf_vdpa_set_status’:

Re: [PATCH] virtio-blk: support polling I/O

On Mon, Mar 14, 2022 at 8:33 PM Suwan Kim wrote: > On Mon, Mar 14, 2022 at 02:14:53PM +0800, Jason Wang wrote: > > > > 在 2022/3/11 下午11:28, Suwan Kim 写道: > > > diff --git a/include/uapi/linux/virtio_blk.h > b/include/uapi/linux/virtio_blk.h > > > index d888f013d9ff..3fcaf937afe1 100644 > > > ---

Re: [bug report] vDPA/ifcvf: implement shared IRQ feature

On Tue, Mar 15, 2022 at 10:27:35AM +0800, Zhu, Lingshan wrote: > > > On 3/14/2022 6:37 PM, Dan Carpenter wrote: > > On Mon, Mar 14, 2022 at 10:22:03AM +0800, Zhu, Lingshan wrote: > > > Hello Dan, > > > > > > Thanks for your suggestions and this auto-testing efforts! > > > On handling the vector

Re: [RFC PATCH v1 1/3] af_vsock: add two new tests for SOCK_SEQPACKET

Hi Arseniy, On Fri, Mar 11, 2022 at 10:52:36AM +, Krasnov Arseniy Vladimirovich wrote: This adds two tests: for receive timeout and reading to invalid buffer provided by user. I forgot to put both patches to main patchset. Arseniy Krasnov(2): af_vsock: SOCK_SEQPACKET receive timeout test

Re: [RFC PATCH v1 3/3] af_vsock: SOCK_SEQPACKET broken buffer test

On Fri, Mar 11, 2022 at 10:58:32AM +, Krasnov Arseniy Vladimirovich wrote: Add test where sender sends two message, each with own data pattern. Reader tries to read first to broken buffer: it has three pages size, but middle page is unmapped. Then, reader tries to read second message to

Re: [RFC PATCH v1 2/3] af_vsock: SOCK_SEQPACKET receive timeout test

On Fri, Mar 11, 2022 at 10:55:42AM +, Krasnov Arseniy Vladimirovich wrote: Test for receive timeout check: connection is established, receiver sets timeout, but sender does nothing. Receiver's 'read()' call must return EAGAIN. Signed-off-by: Arseniy Krasnov ---

Re: [PATCH v1 1/2] vdpa: Add support for querying vendor statistics

On 3/13/2022 11:25 PM, Jason Wang wrote: On Sun, Mar 13, 2022 at 11:26 PM Eli Cohen wrote: > On 3/8/2022 9:07 PM, Eli Cohen wrote: > > > >> -Original Message- > >> From: Si-Wei Liu > >> Sent: Wednesday, March 9, 2022 5:33 AM > >> To: Eli Cohen > >> Cc:

Re: [PATCH v1 1/2] vdpa: Add support for querying vendor statistics

On 3/13/2022 8:26 AM, Eli Cohen wrote: On 3/8/2022 9:07 PM, Eli Cohen wrote: -Original Message- From: Si-Wei Liu Sent: Wednesday, March 9, 2022 5:33 AM To: Eli Cohen Cc: m...@redhat.com; jasow...@redhat.com; virtualization@lists.linux- foundation.org; epere...@redhat.com;