Re: [PATCH v4 1/1] Create debugfs file with virtio balloon usage information

2022-07-05 Thread Michael S. Tsirkin
On Tue, Jul 05, 2022 at 08:36:37AM +, Alexander Atanasov wrote: > Allow the guest to know how much it is ballooned by the host. > It is useful when debugging out of memory conditions. > > When host gets back memory from the guest it is accounted > as used memory in the guest but the guest

RE: [PATCH V3 3/6] vDPA: allow userspace to query features of a vDPA device

2022-07-05 Thread Parav Pandit via Virtualization
> From: Zhu, Lingshan > Sent: Tuesday, July 5, 2022 3:59 AM > > > On 7/4/2022 8:53 PM, Parav Pandit wrote: > >> From: Jason Wang > >> Sent: Monday, July 4, 2022 12:47 AM > >> > >> > >> 在 2022/7/2 06:02, Parav Pandit 写道: > From: Zhu Lingshan > Sent: Friday, July 1, 2022 9:28 AM >

Re: [PATCH v8 2/2] drm/gem: Don't map imported GEMs

2022-07-05 Thread Christian König via Virtualization
Am 01.07.22 um 11:02 schrieb Dmitry Osipenko: Drivers that use drm_gem_mmap() and drm_gem_mmap_obj() helpers don't handle imported dma-bufs properly, which results in mapping of something else than the imported dma-buf. On NVIDIA Tegra we get a hard lockup when userspace writes to the memory

Re: [PATCH v7 7/9] drm/virtio: Improve DMA API usage for shmem BOs

2022-07-05 Thread Gerd Hoffmann
Hi, > - * So for the moment keep things as-is, with a bulky comment > - * for the next person who feels like removing this > - * drm_dev_set_unique() quirk. Dragons lurking here. It's not the first attempt to ditch this, and so far all have been rolled back due to regressions.

Re: [PATCH v3 0/3] virtio: support requiring restricted access per device

2022-07-05 Thread Juergen Gross via Virtualization
On 22.06.22 08:38, Juergen Gross wrote: Instead of an all or nothing approach add support for requiring restricted memory access per device. Changes in V3: - new patches 1 + 2 - basically complete rework of patch 3 Juergen Gross (3): virtio: replace restricted mem access flag with callback

Re: [PATCH v8 1/2] drm/gem: Properly annotate WW context on drm_gem_lock_reservations() error

2022-07-05 Thread Christian König via Virtualization
Am 01.07.22 um 11:02 schrieb Dmitry Osipenko: Use ww_acquire_fini() in the error code paths. Otherwise lockdep thinks that lock is held when lock's memory is freed after the drm_gem_lock_reservations() error. The ww_acquire_context needs to be annotated as "released", which fixes the noisy

Re: [PATCH V6 8/9] virtio: harden vring IRQ

2022-07-05 Thread Jason Wang
On Tue, Jul 5, 2022 at 7:09 PM chenxiang (M) wrote: > > Hi, > > I encounter a issue when testing virtio-balloon on my platform (ARM64) > with kernel 5.19-rc4 to boot VM with "-device virtio-balloon ", and > > then change the size of balloon in qemu monitor, but it isn't valid, and > the log is as

[linux-next:master] BUILD REGRESSION 2a2aa3f05338270aecbe2492fda910d6c17e0102

2022-07-05 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 2a2aa3f05338270aecbe2492fda910d6c17e0102 Add linux-next specific files for 20220705 Error/Warning reports: https://lore.kernel.org/linux-doc/202207051821.3f0erisl-...@intel.com Error/Warning

RE: [PATCH V3 3/6] vDPA: allow userspace to query features of a vDPA device

2022-07-05 Thread Parav Pandit via Virtualization
> From: Zhu, Lingshan > Sent: Tuesday, July 5, 2022 10:25 PM > 1. When migrate the VM to a node which has a more resourceful device. If > the source side device does not have MQ, RSS or TSO feature, the vDPA > device assigned to the VM does not have MQ, RSS or TSO as well. When > migrating to a

Re: [PATCH v8 2/2] drm/gem: Don't map imported GEMs

2022-07-05 Thread Rob Clark
On Tue, Jul 5, 2022 at 4:51 AM Christian König wrote: > > Am 01.07.22 um 11:02 schrieb Dmitry Osipenko: > > Drivers that use drm_gem_mmap() and drm_gem_mmap_obj() helpers don't > > handle imported dma-bufs properly, which results in mapping of something > > else than the imported dma-buf. On

Re: [PATCH v7 7/9] drm/virtio: Improve DMA API usage for shmem BOs

2022-07-05 Thread Rob Clark
On Tue, Jul 5, 2022 at 10:02 AM Dmitry Osipenko wrote: > > On 7/5/22 18:45, Gerd Hoffmann wrote: > > Hi, > > > >>> Also note that pci is not the only virtio transport we have. > >> > >> The VirtIO indeed has other transports, but only PCI is really supported > >> in case of the VirtIO-GPU in

RE: [PATCH V3 3/6] vDPA: allow userspace to query features of a vDPA device

2022-07-05 Thread Parav Pandit via Virtualization
> From: Zhu, Lingshan > Sent: Tuesday, July 5, 2022 12:56 PM > > Both can be queried simultaneously. Each will return their own feature bits > using same attribute. > > It wont lead to the race. > How? It is just a piece of memory, [attr], do you see locks in > nla_put_u64_64bit()? It is a

Re: [PATCH v7 7/9] drm/virtio: Improve DMA API usage for shmem BOs

2022-07-05 Thread Gerd Hoffmann
Hi, > > Also note that pci is not the only virtio transport we have. > > The VirtIO indeed has other transports, but only PCI is really supported > in case of the VirtIO-GPU in kernel and in Qemu/crosvm, AFAICT. Hence > only the PCI transport was tested. qemu -M microvm \ -global

Re: [RFC PATCH 3/6] virtio_test: call __virtio_unbreak_device

2022-07-05 Thread Stefano Garzarella
On Mon, Jul 04, 2022 at 03:06:39PM -0400, Michael S. Tsirkin wrote: On Mon, Jul 04, 2022 at 07:16:58PM +0200, Stefano Garzarella wrote: Commit 8b4ec69d7e09 ("virtio: harden vring IRQ") initialize vq->broken to true, so we need to call __virtio_unbreak_device() before starting to use it.

Re: [RFC PATCH 1/6] tools/virtio: fix build

2022-07-05 Thread Stefano Garzarella
On Mon, Jul 04, 2022 at 03:07:15PM -0400, Michael S. Tsirkin wrote: On Mon, Jul 04, 2022 at 07:16:56PM +0200, Stefano Garzarella wrote: Fix the build caused by the following changes: - phys_addr_t is now defined in tools/include/linux/types.h - dev_warn_once() is used in

Re: [PATCH] rpmsg: virtio: Fix broken rpmsg_probe()

2022-07-05 Thread Jason Wang
On Mon, Jul 4, 2022 at 5:45 PM Arnaud POULIQUEN wrote: > > Hello Jason, > > On 7/4/22 06:35, Jason Wang wrote: > > On Fri, Jul 1, 2022 at 2:16 PM Michael S. Tsirkin wrote: > >> > >> On Fri, Jul 01, 2022 at 09:22:15AM +0800, Jason Wang wrote: > >>> On Fri, Jul 1, 2022 at 3:20 AM Michael S.

Re: [PATCH -next] vdpa/mlx5: Use eth_broadcast_addr() to assign broadcast address

2022-07-05 Thread Jason Wang
On Mon, Jul 4, 2022 at 10:16 AM Xu Qiang wrote: > > Using eth_broadcast_addr() to assign broadcast address instead > of memset(). > > Reported-by: Hulk Robot > Signed-off-by: Xu Qiang Acked-by: Jason Wang > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] vdpa: ifcvf: Fix spelling mistake in comments

2022-07-05 Thread Jason Wang
On Mon, Jul 4, 2022 at 10:41 AM Zhang Jiaming wrote: > > There is a typo(does't) in comments. > It maybe 'doesn't' instead of 'does't'. > > Signed-off-by: Zhang Jiaming Acked-by: Jason Wang > --- > drivers/vdpa/ifcvf/ifcvf_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[PATCH] tools/virtio: fix build

2022-07-05 Thread Stefano Garzarella
Fix the build caused by the following changes: - phys_addr_t is now defined in tools/include/linux/types.h - dev_warn_once() is used in drivers/virtio/virtio_ring.c - linux/uio.h included by vringh.h use INT_MAX defined in limits.h Signed-off-by: Stefano Garzarella ---