On Fri 2023-01-27 08:57:40, Seth Forshee wrote:
> On Fri, Jan 27, 2023 at 12:19:03PM +0100, Petr Mladek wrote:
> > Could you please provide some more details about the test system?
> > Is there anything important to make it reproducible?
> >
> > The following aspects come to my mind. It might
Use the bvec_set_page helper to initialize a bvec.
Signed-off-by: Christoph Hellwig
---
drivers/vhost/vringh.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c
index 33eb941fcf1546..a1e27da544814a 100644
---
Use the bvec_set_page helper to initialize bvecs.
Signed-off-by: Christoph Hellwig
---
net/ceph/messenger_v1.c | 7 ++-
net/ceph/messenger_v2.c | 28 +++-
2 files changed, 13 insertions(+), 22 deletions(-)
diff --git a/net/ceph/messenger_v1.c
Use the bvec_set_page helper to initialize a bvec.
Signed-off-by: Christoph Hellwig
---
fs/ceph/file.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/ceph/file.c b/fs/ceph/file.c
index 764598e1efd91f..6419dce7c57987 100644
--- a/fs/ceph/file.c
+++
Use the bvec_set_page helper to initialize bvecs.
Signed-off-by: Christoph Hellwig
---
net/sunrpc/svcsock.c | 7 ++-
net/sunrpc/xdr.c | 5 ++---
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
index
Use the bvec_set_page helper to initialize a bvec.
Signed-off-by: Christoph Hellwig
---
net/rxrpc/rxperf.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/net/rxrpc/rxperf.c b/net/rxrpc/rxperf.c
index 16dcabb71ebe16..4a2e90015ca72c 100644
--- a/net/rxrpc/rxperf.c
+++
Use the bvec_set_page helper to initialize bvecs.
Signed-off-by: Christoph Hellwig
---
drivers/block/zram/zram_drv.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index
Use the bvec_set_page helper to initialize bvecs.
Signed-off-by: Christoph Hellwig
---
fs/cifs/connect.c | 5 +++--
fs/cifs/fscache.c | 16 ++--
fs/cifs/misc.c| 5 ++---
fs/cifs/smb2ops.c | 6 +++---
4 files changed, 14 insertions(+), 18 deletions(-)
diff --git
Hi all,
this series adds the helpers to initalize a bvec. These remove open coding of
bvec internals and help with experimenting with other representations like
a phys_addr_t instead of page + offset.
Diffstat:
block/bio-integrity.c |7 --
block/bio.c
Add a helper to initialize a bvec based of a page pointer. This will help
removing various open code bvec initializations.
Signed-off-by: Christoph Hellwig
---
block/bio-integrity.c | 7 +--
block/bio.c | 12 ++--
include/linux/bvec.h | 15 +++
3 files
A smaller wrapper around bvec_set_page that takes a folio instead.
There are only two potential users for this in the tree, but the number
will grow in the future.
Signed-off-by: Christoph Hellwig
---
include/linux/bvec.h | 13 +
1 file changed, 13 insertions(+)
diff --git
A small wrapper around bvec_set_page for callers that have a virtual
address.
Signed-off-by: Christoph Hellwig
---
include/linux/bvec.h | 12
1 file changed, 12 insertions(+)
diff --git a/include/linux/bvec.h b/include/linux/bvec.h
index f094512ce3bda9..7031d83af02267 100644
---
Use the bvec_set_page and bvec_set_folio helpers to initialize bvecs.
Signed-off-by: Christoph Hellwig
---
fs/orangefs/inode.c | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/fs/orangefs/inode.c b/fs/orangefs/inode.c
index
Use the bvec_set_page helper to initialize bvecs.
Signed-off-by: Christoph Hellwig
---
fs/nfs/fscache.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/fs/nfs/fscache.c b/fs/nfs/fscache.c
index e731c00a9fcbc3..ea5f2976dfaba4 100644
--- a/fs/nfs/fscache.c
Use the bvec_set_page helper to initialize a bvec.
Signed-off-by: Christoph Hellwig
---
fs/coredump.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/fs/coredump.c b/fs/coredump.c
index de78bde2991beb..0a6873a9c4d0cd 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@
Use the bvec_set_page helper to initialize bvecs.
Signed-off-by: Christoph Hellwig
---
mm/page_io.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/mm/page_io.c b/mm/page_io.c
index 3a5f921b932e82..233f6e6eb1c508 100644
--- a/mm/page_io.c
+++ b/mm/page_io.c
@@ -318,9
Add a helper for setting up the special_bvec instead of open coding it
in three place, and use the new bvec_set_page helper to initialize
special_vec.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/sd.c | 36 +---
1 file changed, 17 insertions(+), 19
Use the bvec_set_virt helper to initialize the special_vec.
Signed-off-by: Christoph Hellwig
---
drivers/block/virtio_blk.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 6a77fa91742880..dc6e9b989910b0 100644
Use the bvec_set_page helper to initialize bvecs.
Signed-off-by: Christoph Hellwig
---
drivers/nvme/target/io-cmd-file.c | 10 ++
drivers/nvme/target/tcp.c | 5 ++---
2 files changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/nvme/target/io-cmd-file.c
Use the bvec_set_virt helper to initialize the special_vec.
Signed-off-by: Christoph Hellwig
---
drivers/nvme/host/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 505e16f20e57fa..7ba1accc3c22a4 100644
---
Use the bvec_set_page helper to initialize the copy up bvec.
Signed-off-by: Christoph Hellwig
---
drivers/block/rbd.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 04453f4a319cb4..1faca7e07a4d52 100644
---
Use the bvec_set_page helper to initialize a bvec.
Signed-off-by: Christoph Hellwig
---
io_uring/rsrc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c
index 18de10c68a151b..a59fc02de5983c 100644
--- a/io_uring/rsrc.c
+++
Use the bvec_set_page helper to initialize a bvec.
Signed-off-by: Christoph Hellwig
---
fs/splice.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/splice.c b/fs/splice.c
index 5969b7a1d353a8..87d9b19349de63 100644
--- a/fs/splice.c
+++ b/fs/splice.c
@@ -675,9 +675,8
Use the bvec_set_page helper to initialize bvecs.
Signed-off-by: Christoph Hellwig
---
drivers/target/target_core_file.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/target/target_core_file.c
b/drivers/target/target_core_file.c
index
Use the bvec_set_folio helper to initialize a bvec.
Signed-off-by: Christoph Hellwig
---
fs/afs/write.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/fs/afs/write.c b/fs/afs/write.c
index 19df10d63323d8..2d17891b618e6e 100644
--- a/fs/afs/write.c
+++
Hi Eli:
On Mon, Jan 23, 2023 at 1:59 PM Eli Cohen wrote:
>
> VDPA allows hardware drivers the propagate interrupts from the hardware
> directly to the vCPU used by the guest. In a typical implementation, the
> hardware driver will assign the interrupt vectors to the virtqueues and report
> this
Christoph Hellwig wrote:
> + bvec_set_page(, ZERO_PAGE(0), len, 0);
Maybe bvec_set_zero_page()?
David
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
On Mon, Jan 30, 2023 at 03:44:24PM +0800, Jason Wang wrote:
> On Mon, Jan 30, 2023 at 1:43 PM Michael S. Tsirkin wrote:
> >
> > On Mon, Jan 30, 2023 at 10:53:54AM +0800, Jason Wang wrote:
> > > On Sun, Jan 29, 2023 at 3:30 PM Michael S. Tsirkin
> > > wrote:
> > > >
> > > > On Sun, Jan 29, 2023
Christoph Hellwig wrote:
> On Mon, Jan 30, 2023 at 10:31:23AM +, David Howells wrote:
> > Christoph Hellwig wrote:
> >
> > > + bvec_set_page(, ZERO_PAGE(0), len, 0);
> >
> > Maybe bvec_set_zero_page()?
>
> Why?
Seems to be something people want to do quite a lot and don't know
On Mon, Jan 30, 2023 at 10:33:36AM +, David Howells wrote:
> Christoph Hellwig wrote:
>
> > +static inline void bvec_set_page(struct bio_vec *bv, struct page *page,
> > + unsigned int len, unsigned int offset)
>
> Could you swap len and offset around? It reads better offset
On Mon, Jan 30, 2023 at 11:24:15AM +, David Howells wrote:
> Seems to be something people want to do quite a lot and don't know about.
Hmm. Right now there is one case where it would be used, and there's
about three that are and should be using bio_add_page.
> I've seen places where someone
On Mon, Jan 30, 2023 at 03:39:06PM +0800, Xuan Zhuo wrote:
> On Mon, 5 Sep 2022 16:32:19 +0800, Jason Wang wrote:
> >
> > 在 2022/8/25 16:56, Kangjie Xu 写道:
> > > Add VIRTIO_F_RING_RESET, which indicates that the driver can reset a
> > > queue individually.
> > >
> > > VIRTIO_F_RING_RESET feature
On Mon, Jan 30, 2023 at 12:01:23PM +0200, Eli Cohen wrote:
> On 30/01/2023 10:19, Jason Wang wrote:
> > Hi Eli:
> >
> > On Mon, Jan 23, 2023 at 1:59 PM Eli Cohen wrote:
> > > VDPA allows hardware drivers the propagate interrupts from the hardware
> > > directly to the vCPU used by the guest. In
On Fri, Jan 27, 2023 at 02:11:31PM -0800, Josh Poimboeuf wrote:
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index 4df2b3e76b30..fbcd3acca25c 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -36,6 +36,7 @@
> #include
> #include
> #include
>
On Mon, Jan 30, 2023 at 10:31:23AM +, David Howells wrote:
> Christoph Hellwig wrote:
>
> > + bvec_set_page(, ZERO_PAGE(0), len, 0);
>
> Maybe bvec_set_zero_page()?
Why?
___
Virtualization mailing list
Christoph Hellwig wrote:
> +static inline void bvec_set_page(struct bio_vec *bv, struct page *page,
> + unsigned int len, unsigned int offset)
Could you swap len and offset around? It reads better offset first. You move
offset into the page and then do something with len bytes.
Christoph Hellwig wrote:
> Use the bvec_set_page helper to initialize a bvec.
>
> Signed-off-by: Christoph Hellwig
Acked-by: David Howells
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
On 1/30/23 01:21, Christoph Hellwig wrote:
Add a helper to initialize a bvec based of a page pointer. This will help
removing various open code bvec initializations.
Why do you want to remove the open-coded bvec initializations? What is
wrong with open-coding bvec initialization? This patch
On Mon, Jan 30, 2023 at 10:21:43AM +0100, Christoph Hellwig wrote:
> Use the bvec_set_virt helper to initialize the special_vec.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Michael S. Tsirkin
> ---
> drivers/block/virtio_blk.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Christoph Hellwig wrote:
> Use the bvec_set_folio helper to initialize a bvec.
>
> Signed-off-by: Christoph Hellwig
Acked-by: David Howells
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
On Mon, Jan 30, 2023 at 10:21:56AM +0100, Christoph Hellwig wrote:
> Use the bvec_set_page helper to initialize a bvec.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Michael S. Tsirkin
> ---
> drivers/vhost/vringh.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff
On Mon, Jan 30, 2023 at 01:40:18PM +0100, Peter Zijlstra wrote:
> On Fri, Jan 27, 2023 at 02:11:31PM -0800, Josh Poimboeuf wrote:
> > @@ -8500,8 +8502,10 @@ EXPORT_STATIC_CALL_TRAMP(might_resched);
> > static DEFINE_STATIC_KEY_FALSE(sk_dynamic_cond_resched);
> > int __sched
On 1/30/23 09:09, Bart Van Assche wrote:
On 1/30/23 01:21, Christoph Hellwig wrote:
Add a helper to initialize a bvec based of a page pointer. This will
help
removing various open code bvec initializations.
Why do you want to remove the open-coded bvec initializations? What is
wrong with
Apologies, I was over booked for multiple things in parallel, and there
had been urgent internal priorities popped up at times for the past few
weeks. On the other hand, there were brokenness or incompleteness
identified around features provisioning while this series was being
developed, which
This patch implements features provisioning for mlx5_vdpa.
1) Validate the provisioned features are a subset of the parent
features.
2) Clearing features that are not wanted by userspace.
3) Set config space field only when the corresponding feature is
provisioned.
For example:
# vdpa
The spec says:
status only exists if VIRTIO_NET_F_STATUS is set
Similar to MAC and MTU, vdpa_dev_net_config_fill() should read
STATUS conditionally depending on the feature bits.
Signed-off-by: Si-Wei Liu
---
drivers/vdpa/vdpa.c | 20 +++-
1 file changed, 15 insertions(+),
With device feature provisioning, there's a chance for misconfiguration
that the vdpa feature attribute supplied in 'vdpa dev add' command doesn't
get selected on the device_features to be provisioned. For instance, when
a @mac attribute is specified, the corresponding feature bit _F_MAC in
Introduce VIRTIO_DEVICE_F_MASK bitmask used for identification
of per-device features. Feature bits VIRTIO_TRANSPORT_F_START
through VIRTIO_TRANSPORT_F_END are reserved for transport
features hence are not counted as per-device features against
the 64bit feature space.
Signed-off-by: Si-Wei Liu
In below example, before the fix, mtu attribute is supported
by the parent mgmtdev, but the error message showing "All
provided are not supported" is just misleading.
$ vdpa mgmtdev show
vdpasim_net:
supported_classes net
max_supported_vqs 3
dev_features MTU MAC CTRL_VQ CTRL_MAC_ADDR
Today when device features are explicitly provisioned, the features
user supplied may contain device class specific features that are
not supported by the parent managment device. On the other hand,
when parent managment device supports more than one class, the
device features to provision may be
This patchset is pre-requisite to export and provision device
config attributes and features for vdpa live migration, in a way
backward and forward compatibility can be retained. The follow up
work [1] will need to be built around the new feature provisioning
uAPI, with which it's easier to
On Mon, Jan 30, 2023 at 11:19:06AM -0700, Ross Zwisler wrote:
> The canonical location for the tracefs filesystem is at /sys/kernel/tracing.
Acked-by: Michael S. Tsirkin
> But, from Documentation/trace/ftrace.rst:
>
> Before 4.1, all ftrace tracing control files were within the debugfs
>
On Mon, Jan 30, 2023 at 11:19:13AM -0700, Ross Zwisler wrote:
> The canonical location for the tracefs filesystem is at /sys/kernel/tracing.
>
> But, from Documentation/trace/ftrace.rst:
>
> Before 4.1, all ftrace tracing control files were within the debugfs
> file system, which is
On Sun, Jan 29, 2023 at 04:11:45AM -0500, Bo Liu wrote:
> Follow the advice of the Documentation/filesystems/sysfs.rst
> and show() should only use sysfs_emit() or sysfs_emit_at()
> when formatting the value to be returned to user space.
>
> Signed-off-by: Bo Liu
> ---
> drivers/vhost/scsi.c |
On 1/30/2023 1:05 PM, Si-Wei Liu wrote:
Apologies, I was over booked for multiple things in parallel, and
there had been urgent internal priorities popped up at times for the
past few weeks. On the other hand, there were brokenness or
incompleteness identified around features provisioning
On Mon, Jan 30, 2023 at 5:23 PM Christoph Hellwig wrote:
>
> Use the bvec_set_page helper to initialize a bvec.
>
> Signed-off-by: Christoph Hellwig
A typo in the subject, should be "vringh".
Other than this
Acked-by: Jason Wang
Thanks
> ---
> drivers/vhost/vringh.c | 5 ++---
> 1 file
On Tue, Jan 31, 2023 at 05:00:32AM +, Matthew Wilcox wrote:
> On Mon, Jan 30, 2023 at 08:47:58PM -0800, Jakub Kicinski wrote:
> > kinda random thought but since we're touching this area - could we
> > perhaps move the definition of struct bio_vec and trivial helpers
> > like this into a new
On Mon, Jan 30, 2023 at 7:54 PM Eli Cohen wrote:
>
>
> On 30/01/2023 13:34, Michael S. Tsirkin wrote:
> > On Mon, Jan 30, 2023 at 12:01:23PM +0200, Eli Cohen wrote:
> >> On 30/01/2023 10:19, Jason Wang wrote:
> >>> Hi Eli:
> >>>
> >>> On Mon, Jan 23, 2023 at 1:59 PM Eli Cohen wrote:
> VDPA
On Tue, Jan 31, 2023 at 12:39 AM Eugenio Perez Martin
wrote:
>
> On Sun, Jan 29, 2023 at 7:01 AM Jason Wang wrote:
> >
> > On Thu, Jan 19, 2023 at 4:11 PM Eugenio Perez Martin
> > wrote:
> > >
> > > On Thu, Jan 19, 2023 at 4:20 AM Jason Wang wrote:
> > > >
> > > > On Thu, Jan 19, 2023 at 12:44
On Mon, Jan 30, 2023 at 5:26 PM Colin Ian King wrote:
>
> There are two spelling mistakes in some literal strings. Fix them.
>
> Signed-off-by: Colin Ian King
Acked-by: Jason Wang
Thanks
> ---
> drivers/vdpa/vdpa.c | 2 +-
> drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 2 +-
> 2
On Tue, Jan 31, 2023 at 9:32 AM Nanyong Sun wrote:
>
> On 2023/1/29 14:02, Jason Wang wrote:
> > On Sat, Jan 28, 2023 at 10:25 AM Nanyong Sun wrote:
> >> From: Rong Wang
> >>
> >> Once enable iommu domain for one device, the MSI
> >> translation tables have to be there for software-managed MSI.
On Mon, Jan 30, 2023 at 11:18 PM Michael S. Tsirkin wrote:
>
> On Mon, Jan 30, 2023 at 10:21:43AM +0100, Christoph Hellwig wrote:
> > Use the bvec_set_virt helper to initialize the special_vec.
> >
> > Signed-off-by: Christoph Hellwig
>
> Acked-by: Michael S. Tsirkin
Acked-by: Jason Wang
On Mon, Jan 30, 2023 at 7:18 PM Michael S. Tsirkin wrote:
>
> On Mon, Jan 30, 2023 at 03:44:24PM +0800, Jason Wang wrote:
> > On Mon, Jan 30, 2023 at 1:43 PM Michael S. Tsirkin wrote:
> > >
> > > On Mon, Jan 30, 2023 at 10:53:54AM +0800, Jason Wang wrote:
> > > > On Sun, Jan 29, 2023 at 3:30 PM
On Mon, Jan 30, 2023 at 08:47:58PM -0800, Jakub Kicinski wrote:
> kinda random thought but since we're touching this area - could we
> perhaps move the definition of struct bio_vec and trivial helpers
> like this into a new header? bvec.h pulls in mm.h which is a right
> behemoth :S
I bet we can
On Mon, Jan 30, 2023 at 01:54:14PM +0200, Eli Cohen wrote:
>
> On 30/01/2023 13:34, Michael S. Tsirkin wrote:
> > On Mon, Jan 30, 2023 at 12:01:23PM +0200, Eli Cohen wrote:
> > > On 30/01/2023 10:19, Jason Wang wrote:
> > > > Hi Eli:
> > > >
> > > > On Mon, Jan 23, 2023 at 1:59 PM Eli Cohen
On Tue, Jan 31, 2023 at 11:24:52AM +0800, Jason Wang wrote:
> On Mon, Jan 30, 2023 at 7:18 PM Michael S. Tsirkin wrote:
> >
> > On Mon, Jan 30, 2023 at 03:44:24PM +0800, Jason Wang wrote:
> > > On Mon, Jan 30, 2023 at 1:43 PM Michael S. Tsirkin
> > > wrote:
> > > >
> > > > On Mon, Jan 30, 2023
66 matches
Mail list logo