Re: [PATCH v2] vdpa/mlx5: Fix firmware error on creation of 1k VQs

2023-09-14 Thread Dragos Tatulea via Virtualization
On Thu, 2023-08-31 at 18:50 +0300, Dragos Tatulea wrote: > A firmware error is triggered when configuring a 9k MTU on the PF after > switching to switchdev mode and then using a vdpa device with larger > (1k) rings: > mlx5_cmd_out_err: CREATE_GENERAL_OBJECT(0xa00) op_mod(0xd) failed, status bad >

Re: [PATCH] vdpa/mlx5: Fix double release of debugfs entry

2023-09-14 Thread Dragos Tatulea via Virtualization
On Tue, 2023-08-29 at 20:40 +0300, Dragos Tatulea wrote: > The error path in setup_driver deletes the debugfs entry but doesn't > clear the pointer. During .dev_del the invalid pointer will be released > again causing a crash. > > This patch fixes the issue by always clearing the debugfs entry in

Re: [PATCH net-next v8 4/4] vsock/virtio: MSG_ZEROCOPY flag support

2023-09-14 Thread Stefano Garzarella
On Mon, Sep 11, 2023 at 11:22:34PM +0300, Arseniy Krasnov wrote: This adds handling of MSG_ZEROCOPY flag on transmission path: 1) If this flag is set and zerocopy transmission is possible (enabled in socket options and transport allows zerocopy), then non-linear skb will be created and

Re: [PATCH net-next v8 2/4] vsock/virtio: support to send non-linear skb

2023-09-14 Thread Stefano Garzarella
On Mon, Sep 11, 2023 at 11:22:32PM +0300, Arseniy Krasnov wrote: For non-linear skb use its pages from fragment array as buffers in virtio tx queue. These pages are already pinned by 'get_user_pages()' during such skb creation. Signed-off-by: Arseniy Krasnov --- Changelog: v2 -> v3: * Comment

Re: [PATCH net-next v8 0/4] vsock/virtio/vhost: MSG_ZEROCOPY preparations

2023-09-14 Thread Stefano Garzarella
Hi Arseniy, On Mon, Sep 11, 2023 at 11:22:30PM +0300, Arseniy Krasnov wrote: Hello, this patchset is first of three parts of another big patchset for MSG_ZEROCOPY flag support: https://lore.kernel.org/netdev/20230701063947.3422088-1-avkras...@sberdevices.ru/ During review of this series,

Re: [PATCH net-next v8 0/4] vsock/virtio/vhost: MSG_ZEROCOPY preparations

2023-09-14 Thread Stefano Garzarella
On Thu, Sep 14, 2023 at 05:05:17PM +0300, Arseniy Krasnov wrote: Hello Stefano, On 14.09.2023 17:07, Stefano Garzarella wrote: Hi Arseniy, On Mon, Sep 11, 2023 at 11:22:30PM +0300, Arseniy Krasnov wrote: Hello, this patchset is first of three parts of another big patchset for MSG_ZEROCOPY

Re: [PATCH V11 07/17] riscv: qspinlock: Introduce qspinlock param for command line

2023-09-14 Thread Waiman Long
On 9/14/23 03:32, Leonardo Bras wrote: On Tue, Sep 12, 2023 at 09:08:34AM +0800, Guo Ren wrote: On Mon, Sep 11, 2023 at 11:34 PM Waiman Long wrote: On 9/10/23 04:29, guo...@kernel.org wrote: From: Guo Ren Allow cmdline to force the kernel to use queued_spinlock when

Re: [PATCH RFC v2 1/4] vdpa: introduce .reset_map operation callback

2023-09-14 Thread Si-Wei Liu
On 9/11/2023 11:23 PM, Jason Wang wrote: On Tue, Sep 12, 2023 at 7:31 AM Si-Wei Liu wrote: Hi Jason, On 9/10/2023 8:42 PM, Jason Wang wrote: Hi Si-Wei: On Sat, Sep 9, 2023 at 9:34 PM Si-Wei Liu wrote: On-chip IOMMU parent driver could use it to restore memory mapping to the initial

Re: [PATCH RFC v3 2/4] vdpa/mlx5: implement .reset_map driver op

2023-09-14 Thread Si-Wei Liu
On 9/11/2023 11:53 PM, Jason Wang wrote: On Tue, Sep 12, 2023 at 8:02 AM Si-Wei Liu wrote: On 9/10/2023 8:48 PM, Jason Wang wrote: On Sat, Sep 9, 2023 at 9:46 PM Si-Wei Liu wrote: Today, mlx5_vdpa gets started by preallocate 1:1 DMA mapping at device creation time, while this 1:1

Re: [PATCH RFC v3 4/4] vhost-vdpa: introduce IOTLB_PERSIST backend feature bit

2023-09-14 Thread Si-Wei Liu
On 9/12/2023 12:01 AM, Jason Wang wrote: On Tue, Sep 12, 2023 at 8:28 AM Si-Wei Liu wrote: On 9/10/2023 8:52 PM, Jason Wang wrote: On Sat, Sep 9, 2023 at 9:46 PM Si-Wei Liu wrote: Userspace needs this feature flag to distinguish if vhost-vdpa iotlb in the kernel supports persistent