Re: [PATCH v2 1/2] tools/virtio: Add dma sync api for virtio test

On Sat, 7 Oct 2023 14:55:46 +0800, liming...@jaguarmicro.com wrote: > From: Liming Wu > > Fixes: 8bd2f71054bd ("virtio_ring: introduce dma sync api for virtqueue") > also add dma sync api for virtio test. > > Signed-off-by: Liming Wu You should post a new thread. Thanks. > --- > tools/virti

Re: [PATCH 09/16] vdpa/mlx5: Allow creation/deletion of any given mr struct

On Tue, Sep 26, 2023 at 3:21 PM Dragos Tatulea wrote: > > On Tue, 2023-09-26 at 12:44 +0800, Jason Wang wrote: > > On Tue, Sep 12, 2023 at 9:02 PM Dragos Tatulea wrote: > > > > > > This patch adapts the mr creation/deletion code to be able to work with > > > any given mr struct pointer. All the A

Re: [PATCH vfio 11/11] vfio/virtio: Introduce a vfio driver over virtio devices

On Tue, Sep 26, 2023 at 7:49 PM Michael S. Tsirkin wrote: > > On Tue, Sep 26, 2023 at 10:32:39AM +0800, Jason Wang wrote: > > It's the implementation details in legacy. The device needs to make > > sure (reset) the driver can work (is done before get_status return). > > I think that there's no way

Re: [PATCH 1/2] virtio_pci: fix the common map size and add check for vq-reset

On Mon, Sep 25, 2023 at 11:58 AM Xuan Zhuo wrote: > > Now, the function vp_modern_map_capability() takes the size parameter, > which corresponds to the size of virtio_pci_common_cfg. As a result, the > pci_iomap_range() function maps the memory area for > virtio_pci_common_cfg. > > However, if the

Re: [PATCH 2/2] virtio_pci: add build offset check for the new common cfg items

On Mon, Sep 25, 2023 at 11:58 AM Xuan Zhuo wrote: > > Add checks to the check_offsets(void) for queue_notify_data and > queue_reset. > > Signed-off-by: Xuan Zhuo Acked-by: Jason Wang Thanks > --- > drivers/virtio/virtio_pci_modern_dev.c | 4 > 1 file changed, 4 insertions(+) > > diff --

Re: [PATCH 2/2] tools/virtio: Add hints when module is not installed

On Tue, Sep 26, 2023 at 1:00 PM wrote: > > From: Liming Wu > > Need to insmod vhost_test.ko before run virtio_test. > Give some hints to users. > > Signed-off-by: Liming Wu > --- > tools/virtio/virtio_test.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/tools/virtio/virtio_test.c

Re: [PATCH 1/2] tools/virtio: Add dma sync api for virtio test

On Tue, Sep 26, 2023 at 1:00 PM wrote: > > From: Liming Wu > > Fixes: 8bd2f71054bd ("virtio_ring: introduce dma sync api for virtqueue") > also add dma sync api for virtio test. > > Signed-off-by: Liming Wu Acked-by: Jason Wang Thanks > --- > tools/virtio/linux/dma-mapping.h | 12 ++

Re: [PATCH vhost] virtio_net: fix the missing of the dma cpu sync

On Wed, Sep 27, 2023 at 1:53 PM Xuan Zhuo wrote: > > Commit 295525e29a5b ("virtio_net: merge dma operations when filling > mergeable buffers") unmaps the buffer with DMA_ATTR_SKIP_CPU_SYNC when > the dma->ref is zero. We do that with DMA_ATTR_SKIP_CPU_SYNC, because we > do not want to do the sync

Re: [RFC v2 3/4] vduse: update the vq_info in ioctl

On Fri, Sep 29, 2023 at 5:12 PM Maxime Coquelin wrote: > > > > On 9/12/23 09:39, Jason Wang wrote: > > On Tue, Sep 12, 2023 at 11:00 AM Cindy Lu wrote: > >> > >> In VDUSE_VQ_GET_INFO, the driver will sync the last_avail_idx > >> with reconnect info, After mapping the reconnect pages to userspace

Re: [PATCH net v2 4/6] virtio-net: fix per queue coalescing parameter setting

On Mon, Sep 25, 2023 at 3:53 PM Heng Qi wrote: > > When the user sets a non-zero coalescing parameter to 0 for a specific > virtqueue, it does not work as expected, so let's fix this. > > Fixes: 394bd87764b6 ("virtio_net: support per queue interrupt coalesce > command") > Reported-by: Xiaoming Zh

Re: [PATCH net v2 5/6] virtio-net: fix the vq coalescing setting for vq resize

On Thu, Oct 5, 2023 at 2:12 PM Heng Qi wrote: > > > > 在 2023/10/3 下午6:41, Paolo Abeni 写道: > > On Mon, 2023-09-25 at 15:53 +0800, Heng Qi wrote: > >> According to the definition of virtqueue coalescing spec[1]: > >> > >>Upon disabling and re-enabling a transmit virtqueue, the device MUST set >

Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop

On Fri, Oct 6, 2023 at 3:35 AM Feng Liu wrote: > > > > On 2023-07-24 a.m.2:46, Michael S. Tsirkin wrote: > > External email: Use caution opening links or attachments > > > > > > On Fri, Jul 21, 2023 at 10:18:03PM +0200, Maxime Coquelin wrote: > >> > >> > >> On 7/21/23 17:10, Michael S. Tsirkin wro

Re: [PATCH] vduse: make vduse_class constant

On Fri, Oct 6, 2023 at 10:31 PM Greg Kroah-Hartman wrote: > > Now that the driver core allows for struct class to be in read-only > memory, we should make all 'class' structures declared at build time > placing them into read-only memory, instead of having to be dynamically > allocated at runtime.

Re: [PATCH] vduse: make vduse_class constant

On Fri, Oct 06, 2023 at 04:30:44PM +0200, Greg Kroah-Hartman wrote: > Now that the driver core allows for struct class to be in read-only > memory, we should make all 'class' structures declared at build time > placing them into read-only memory, instead of having to be dynamically > allocated at r

Re: [PATCH] vduse: make vduse_class constant

On Sun, Oct 08, 2023 at 02:20:52AM -0400, Michael S. Tsirkin wrote: > On Fri, Oct 06, 2023 at 04:30:44PM +0200, Greg Kroah-Hartman wrote: > > Now that the driver core allows for struct class to be in read-only > > memory, we should make all 'class' structures declared at build time > > placing them

Re: [PATCH] vduse: make vduse_class constant

On Sun, Oct 08, 2023 at 08:40:05AM +0200, Greg Kroah-Hartman wrote: > On Sun, Oct 08, 2023 at 02:20:52AM -0400, Michael S. Tsirkin wrote: > > On Fri, Oct 06, 2023 at 04:30:44PM +0200, Greg Kroah-Hartman wrote: > > > Now that the driver core allows for struct class to be in read-only > > > memory, w

Re: [PATCH] vduse: make vduse_class constant

On Sun, Oct 08, 2023 at 02:41:22AM -0400, Michael S. Tsirkin wrote: > On Sun, Oct 08, 2023 at 08:40:05AM +0200, Greg Kroah-Hartman wrote: > > On Sun, Oct 08, 2023 at 02:20:52AM -0400, Michael S. Tsirkin wrote: > > > On Fri, Oct 06, 2023 at 04:30:44PM +0200, Greg Kroah-Hartman wrote: > > > > Now tha