On Thu, 2007-05-10 at 01:33 -0400, Jeff Garzik wrote:
Rusty Russell wrote:
I realize your continual battle with this, but adding a layer of
indirection doesn't seem like it will add clarity. The issues with
__pa() are reasonably known (don't hand it a vmalloc address, for
example).
On 05/09/2007 12:22 PM, Pekka Enberg wrote:
+static void end_entire_request(struct request *req, int uptodate)
+{
+ if (end_that_request_first(req, uptodate, req-hard_nr_sectors))
+ BUG();
+ add_disk_randomness(req-rq_disk);
+ blkdev_dequeue_request(req);
+
From: Jeremy Fitzhardinge [EMAIL PROTECTED]
Date: Thu, 10 May 2007 15:00:05 -0700
Herbert Xu wrote:
[NET] link_watch: Move link watch list into net_device
These days the link watch mechanism is an integral part of the
network subsystem as it manages the carrier status. So it now
makes
David Miller wrote:
From: Jeremy Fitzhardinge [EMAIL PROTECTED]
Date: Thu, 10 May 2007 15:00:05 -0700
Herbert Xu wrote:
[NET] link_watch: Move link watch list into net_device
These days the link watch mechanism is an integral part of the
network subsystem as it manages the
Andrew Morton wrote:
Five minutes after boot is when jiffies wraps. Are you sure it's
a list-screwup rather than a jiffy-wrap screwup?
Hm, its suggestive, isn't it? Apparently they've already fixed this in
the sekret networking clubhouse, so I'll need to track it down.
J
From: Jeremy Fitzhardinge [EMAIL PROTECTED]
Date: Thu, 10 May 2007 15:22:17 -0700
Andrew Morton wrote:
Five minutes after boot is when jiffies wraps. Are you sure it's
a list-screwup rather than a jiffy-wrap screwup?
Hm, its suggestive, isn't it? Apparently they've already fixed
David Miller wrote:
I'm not so certain now that we know it's the jiffies wrap point :-)
The fixes in question are attached below and they were posted and
discussed on netdev:
Yep, this patch gets rid of my spinning thread. I can't find this patch
or any discussion on marc.info; is there
* Jeremy Fitzhardinge ([EMAIL PROTECTED]) wrote:
Yep, this patch gets rid of my spinning thread. I can't find this patch
or any discussion on marc.info; is there a better netdev list archive?
See the linkwatch bustage in git-net thread on netdev
From: Jeremy Fitzhardinge [EMAIL PROTECTED]
Date: Thu, 10 May 2007 15:45:42 -0700
David Miller wrote:
I'm not so certain now that we know it's the jiffies wrap point :-)
The fixes in question are attached below and they were posted and
discussed on netdev:
Yep, this patch gets
Hi all,
Gratefully-received recent feedback from CC'd was applied to excellent
effect (and the advice from Matt Mackall about my personal appearance is
best unrequited).
The patch is split in 5 parts to correspond with the 9 parts Andrew
sent out before, but here's the summary:
1) Sam Ravnborg says lg-objs is deprecated, use lg-y.
2) Sparse: page_tables.c unnecessary initialization
3) Lots of __force to shut sparse up: guest physical addresses are
userspace virtual.
4) Change prototype of run_lguest and do cast in caller instead (when we add
__iomem to cast, it
Feedback from Jeff Garzik:
1) Use netdev_priv instead of dev-priv.
2) Check for ioremap failure
3) iounmap on failure.
4) Wrap SEND_DMA and BIND_DMA calls
5) Don't set NETIF_F_SG unless we set NETIF_F_NO_CSUM
6) Use SET_NETDEV_DEV()
7) Don't set dev-irq, mem_start mem_end (deprecated)
Sparse
1) Use new dma wrapper functions, and handle bind failure (may happen
in future)
2) Use new lgdev_irq() get me a good interrupt number function.
3) __force the ioremap: guests can use it as normal memory.
Signed-off-by: Rusty Russell [EMAIL PROTECTED]
---
drivers/block/lguest_blk.c | 16
1) send-dma and bind-dma hypercall wrappers for drivers to use,
2) formalization of the convention that devices can use the irq
corresponding to their index on the lguest_bus.
3) ___force to shut up sparse: guests *can* use ioremap as virtual mem.
4) lguest.c should include lguest_bus.h for
1) Use new lguest_send_dma lguest_bind_dma functions.
2) sparse: lguest_cons can be static.
Signed-off-by: Rusty Russell [EMAIL PROTECTED]
---
drivers/char/hvc_lguest.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
15 matches
Mail list logo
