Re: Multicast and receive filtering in TUN/TAP

2008-07-10 Thread Christian Borntraeger
Am Donnerstag, 10. Juli 2008 schrieb Max Krasnyansky: [...] The second question is do you guys think that QEMU/KVM/LGUEST/etc would benefit if receive filtering was done by the host OS. Here is a specific example of what I'm talking about. We can do what qemu/hw/e1000.c:receive_filter() does

Re: [PATCH 2/4] KVM: Introduce a callback routine for IOAPIC ack handling

2008-07-10 Thread Avi Kivity
Ben-Ami Yassour wrote: On Mon, 2008-07-07 at 13:08 +0300, Avi Kivity wrote: Amit Shah wrote: This will be useful for acking irqs of assigned devices And also for improving time drift tracking. Please make this more generic by having a list of callbacks. There could

Re: Multicast and receive filtering in TUN/TAP

2008-07-10 Thread Max Krasnyansky
Christian Borntraeger wrote: Am Donnerstag, 10. Juli 2008 schrieb Max Krasnyansky: [...] The second question is do you guys think that QEMU/KVM/LGUEST/etc would benefit if receive filtering was done by the host OS. Here is a specific example of what I'm talking about. We can do what

Re: Multicast and receive filtering in TUN/TAP

2008-07-10 Thread Christian Borntraeger
Am Donnerstag, 10. Juli 2008 schrieb Max Krasnyansky: Thing is, we are heading towards virtio. Even for Windows ? Its possible: http://marc.info/?l=kvmm=121075389300722w=2 Unfortunately, virtio_net currently does not offer a method to register multicast addresses. I haven't looked at

Re: Multicast and receive filtering in TUN/TAP

2008-07-10 Thread Shaun Jackman
Hi Max, The original patch implemented receive multicast filtering by emulating the implementation used by many physical Ethernet interfaces: hashing the multicast address. TUN emulates two network cards (and communication via the virtual link between them), the guest and the host, or the

Re: Multicast and receive filtering in TUN/TAP

2008-07-10 Thread Max Krasnyansky
Brian Braunstein wrote: Sorry that I was confused here and it seems I am still confused. I was thinking that for any one instance of a TAP interface, there should be only 1 MAC address, since there is only 1 network interface, since the character device is not a network interface but

Re: [PATCH] virtio_net: Set VIRTIO_NET_F_GUEST_CSUM feature

2008-07-10 Thread Jeff Garzik
Rusty Russell wrote: From: Mark McLoughlin [EMAIL PROTECTED] We can handle receiving partial csums, so set the appropriate feature bit. Signed-off-by: Mark McLoughlin [EMAIL PROTECTED] Signed-off-by: Rusty Russell [EMAIL PROTECTED] --- drivers/net/virtio_net.c |3 ++- 1 file