On Mon, Jul 20, 2009 at 07:38:23PM -0700, Greg KH wrote:
> On Tue, Jul 21, 2009 at 02:00:16AM +0200, Arnd Bergmann wrote:
> > On Friday 17 July 2009, Greg Kroah-Hartman wrote:
> > > From: Greg Kroah-Hartman
> > >
> > > The ULONG and LONG typedefs are now removed from the Hyper-V driver
> > > code
On Tue, Jul 21, 2009 at 02:00:16AM +0200, Arnd Bergmann wrote:
> On Friday 17 July 2009, Greg Kroah-Hartman wrote:
> > From: Greg Kroah-Hartman
> >
> > The ULONG and LONG typedefs are now removed from the Hyper-V driver
> > code
> >
>
> This conversion is not equivalent:
>
> > //
> > -// unsi
On Tue, Jul 21, 2009 at 01:39:19AM +0200, Arnd Bergmann wrote:
> On Friday 17 July 2009, Greg Kroah-Hartman wrote:
> > I don't think we really want to be doing a irqsave for this code, but I
> > left it alone to preserve the original codepath. It should be reviewed
> > later.
>
> This patch does
Arnd,
Thanks for this and the other mails reviewing the code.
My TODO list keeps on getting bigger :). I will check into all of these and
correct them.
Keep them coming!
Thanks!
Hank.
-Original Message-
From: Arnd Bergmann [mailto:a...@arndb.de]
Sent: Monday, July 20, 2009 5:00 PM
On Friday 17 July 2009, Greg Kroah-Hartman wrote:
> From: Greg Kroah-Hartman
>
> The ULONG and LONG typedefs are now removed from the Hyper-V driver
> code
>
This conversion is not equivalent:
> //
> -// unsigned types
> -//
> -typedef unsigned int ULONG;
> -
> -//
> -// signed types
On Friday 17 July 2009, Greg Kroah-Hartman wrote:
> @@ -43,7 +43,7 @@ typedef struct _RING_BUFFER {
> // volatile u32 InterruptMask;
> // Ring data starts here + RingDataStartOffset !!! DO NOT place any
> fields below this !!!
> u8 Buffer[0];
> -} STRUCT_PACKED RING_BU
On Friday 17 July 2009, Greg Kroah-Hartman wrote:
> I don't think we really want to be doing a irqsave for this code, but I
> left it alone to preserve the original codepath. It should be reviewed
> later.
This patch does not preserve the original code path if any of the
callers has a different i
On Mon, Jul 20, 2009 at 11:24:24PM +0200, Jan Engelhardt wrote:
>
> On Monday 2009-07-20 18:00, Greg Kroah-Hartman wrote:
> >
> >I'm happy to announce, that after many months of discussions, Microsoft
> >has released their Hyper-V Linux drivers under the GPLv2. Following
> >this message, will be
On Mon, Jul 20, 2009 at 09:37:12PM +0200, Andi Kleen wrote:
> Greg KH writes:
> >
> > It's the "normal" way of cleaning up code. Start with a known-working
> > piece of stuff, and incrementally clean it up.
>
> I have to agree with David. This is essentially unreviewable
> in the original state
From: Greg Kroah-Hartman
Don't use the wrapper functions for this lock, make it a real
lock so that we know what is going on.
I don't think we really want to be doing a irqsave for this code, but I
left it alone to preserve the original codepath. It should be reviewed
later.
Cc: Hank Janssen
Greg KH writes:
>
> It's the "normal" way of cleaning up code. Start with a known-working
> piece of stuff, and incrementally clean it up.
I have to agree with David. This is essentially unreviewable
in the original state. It would be good if you could
do all the obvious cleanups first and then
From: Greg Kroah-Hartman
Use the "real" kfree call instead of a wrapper function.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/Channel.c |8
drivers/staging/hv/ChannelMgmt.c | 14 +++---
drivers/staging/hv/Connection.c
On Mon, Jul 20, 2009 at 01:15:23PM -0400, Dave Jones wrote:
> On Mon, Jul 20, 2009 at 07:09:11PM +0200, Matthias Urlichs wrote:
> > Hi,
> >
> > Dave Jones:
> > > Given the numerous cleanup patches that already exist, is there any
> reason
> > > to not just post the cleaned up drivers ? It w
From: Greg Kroah-Hartman
The kernel has the "correct" min() and max() functions, so use those.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/include/osd.h |3 ---
drivers/staging/hv/storvsc_drv.c |4 ++--
2 files changed, 2 insertions(+),
From: Greg Kroah-Hartman
The BOOL and BOOLEAN typedefs are now removed from the Hyper-V driver
code.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/ChannelMgmt.c |2 +-
drivers/staging/hv/Hv.h|2 +-
d
From: Greg Kroah-Hartman
The kernel provides all of this, and actually gets it correct, so don't
try to redefine these types of things.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/BlkVsc.c |1 +
drivers/staging/hv/NetVsc.c |1
On Mon, Jul 20, 2009 at 12:59:41PM -0400, Dave Jones wrote:
> On Mon, Jul 20, 2009 at 09:28:10AM -0700, Greg KH wrote:
> > On Mon, Jul 20, 2009 at 09:00:25AM -0700, Greg Kroah-Hartman wrote:
> > >
> > > Hi all,
> > >
> > > I'm happy to announce, that after many months of discussions, Microso
From: Greg Kroah-Hartman
Add the Hyper-V virtual bus to the kernel build system.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/Kconfig |2 ++
drivers/staging/Makefile|1 +
drivers/staging/hv/Kconfig |8
drivers/staging
From: Greg Kroah-Hartman
The #define KERNEL_2_6_27 needs to be set, and I adjusted the include
directories a bit to get things to build properly.
I also fixed up the direct access of bus_id, as that field is now gone.
Some minor scsi api changes were needed as well.
The hv_storvsc code should n
From: Greg Kroah-Hartman
Use the "real" udelay call instead of a wrapper function.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/NetVsc.c |9 +
drivers/staging/hv/StorVsc.c |7 ---
drivers/staging/hv/include/osd.h |
From: Greg Kroah-Hartman
Don't use the wrapper functions for this lock, make it a real
lock so that we know what is going on.
I don't think we really want to be doing a irqsave for this code, but I
left it alone to preserve the original codepath. It should be reviewed
later.
Cc: Hank Janssen
From: Greg Kroah-Hartman
Don't define things that are either already provided (like NULL), or you
shouldn't use (like TRUE and FALSE).
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/ChannelMgmt.c |4 ++--
drivers/staging/hv/Hv.c |
From: Greg Kroah-Hartman
The #define KERNEL_2_6_27 needs to be set, and I adjusted the include
directories a bit to get things to build properly.
I also fixed up the direct access of bus_id, as that field is now gone.
Lots of block api changes were needed, and I don't think I got it
all correct.
From: Greg Kroah-Hartman
Add the Hyper-V virtual block driver to the kernel build system.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/Kconfig |7 +++
drivers/staging/hv/Makefile |2 ++
2 files changed, 9 insertions(+)
--- a/driv
From: Greg Kroah-Hartman
Use the "real" print_hex_dump_bytes call instead of a wrapper function.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/ChannelMgmt.c |3 ++-
drivers/staging/hv/StorVsc.c |2 +-
drivers/staging/hv/blkvsc
From: Greg Kroah-Hartman
This isn't needed, or even used, at all.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/include/VmbusChannelInterface.h |9 -
drivers/staging/hv/include/osd.h |2 --
2 files changed, 11 de
From: Greg Kroah-Hartman
The SIZE_T typedef is now removed from the Hyper-V driver code.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/Connection.c |2 +-
drivers/staging/hv/Hv.c |2 +-
drivers/staging/hv/Hv.h |
From: Greg Kroah-Hartman
Use the "real" kmalloc call instead of a wrapper function.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/ChannelMgmt.c |3 +--
drivers/staging/hv/Hv.c |2 +-
drivers/staging/hv/NetVsc.c |2 +-
dr
From: Greg Kroah-Hartman
Remove the unneeded #defines from osd.c
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/osd.c | 42 --
1 file changed, 42 deletions(-)
--- a/drivers/staging/hv/osd.c
+++ b/drivers/
From: Greg Kroah-Hartman
Use the "real" kzalloc call instead of a wrapper function.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/Channel.c |8
drivers/staging/hv/Connection.c |4 ++--
drivers/staging/hv/NetVsc.c |4
From: Greg Kroah-Hartman
Don't use the wrapper functions for this lock, make it a real
lock so that we know what is going on.
I don't think we really want to be doing a irqsave for this code, but I
left it alone to preserve the original codepath. It should be reviewed
later.
Cc: Hank Janssen
From: Greg Kroah-Hartman
This isn't needed at all.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/include/osd.h |2 --
drivers/staging/hv/netvsc_drv.c |2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
--- a/drivers/staging/hv/includ
From: Greg Kroah-Hartman
After LogMsg was converted to printk, lots of build warnings showed up
as no one was checking the arguments to LogMsg. This patch fixes them
all.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/Hv.c |6 +++---
From: Greg Kroah-Hartman
Don't use the wrapper functions for this lock, make it a real
lock so that we know what is going on.
I don't think we really want to be doing a irqsave for this code, but I
left it alone to preserve the original codepath. It should be reviewed
later.
Cc: Hank Janssen
From: Greg Kroah-Hartman
Add the Hyper-V virtual scsi driver to the kernel build system.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/Kconfig |6 ++
drivers/staging/hv/Makefile |2 ++
2 files changed, 8 insertions(+)
--- a/drivers
From: Greg Kroah-Hartman
The #define KERNEL_2_6_27 needs to be set, and I adjusted the include
directories a bit to get things to build properly.
The driver was changed to use net_device_ops, as that is needed to build
and operate properly now.
The hv_netvsc code should now build with no errors
From: Greg Kroah-Hartman
Use the "real" kmalloc call instead of a wrapper function.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/Channel.c |9 +++--
drivers/staging/hv/ChannelMgmt.c |3 +--
drivers/staging/hv/Hv.c |2
From: Greg Kroah-Hartman
The ULONG_PTR typedef is now removed from the Hyper-V driver code.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/Channel.c |4 ++--
drivers/staging/hv/Connection.c |8
drivers/staging/hv/Hv.c
From: Greg Kroah-Hartman
The VOID typedef is now removed from the Hyper-V driver code.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/Channel.c |2 +-
drivers/staging/hv/ChannelMgmt.c |6 +++---
drivers/staging/hv/ChannelMgmt.h |
From: Greg Kroah-Hartman
The ULONG and LONG typedefs are now removed from the Hyper-V driver
code.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/StorVsc.c|2 +-
drivers/staging/hv/include/StorVscApi.h |2 +-
drivers/staging/h
On Mon, Jul 20, 2009 at 09:00:25AM -0700, Greg Kroah-Hartman wrote:
>
> Hi all,
>
> I'm happy to announce, that after many months of discussions, Microsoft
> has released their Hyper-V Linux drivers under the GPLv2. Following
> this message, will be the patches that add the drivers to the
> driv
From: Greg Kroah-Hartman
No one was even using them...
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/include/osd.h |2 --
1 file changed, 2 deletions(-)
--- a/drivers/staging/hv/include/osd.h
+++ b/drivers/staging/hv/include/osd.h
@@ -101,8
From: Greg Kroah-Hartman
No one was even using them.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/include/osd.h |1 -
drivers/staging/hv/osd.c | 14 --
2 files changed, 15 deletions(-)
--- a/drivers/staging/hv/include/
From: Greg Kroah-Hartman
Don't use the wrapper functions for this lock, make it a real
lock so that we know what is going on.
I don't think we really want to be doing a irqsave for this code, but I
left it alone to preserve the original codepath. It should be reviewed
later.
Cc: Hank Janssen
From: Greg Kroah-Hartman
Use the "real" printk call instead of a wrapper function.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/include/logging.h | 54 ---
drivers/staging/hv/include/osd.h |2 -
drivers/
From: Greg Kroah-Hartman
The PVOID typedef is now removed from the Hyper-V driver code.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/Channel.c | 20 ++--
drivers/staging/hv/Channel.h | 16
From: Greg Kroah-Hartman
Use the correct __attribute__((packed)) one if it's really needed.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/RingBuffer.h |2 +-
drivers/staging/hv/include/osd.h |3 ---
2 files changed, 1 insertion(+), 4 del
From: Greg Kroah-Hartman
The UINT64 and INT64 and UCHAR typedefs are now removed from the Hyper-V
driver code.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/BlkVsc.c|4 -
drivers/staging/hv/Channel.c
From: Greg Kroah-Hartman
The UINT8 and INT8 typedefs are now removed from the Hyper-V driver
code.
Had to include in a few places to get the
build to work properly as well.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/BlkVsc.c
From: Greg Kroah-Hartman
Now that there are no users of the wrapper functions for spinlocks,
remove them.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/include/osd.h |5 -
drivers/staging/hv/osd.c | 37 --
From: Greg Kroah-Hartman
The INTERNAL typedef is now removed from the Hyper-V driver code.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/Channel.h | 24
drivers/staging/hv/ChannelInterface.c | 22 +++
From: Greg Kroah-Hartman
The UINT16 and INT16 typedefs are now removed from the Hyper-V driver
code.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/Channel.c |6 +++---
drivers/staging/hv/Channel.h
From: Greg Kroah-Hartman
The ULONGLONG and LONGLONG typedefs are now removed from the Hyper-V
driver code.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/include/VmbusPacketFormat.h |2 +-
drivers/staging/hv/include/osd.h |3
From: Greg Kroah-Hartman
Don't use the wrapper functions for this lock, make it a real
lock so that we know what is going on.
I don't think we really want to be doing a irqsave for this code, but I
left it alone to preserve the original codepath. It should be reviewed
later.
Cc: Hank Janssen
From: Greg Kroah-Hartman
The USHORT typedef is now removed from the Hyper-V driver code.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/include/osd.h |1 -
drivers/staging/hv/include/vstorage.h |8
2 files changed, 4 inserti
From: Greg Kroah-Hartman
Add the Hyper-V virtual network driver to the kernel build system.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/Kconfig |7 +++
drivers/staging/hv/Makefile |2 ++
2 files changed, 9 insertions(+)
--- a/dri
From: Greg Kroah-Hartman
x86-64 needs a different config check. Thanks to Hank for the debugging
to determine the fix for this.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/Hv.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/d
From: Greg Kroah-Hartman
Use the "real" mb call instead of a wrapper function.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/RingBuffer.c |4 ++--
drivers/staging/hv/Vmbus.c |2 +-
drivers/staging/hv/include/osd.h |2 --
driver
From: Greg Kroah-Hartman
The #define KERNEL_2_6_27 needs to be set, and I adjusted the include
directories a bit to get things to build properly.
I also fixed up the direct access of bus_id, as that field is now gone.
The hv_vmbus code should now build properly, with no errors.
Cc: Hank Jansse
From: Greg Kroah-Hartman
First cut at what needs to be done to this codebase.
Cc: Hank Janssen
Cc: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/TODO | 15 +++
1 file changed, 15 insertions(+)
--- /dev/null
+++ b/drivers/staging/hv/TODO
@@ -0,0 +1,15
From: Hank Janssen
This is the virtual block driver when running Linux on top of Hyper-V.
Signed-off-by: Hank Janssen
Signed-off-by: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/BlkVsc.c | 107 ++
drivers/staging/hv/blkvsc_drv.c | 1547 +
From: Hank Janssen
These are the header files for the different Linux Hyper-V drivers to
use.
Signed-off-by: Hank Janssen
Signed-off-by: Haiyang Zhang
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/hv/include/NetVscApi.h | 145 +
drivers/staging/hv/include/StorVscApi
Hi all,
I'm happy to announce, that after many months of discussions, Microsoft
has released their Hyper-V Linux drivers under the GPLv2. Following
this message, will be the patches that add the drivers to the
drivers/staging/ tree, and a whole bunch of cleanups.
It's taken a long road to get h
63 matches
Mail list logo
