Re: [PATCH 1/1] XEN: enlighten, use uninitialized_var(cx)

2009-08-26 Thread Ingo Molnar
* Jiri Slaby jirisl...@gmail.com wrote: To avoid a wrong compiler warning, use unitialized_var(cx) in xen_init_cpuid_mask. cx needn't be initialized for cpuid when ax is 1. Signed-off-by: Jiri Slaby jirisl...@gmail.com Cc: Jeremy Fitzhardinge jer...@xensource.com Cc: Chris Wright

Re: vhost net: performance with ping benchmark

2009-08-26 Thread Michael S. Tsirkin
On Wed, Aug 26, 2009 at 05:04:44PM +0930, Rusty Russell wrote: On Tue, 25 Aug 2009 10:04:41 pm Arnd Bergmann wrote: On Tuesday 25 August 2009, Avi Kivity wrote: On 08/25/2009 05:22 AM, Anthony Liguori wrote: I think 2.6.32 is pushing it. 2.6.32 is pushing it, but we need to

[PATCH] virtio_net: Check for room in the vq before adding buffer

2009-08-26 Thread Amit Shah
Saves us one cycle of alloc-add-free if the queue was full. Signed-off-by: Amit Shah amit.s...@redhat.com --- Rusty: Tested this. 256 buffers are allocated with the patch, 257 without (and one is later freed). drivers/net/virtio_net.c |8 1 files changed, 4 insertions(+), 4

Re: Extending virtio_console to support multiple ports

2009-08-26 Thread Amit Shah
On (Tue) Aug 25 2009 [11:47:20], Amit Shah wrote: Hello all, Here is a new iteration of the patch series that implements a transport for guest and host communications. The code has been updated to reuse the virtio-console device instead of creating a new virtio-serial device. And the

IO controller Mini-Summit 2009

2009-08-26 Thread Ryo Tsuruta
Hi All, As I have notified before, The 1st Linux IO controller Mini-Summit will be held in Tokyo Japan on Oct 17 -- day before the 9th Linux kernel summit. So I would like to propose the following topics for the mini-summit and discuss about them. - Multiple IO controller development projects

Re: [PATCHv4 2/2] vhost_net: a kernel-level virtio server

2009-08-26 Thread Arnd Bergmann
On Tuesday 25 August 2009, Michael S. Tsirkin wrote: I'd like to avoid that here, though it's kind of ugly. We'd need VHOST_GET_FEATURES (and ACK) to take a struct like: u32 feature_size; u32 features[]; Hmm, variable length ioctl arguments, I'd rather not go there. The

Re: [PATCHv4 2/2] vhost_net: a kernel-level virtio server

2009-08-26 Thread Michael S. Tsirkin
On Wed, Aug 26, 2009 at 03:40:59PM +0200, Arnd Bergmann wrote: On Tuesday 25 August 2009, Michael S. Tsirkin wrote: I'd like to avoid that here, though it's kind of ugly. We'd need VHOST_GET_FEATURES (and ACK) to take a struct like: u32 feature_size; u32

Re: Extending virtio_console to support multiple ports

2009-08-26 Thread Amit Shah
[cc'ing some people who have made some commits in hvc_console.c] On (Wed) Aug 26 2009 [16:57:18], Amit Shah wrote: On (Tue) Aug 25 2009 [11:47:20], Amit Shah wrote: Hello all, Here is a new iteration of the patch series that implements a transport for guest and host communications.

Re: [PATCHv4 2/2] vhost_net: a kernel-level virtio server

2009-08-26 Thread Michael S. Tsirkin
On Tue, Aug 25, 2009 at 04:16:34PM +0300, Michael S. Tsirkin wrote: + /* If they don't want an interrupt, don't send one, unless empty. */ + if ((flags VRING_AVAIL_F_NO_INTERRUPT) vq-inflight) + return; And I wouldn't support notify on empty at all, TBH. If I don't,

Re: [PATCH 1/1] XEN: enlighten, use uninitialized_var(cx)

2009-08-26 Thread H. Peter Anvin
On 08/25/2009 11:09 PM, Ingo Molnar wrote: diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index e90540a..5ab75e2 100644 --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -202,7 +202,7 @@ static void xen_cpuid(unsigned int *ax, unsigned int *bx, static

Re: Extending virtio_console to support multiple ports

2009-08-26 Thread Benjamin Herrenschmidt
On Wed, 2009-08-26 at 21:15 +0530, Amit Shah wrote: - Convert hvc's usage of spinlocks to mutexes. I've no idea how this will play out; I'm no expert here. But I did try doing this and so far it all looks OK. No lockups, lockdep warnings, nothing. I have full debugging enabled.

Re: Extending virtio_console to support multiple ports

2009-08-26 Thread Michael Ellerman
On Wed, 2009-08-26 at 21:15 +0530, Amit Shah wrote: [cc'ing some people who have made some commits in hvc_console.c] On (Wed) Aug 26 2009 [16:57:18], Amit Shah wrote: On (Tue) Aug 25 2009 [11:47:20], Amit Shah wrote: Hello all, Here is a new iteration of the patch series that