Re: [PATCHv3 0/4] macvlan: add vepa and bridge mode

2009-11-26 Thread David Miller
From: Patrick McHardy Date: Thu, 26 Nov 2009 17:26:17 +0100 > Arnd Bergmann wrote: >> Version 2 description: >> The patch to iproute2 has not changed, so I'm not including >> it this time. Patch 4/4 (the netlink interface) is basically >> unchanged as well but included for completeness. >> >> Th

Re: [PATCH 1/4] veth: move loopback logic to common location

2009-11-26 Thread Patrick McHardy
Arnd Bergmann wrote: > On Thursday 26 November 2009, Patrick McHardy wrote: >> In addition to those already handled, I'd say >> >> - priority: affects qdisc classification, may refer to classes of the >> old namespace >> - ipvs_property: might cause packets to incorrectly skip netfilter hooks >>

Re: [PATCH 1/4] veth: move loopback logic to common location

2009-11-26 Thread Arnd Bergmann
On Thursday 26 November 2009, Patrick McHardy wrote: > In addition to those already handled, I'd say > > - priority: affects qdisc classification, may refer to classes of the > old namespace > - ipvs_property: might cause packets to incorrectly skip netfilter hooks > - nf_trace: might trigger pa

Re: [PATCH 1/4] veth: move loopback logic to common location

2009-11-26 Thread Eric W. Biederman
Patrick McHardy writes: > Arnd Bergmann wrote: >> On Tuesday 24 November 2009, Patrick McHardy wrote: >>> Eric W. Biederman wrote: I don't quite follow what you intend with dev_queue_xmit when the macvlan is in one namespace and the real physical device is in another. Are you ment

Re: [PATCHv3 0/4] macvlan: add vepa and bridge mode

2009-11-26 Thread Patrick McHardy
Arnd Bergmann wrote: > Version 2 description: > The patch to iproute2 has not changed, so I'm not including > it this time. Patch 4/4 (the netlink interface) is basically > unchanged as well but included for completeness. > > The other changes have moved forward a bit, to the point where > I find

[PATCHv3 2/4] macvlan: cleanup rx statistics

2009-11-26 Thread Arnd Bergmann
We have very similar code for rx statistics in two places in the macvlan driver, with a third one being added in the next patch. Consolidate them into one function to improve overall readability of the driver. Signed-off-by: Arnd Bergmann --- drivers/net/macvlan.c | 70 +++

[PATCHv3 1/4] veth: move loopback logic to common location

2009-11-26 Thread Arnd Bergmann
The veth driver contains code to forward an skb from the start_xmit function of one network device into the receive path of another device. Moving that code into a common location lets us reuse the code for direct forwarding of data between macvlan ports, and possibly in other drivers. Signed-off

[PATCHv3 4/4] macvlan: export macvlan mode through netlink

2009-11-26 Thread Arnd Bergmann
In order to support all three modes of macvlan at runtime, extend the existing netlink protocol to allow choosing the mode per macvlan slave interface. This depends on a matching patch to iproute2 in order to become accessible in user land. Signed-off-by: Arnd Bergmann --- drivers/net/macvlan.c

[PATCHv3 3/4] macvlan: implement bridge, VEPA and private mode

2009-11-26 Thread Arnd Bergmann
This allows each macvlan slave device to be in one of three modes, depending on the use case: MACVLAN_PRIVATE: The device never communicates with any other device on the same upper_dev. This even includes frames coming back from a reflective relay, where supported by the adjacent bridge.

[PATCHv3 0/4] macvlan: add vepa and bridge mode

2009-11-26 Thread Arnd Bergmann
Not many changes this time, just integrated a bug fix and all the coding style feedback from Eric Dumazet and Patrick McHardy. I'll keep the patch for network namespaces on the tx path out of this series for now, because the discussion is still ongoing and it addresses an unrelated issue. --- Ve

Re: [PATCH 1/4] veth: move loopback logic to common location

2009-11-26 Thread Patrick McHardy
Arnd Bergmann wrote: > On Tuesday 24 November 2009, Patrick McHardy wrote: >> Eric W. Biederman wrote: >>> I don't quite follow what you intend with dev_queue_xmit when the macvlan >>> is in one namespace and the real physical device is in another. Are >>> you mentioning that the packet classifier

Re: [PATCH 1/4] veth: move loopback logic to common location

2009-11-26 Thread Arnd Bergmann
On Tuesday 24 November 2009, Patrick McHardy wrote: > Eric W. Biederman wrote: > > I don't quite follow what you intend with dev_queue_xmit when the macvlan > > is in one namespace and the real physical device is in another. Are > > you mentioning that the packet classifier runs in the namespace w