vq log eventfd context pointer needs to be initialized, otherwise
operation may fail or oops if log is enabled but log eventfd not set by
userspace.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
drivers/vhost/vhost.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git
vhost was dong some complex math to get
offset to log at, and got it wrong by a couple of bytes,
while in fact it's simple: get address where we write,
subtract start of buffer, add log base.
Do it this way.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
drivers/vhost/vhost.c | 10
get_user_pages_fast returns number of pages on success, negative value
on failure, but never 0. Fix vhost code to match this logic.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
drivers/vhost/vhost.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git
The following patches on top of net-next fix issues related to write
logging in vhost. This fixes all known to me logging issues, migration
now works for me while under stress in both TX and RX directions.
Rusty's going on vacation, I am guessing he won't have time to review
this: Gleb, Juan,
Hey Rusty, Christian,
Christoph Hellwig asked why we don't need a barrier before this code in
virtcons_probe():
+ /* Start using the new console output. */
+ early_put_chars = NULL;
return 0;
Since only s390 uses early_put_chars so far, you'd know why it's not
needed / why
On Tue, Feb 23, 2010 at 06:57:58PM +0200, Michael S. Tsirkin wrote:
get_user_pages_fast returns number of pages on success, negative value
on failure, but never 0. Fix vhost code to match this logic.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
drivers/vhost/vhost.c |3 ++-
1
On Tue, Feb 23, 2010 at 07:34:34PM +0200, Gleb Natapov wrote:
On Tue, Feb 23, 2010 at 06:57:58PM +0200, Michael S. Tsirkin wrote:
get_user_pages_fast returns number of pages on success, negative value
on failure, but never 0. Fix vhost code to match this logic.
Signed-off-by: Michael S.
On Tue, Feb 23, 2010 at 07:32:58PM +0200, Michael S. Tsirkin wrote:
On Tue, Feb 23, 2010 at 07:34:34PM +0200, Gleb Natapov wrote:
On Tue, Feb 23, 2010 at 06:57:58PM +0200, Michael S. Tsirkin wrote:
get_user_pages_fast returns number of pages on success, negative value
on failure, but
On Tue, Feb 23, 2010 at 07:39:08PM +0200, Michael S. Tsirkin wrote:
On Tue, Feb 23, 2010 at 07:39:52PM +0200, Gleb Natapov wrote:
On Tue, Feb 23, 2010 at 07:32:58PM +0200, Michael S. Tsirkin wrote:
On Tue, Feb 23, 2010 at 07:34:34PM +0200, Gleb Natapov wrote:
On Tue, Feb 23, 2010 at
On Tue, Feb 23, 2010 at 07:39:52PM +0200, Gleb Natapov wrote:
On Tue, Feb 23, 2010 at 07:32:58PM +0200, Michael S. Tsirkin wrote:
On Tue, Feb 23, 2010 at 07:34:34PM +0200, Gleb Natapov wrote:
On Tue, Feb 23, 2010 at 06:57:58PM +0200, Michael S. Tsirkin wrote:
get_user_pages_fast returns
Michael S. Tsirkin m...@redhat.com wrote:
get_user_pages_fast returns number of pages on success, negative value
on failure, but never 0. Fix vhost code to match this logic.
It can return 0 if you ask for 0 pages :)
From the comment:
* Returns number of pages pinned. This may be fewer than
Michael S. Tsirkin m...@redhat.com wrote:
vhost was dong some complex math to get
offset to log at, and got it wrong by a couple of bytes,
while in fact it's simple: get address where we write,
subtract start of buffer, add log base.
Do it this way.
Signed-off-by: Michael S. Tsirkin
Michael S. Tsirkin m...@redhat.com wrote:
vq log eventfd context pointer needs to be initialized, otherwise
operation may fail or oops if log is enabled but log eventfd not set by
userspace.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Reviewed-by: Juan Quintela quint...@redhat.com
Am Dienstag 23 Februar 2010 18:10:22 schrieb Amit Shah:
Hey Rusty, Christian,
Christoph Hellwig asked why we don't need a barrier before this code in
virtcons_probe():
+ /* Start using the new console output. */
+ early_put_chars = NULL;
return 0;
Since only s390 uses
Just for the record I'm generally not interested in vhost
patches.
If it's a specific network one that will be merged via
the networking tree, yes please CC: me.
But if it's a bunch of changes to vhost.c and other pieces
of infrastructure, feel free to leave me out of it. It just
clutters my
On Wed, 24 Feb 2010 03:40:22 am Amit Shah wrote:
Hey Rusty, Christian,
Christoph Hellwig asked why we don't need a barrier before this code in
virtcons_probe():
+ /* Start using the new console output. */
+ early_put_chars = NULL;
return 0;
Since only s390 uses
(Will be away for a month from tomorrow, so this is an early pull request).
The following changes since commit 9f3a6284880ceea452903e2043c88d7226736318:
Linus Torvalds (1):
Merge branch 'upstream' of
git://ftp.linux-mips.org/pub/scm/upstream-linus
are available in the git repository
On Tue, Feb 23, 2010 at 02:42:35PM -0800, David Miller wrote:
Just for the record I'm generally not interested in vhost
patches.
If it's a specific network one that will be merged via
the networking tree, yes please CC: me.
But if it's a bunch of changes to vhost.c and other pieces
of
From: Michael S. Tsirkin m...@redhat.com
Date: Wed, 24 Feb 2010 07:37:37 +0200
Dave, so while Rusty's on vacation, what's the best way to get vhost
infrastructure fixes in? Are you ok with getting pull requests and
merging them into net-next? That should keep the clutter in your inbox
to the
On Tue, Feb 23, 2010 at 11:04:28PM -0800, David Miller wrote:
From: Michael S. Tsirkin m...@redhat.com
Date: Wed, 24 Feb 2010 07:37:37 +0200
Dave, so while Rusty's on vacation, what's the best way to get vhost
infrastructure fixes in? Are you ok with getting pull requests and
merging
From: Michael S. Tsirkin m...@redhat.com
Date: Wed, 24 Feb 2010 09:34:25 +0200
Implicitly, I guess. He said if there's an issue Michael Tsirkin is the
best person to resolve it, this was wrt merging his virtiolguest tree.
He didn't mention vhost, I wrote all of vhost though, there shouldn't be
21 matches
Mail list logo
