Can't build in the virtio console driver on x86_64 when the other virtio drivers are modular

2011-02-24 Thread Chuck Ebbert
The virtio configuration options are inconsistent. According to this, every options that needs virtio will select it: # Virtio always gets selected by whoever wants it. config VIRTIO tristate Note that it's not user-selectable, so any config file that tries to set it will be ignored

Re: [PATCH ] Staging: hv: Hyper-V driver cleanup

2011-02-24 Thread Greg KH
On Thu, Feb 24, 2011 at 03:20:58PM -0800, K. Y. Srinivasan wrote: This patch cleans up (a lot of the) naming issues that various reviewers have noted. It also gets rid of some unnecessary layering in the code. Whenever you have a patch description that says It also... you know you need to

RE: [PATCH ] Staging: hv: Hyper-V driver cleanup

2011-02-24 Thread KY Srinivasan
-Original Message- From: Greg KH [mailto:gre...@suse.de] Sent: Thursday, February 24, 2011 6:46 PM To: KY Srinivasan Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang; Hank Janssen Subject: Re: [PATCH ] Staging: hv:

Re: [PATCH ] Staging: hv: Hyper-V driver cleanup

2011-02-24 Thread Greg KH
On Fri, Feb 25, 2011 at 12:24:57AM +, KY Srinivasan wrote: -Original Message- From: Greg KH [mailto:gre...@suse.de] Sent: Thursday, February 24, 2011 6:46 PM To: KY Srinivasan Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org;

RE: [PATCH ] Staging: hv: Hyper-V driver cleanup

2011-02-24 Thread KY Srinivasan
-Original Message- From: Greg KH [mailto:gre...@suse.de] Sent: Thursday, February 24, 2011 7:32 PM To: KY Srinivasan Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang; Hank Janssen Subject: Re: [PATCH ] Staging: hv:

Re: Can't build in the virtio console driver on x86_64 when the other virtio drivers are modular

2011-02-24 Thread Amit Shah
On (Thu) 24 Feb 2011 [11:28:19], Chuck Ebbert wrote: The virtio configuration options are inconsistent. According to this, every options that needs virtio will select it: # Virtio always gets selected by whoever wants it. config VIRTIO tristate Note that it's not