RE: various vmbus review comments

2011-05-08 Thread KY Srinivasan
-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Tuesday, May 03, 2011 4:47 PM To: KY Srinivasan Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org Subject: various vmbus review comments I just took a quick

Re: various vmbus review comments

2011-05-08 Thread Greg KH
On Mon, May 09, 2011 at 01:46:56AM +, KY Srinivasan wrote: - the instances of hv_driver structures need to be static and not programatically defined, like all other USB and PCI drivers are handled. Done. You had expressed some concern that this would expose some issue

Re: [PATCH 09/18] virtio: use avail_event index

2011-05-08 Thread Rusty Russell
On Wed, 4 May 2011 23:51:47 +0300, Michael S. Tsirkin m...@redhat.com wrote: Use the new avail_event feature to reduce the number of exits from the guest. Figures here would be nice :) @@ -228,6 +237,12 @@ add_head: * new available array entries. */ virtio_wmb();

Re: [PATCH 08/18] virtio_ring: support for used_event idx feature

2011-05-08 Thread Rusty Russell
On Wed, 4 May 2011 23:51:38 +0300, Michael S. Tsirkin m...@redhat.com wrote: Add support for the used_event idx feature: when enabling interrupts, publish the current avail index value to the host so that we get interrupts on the next update. Signed-off-by: Michael S. Tsirkin m...@redhat.com

Re: [PATCH 06/18] virtio_ring: avail event index interface

2011-05-08 Thread Rusty Russell
On Wed, 4 May 2011 23:51:19 +0300, Michael S. Tsirkin m...@redhat.com wrote: Define a new feature bit for the host to declare that it uses an avail_event index (like Xen) instead of a feature bit to enable/disable interrupts. Signed-off-by: Michael S. Tsirkin m...@redhat.com ---