Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-27 Thread Jason Wang
On 11/28/2011 01:23 AM, Michael S. Tsirkin wrote: On Fri, Nov 25, 2011 at 01:35:52AM -0500, David Miller wrote: From: Krishna Kumar2 Date: Fri, 25 Nov 2011 09:39:11 +0530 Jason Wang wrote on 11/25/2011 08:51:57 AM: My description is not clear again :( I mean the same vhost thead: vhost thre

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-27 Thread Jason Wang
On 11/25/2011 12:09 PM, Krishna Kumar2 wrote: Jason Wang wrote on 11/25/2011 08:51:57 AM: My description is not clear again :( I mean the same vhost thead: vhost thread #0 transmits packets of flow A on processor M ... vhost thread #0 move to another process N and start to transmit packets of

Re: [PATCHv3 RFC] virtio-pci: flexible configuration layout

2011-11-27 Thread Rusty Russell
On Thu, 24 Nov 2011 09:11:22 +0200, "Michael S. Tsirkin" wrote: > On Thu, Nov 24, 2011 at 11:06:44AM +1030, Rusty Russell wrote: > > It'll be *clearer* to have two completely separate paths than to fill > > with if() statements. > > Well, look at my patches. See how each new feature basically ad

Re: [PATCH] virtio-mmio: Devices parameter parsing

2011-11-27 Thread Rusty Russell
On Wed, 23 Nov 2011 18:08:52 +, Pawel Moll wrote: > On Tue, 2011-11-22 at 00:44 +, Rusty Russell wrote: > > Or would it be simpler to enhance sscanf() with some weird format option > > for suffixing? I haven't looked for similar cases, but I'd suspect a > > big win in general. > > > > T

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-27 Thread Michael S. Tsirkin
On Fri, Nov 25, 2011 at 01:35:52AM -0500, David Miller wrote: > From: Krishna Kumar2 > Date: Fri, 25 Nov 2011 09:39:11 +0530 > > > Jason Wang wrote on 11/25/2011 08:51:57 AM: > >> > >> My description is not clear again :( > >> I mean the same vhost thead: > >> > >> vhost thread #0 transmits pack

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-27 Thread Michael S. Tsirkin
On Fri, Nov 25, 2011 at 09:39:11AM +0530, Krishna Kumar2 wrote: > Jason Wang wrote on 11/25/2011 08:51:57 AM: > > > > My description is not clear again :( > > I mean the same vhost thead: > > > > vhost thread #0 transmits packets of flow A on processor M > > ... > > vhost thread #0 move to another

Re: [PATCH] vhost-net: Acquire device lock when releasing device

2011-11-27 Thread Michael S. Tsirkin
On Sun, Nov 27, 2011 at 06:49:27PM +0200, Michael S. Tsirkin wrote: > On Fri, Nov 18, 2011 at 11:19:42AM +0200, Sasha Levin wrote: > > Device lock should be held when releasing a device, and specifically > > when calling vhost_dev_cleanup(). Otherwise, RCU complains about it: > > > > [ 2025.642835

Re: [PATCH] vhost-net: Acquire device lock when releasing device

2011-11-27 Thread Michael S. Tsirkin
On Sat, Nov 26, 2011 at 03:45:03PM -0500, David Miller wrote: > From: Sasha Levin > Date: Fri, 18 Nov 2011 11:19:42 +0200 > > > Device lock should be held when releasing a device, and specifically > > when calling vhost_dev_cleanup(). Otherwise, RCU complains about it: > ... > > Cc: "Michael S.

Re: [PATCH] vhost-net: Acquire device lock when releasing device

2011-11-27 Thread Michael S. Tsirkin
On Fri, Nov 18, 2011 at 11:19:42AM +0200, Sasha Levin wrote: > Device lock should be held when releasing a device, and specifically > when calling vhost_dev_cleanup(). Otherwise, RCU complains about it: > > [ 2025.642835] === > [ 2025.643838] [ INFO: suspicious RCU usag