Re: [RFC PATCH v1 2/2] virtio_net: Don't disable napi on low memory.

2012-01-06 Thread Mike Waychison
On Wed, Jan 4, 2012 at 6:46 PM, Mike Waychison wrote: > On Wed, Jan 4, 2012 at 4:31 PM, Rusty Russell wrote: >> 4) You use the skb data for the linked list; use the skb head's list. What did you mean by this? I was under the impression that the ->next and ->prev fields in sk_buff were the first

Re: [Xen-devel] [PATCH] xen: remove CONFIG_XEN_DOM0 compile option

2012-01-06 Thread Ian Campbell
On Fri, 2012-01-06 at 16:39 +, Andrew Jones wrote: > remove XEN_PRIVILEGED_GUEST as it's just an alias for XEN_DOM0. Hmm, this one is used by tools like update-grub to know when it is ok to create xen+kernel entries so I think it needs to stay, or we at least need to give lengthly warning to d

Re: [PATCH] xen: remove CONFIG_XEN_DOM0 compile option

2012-01-06 Thread Stefano Stabellini
On Fri, 6 Jan 2012, Andrew Jones wrote: > XEN_DOM0 is a silent option that has been automatically selected when > CONFIG_XEN is selected since 6b0661a5e6fbf. If this option was changed > to a menu configurable option then it would only give users the ability > to compile out about 100 kbytes of cod

Re: [Xen-devel] [PATCH 2/4] xen kconfig: relax INPUT_XEN_KBDDEV_FRONTEND deps

2012-01-06 Thread Konrad Rzeszutek Wilk
On Fri, Jan 06, 2012 at 10:43:09AM +0100, Andrew Jones wrote: > PV-on-HVM guests may want to use the xen keyboard/mouse frontend, but > they don't use the xen frame buffer frontend. For this case it doesn't > make much sense for INPUT_XEN_KBDDEV_FRONTEND to depend on > XEN_FBDEV_FRONTEND. The oppos

Re: [Xen-devel] [PATCH 3/4] xen kconfig: add dom0 support help text

2012-01-06 Thread Konrad Rzeszutek Wilk
> > The reason to remove is easy: it is already a silent option and > > disabling it saves almost nothing. > > I think that removing it should be easy enough but if you don't > > feel confident doing it, I can come up with a patch. > > > > I'll write the patch. It's not the patch I thought would

Re: [Xen-devel] [PATCH 3/4] xen kconfig: add dom0 support help text

2012-01-06 Thread Stefano Stabellini
On Fri, 6 Jan 2012, Andrew Jones wrote: > - Original Message - > > On Fri, 6 Jan 2012, Andrew Jones wrote: > > > > Almost all of the things which dom0 needs (e.g. PCI device > > > > management > > > > etc) is also required by a domU with passthrough enabled so the > > > > savings > > > > ar

Re: [Xen-devel] [PATCH 3/4] xen kconfig: add dom0 support help text

2012-01-06 Thread Stefano Stabellini
On Fri, 6 Jan 2012, Andrew Jones wrote: > > Almost all of the things which dom0 needs (e.g. PCI device management > > etc) is also required by a domU with passthrough enabled so the > > savings > > are really very slight. > > > > We are talking less than 1k of code AFAICT, 319 bytes for > > arch/x

[PATCH 2/2] virtio: console: Disable callbacks for virtqueues at start of S4 freeze

2012-01-06 Thread Amit Shah
To ensure we don't receive any more interrupts from the host after we enter the freeze function, disable all vq interrupts. There wasn't any problem seen due to this in tests, but applying this patch makes the freeze case more robust. Signed-off-by: Amit Shah --- drivers/char/virtio_console.c |

[PATCH 1/2] virtio: console: Serialise control work

2012-01-06 Thread Amit Shah
We currently allow multiple instances of the control work handler to run in parallel. This isn't expected to work; serialise access by disabling interrupts on new packets from the Host and enable them when all the existing ones are consumed. Testcase: hot-plug/unplug a port in a loop. Without th

[PATCH 0/2] virtio: console: control queue race fixes

2012-01-06 Thread Amit Shah
Hello, The first patch here fixes the race seen by Miche. He hasn't yet reported back if this fixes the races he saw, but Joy Pu from Red Hat tested this patch with hot-plugging/unplugging ports in a loop. Before this patch, he saw some freezes as well as sysfs warnings. After applying the patch,

Re: [Xen-devel] [PATCH 3/4] xen kconfig: add dom0 support help text

2012-01-06 Thread Stefano Stabellini
On Fri, 6 Jan 2012, Ian Campbell wrote: > On Fri, 2012-01-06 at 09:26 +, Andrew Jones wrote: > > > > - Original Message - > > > On Fri, 2012-01-06 at 08:57 +, Andrew Jones wrote: > > > > Describe dom0 support in the config menu and supply help text for > > > > it. > > > > > > This

Re: [Xen-devel] [PATCH 3/4] xen kconfig: add dom0 support help text

2012-01-06 Thread Ian Campbell
On Fri, 2012-01-06 at 09:26 +, Andrew Jones wrote: > > - Original Message - > > On Fri, 2012-01-06 at 08:57 +, Andrew Jones wrote: > > > Describe dom0 support in the config menu and supply help text for > > > it. > > > > This turns a non-user visible symbol into a user visible one