Re: [RFC-v4 3/3] tcm_vhost: Initial merge for vhost level target fabric driver

2012-07-21 Thread Michael S. Tsirkin
On Sat, Jul 21, 2012 at 06:55:38AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch adds the initial code for tcm_vhost, a Vhost level TCM > fabric driver for virtio SCSI initiators into KVM guest. > > This code is currently up and running on v3.5-rc2 host+guest alon

Re: [RFC-v4 2/3] vhost: make vhost work queue visible

2012-07-21 Thread Michael S. Tsirkin
On Sat, Jul 21, 2012 at 06:55:37AM +, Nicholas A. Bellinger wrote: > From: Stefan Hajnoczi > > The vhost work queue allows processing to be done in vhost worker thread > context, which uses the owner process mm. Access to the vring and guest > memory is typically only possible from vhost wor

Re: [RFC-v4 1/3] vhost: Separate vhost-net features from vhost features

2012-07-21 Thread Michael S. Tsirkin
On Sat, Jul 21, 2012 at 06:55:36AM +, Nicholas A. Bellinger wrote: > From: Stefan Hajnoczi > > In order for other vhost devices to use the VHOST_FEATURES bits the > vhost-net specific bits need to be moved to their own VHOST_NET_FEATURES > constant. > > (Asias: Update drivers/vhost/test.c to

Re: [net-next RFC V5 4/5] virtio_net: multiqueue support

2012-07-21 Thread Sasha Levin
On 07/20/2012 03:40 PM, Michael S. Tsirkin wrote: >> -err = init_vqs(vi); >> > + if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) >> > + vi->has_cvq = true; >> > + > How about we disable multiqueue if there's no cvq? > Will make logic a bit simpler, won't it? multiqueues don't rea