Re: [RFC 9/9] vhost-scsi: add -vhost-scsi host device

2012-07-24 Thread Paolo Bonzini
Il 25/07/2012 00:34, Nicholas A. Bellinger ha scritto: > From: Stefan Hajnoczi > > This patch adds a new type of host device that drives the vhost_scsi > device. The syntax to add vhost-scsi is: > > qemu -vhost-scsi id=vhost-scsi0,wwpn=...,tpgt=123 > > The virtio-scsi emulated device will ma

Re: [RFC 1/9] notifier: add validity check and notify function

2012-07-24 Thread Paolo Bonzini
Il 25/07/2012 00:33, Nicholas A. Bellinger ha scritto: > +int event_notifier_notify(EventNotifier *e) > +{ > +uint64_t value = 1; > +int r; > + > +assert(event_notifier_valid(e)); > +r = write(e->fd, &value, sizeof(value)); > +if (r < 0) { > +return -errno; > +} > +

Re: [RFC 2/9] virtio-pci: support host notifiers in TCG mode

2012-07-24 Thread Paolo Bonzini
Il 25/07/2012 00:33, Nicholas A. Bellinger ha scritto: > From: Stefan Hajnoczi > > Normally host notifiers are only used together with vhost-net in KVM > mode. It is occassionally useful to use vhost with TCG mode, mainly for > testing and development. This isn't hard to achieve, simply fall ba

CFP: 13th IFIP/IEEE Symposium on Integrated Network and Service Management (IM 2013)

2012-07-24 Thread Ming Zhao
IM 2013 The 13th IFIP/IEEE Symposium on Integrated Network and Service Management Ghent, Belgium, 27-31 May 2013 http://www.im2013.org/ (Paper Submission Date: 16 August 2012) "Smart Management in a Virtualized World" The 13th IFIP/IEEE Symposium on Integrated Network and Service Manageme

Re: [RFC 0/2] virtio: provide a way for host to monitor critical events in the device

2012-07-24 Thread Rusty Russell
On Tue, 24 Jul 2012 15:01:59 +0200, Sasha Levin wrote: > virtio on it's own was introduced to help solve the fragmentation > around virtualized devices, so I don't think that the main purpose of > doing virtio drivers is due to any performance benefits virtio may > provide. There's one argument i

Re: [RFC 0/9] vhost-scsi: Add support for host virtualized target

2012-07-24 Thread Zhi Yong Wu
On Wed, Jul 25, 2012 at 6:33 AM, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi Anthony + QEMU storage folks, > > The following is a reviewable RFC series of vhost-scsi against yesterday's > QEMU.git/master @ commit 401a66357d. > > The series is available directly from: > > git:

[RFC 9/9] vhost-scsi: add -vhost-scsi host device

2012-07-24 Thread Nicholas A. Bellinger
From: Stefan Hajnoczi This patch adds a new type of host device that drives the vhost_scsi device. The syntax to add vhost-scsi is: qemu -vhost-scsi id=vhost-scsi0,wwpn=...,tpgt=123 The virtio-scsi emulated device will make use of vhost-scsi to process virtio-scsi requests inside the kernel

[RFC 8/9] virtio-scsi: Set max_target=0 during vhost-scsi operation

2012-07-24 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This QEMU patch sets VirtIOSCSIConfig->max_target=0 for vhost-scsi operation to restrict virtio-scsi LLD guest scanning to max_id=0 (a single target ID instance) when connected to individual tcm_vhost endpoints. This ensures that virtio-scsi LLD only attempts to scan tar

[RFC 7/9] virtio-scsi: Start/stop vhost

2012-07-24 Thread Nicholas A. Bellinger
From: Stefan Hajnoczi This patch starts and stops vhost as the virtio device transitions through its status phases. Vhost can only be started once the guest reports its driver has successfully initialized, which means the virtqueues have been set up by the guest. (v2: Squash virtio-scsi: use th

[RFC 6/9] virtio-scsi: Open and initialize /dev/vhost-scsi

2012-07-24 Thread Nicholas A. Bellinger
From: Stefan Hajnoczi Begin adding vhost support by opening /dev/vhost-scsi. (v2: Drop legacy ->vhost_vqs[] usage) Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu Cc: Michael S. Tsirkin Cc: Paolo Bonzini Signed-off-by: Nicholas Bellinger --- hw/virtio-scsi.c | 12

[RFC 5/9] virtio-scsi: Add wwpn and tgpt properties

2012-07-24 Thread Nicholas A. Bellinger
From: Stefan Hajnoczi A vhost-scsi device must be bound to a tcm_vhost target port. This will be done by issuing an ioctl to the device with the wwpn and tgpt. This patch adds these properties to the virtio-scsi-pci device: qemu -device virtio-scsi-pci,wwpn=$TARGET_WWN,tgpt=$TPGT Future pat

[RFC 4/9] vhost: Pass device path to vhost_dev_init()

2012-07-24 Thread Nicholas A. Bellinger
From: Stefan Hajnoczi The path to /dev/vhost-net is currently hardcoded in vhost_dev_init(). This needs to be changed so that /dev/vhost-scsi can be used. Pass in the device path instead of hardcoding it. Signed-off-by: Stefan Hajnoczi Cc: Paolo Bonzini Cc: Michael S. Tsirkin Signed-off-by:

[RFC 3/9] virtio-pci: check that event notification worked

2012-07-24 Thread Nicholas A. Bellinger
From: Stefan Hajnoczi For sanity assert that event notification succeeds. Signed-off-by: Stefan Hajnoczi Cc: Anthony Liguori Cc: Paolo Bonzini Signed-off-by: Nicholas Bellinger --- hw/virtio-pci.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/virtio-pci.c b

[RFC 2/9] virtio-pci: support host notifiers in TCG mode

2012-07-24 Thread Nicholas A. Bellinger
From: Stefan Hajnoczi Normally host notifiers are only used together with vhost-net in KVM mode. It is occassionally useful to use vhost with TCG mode, mainly for testing and development. This isn't hard to achieve, simply fall back to notifying the host notifier manually from qemu if KVM mode

[RFC 1/9] notifier: add validity check and notify function

2012-07-24 Thread Nicholas A. Bellinger
From: Stefan Hajnoczi Event notifiers that have not had the event_notifier_init() function called on them are invalid. The event_notifier_valid() function checks whether or not an event notifier is valild. This can be used to check whether a notifier is in use or not. It sometimes useful to no

[RFC 0/9] vhost-scsi: Add support for host virtualized target

2012-07-24 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi Anthony + QEMU storage folks, The following is a reviewable RFC series of vhost-scsi against yesterday's QEMU.git/master @ commit 401a66357d. The series is available directly from: git://git.kernel.org/pub/scm/virt/kvm/nab/qemu-kvm.git vhost-scsi-merge It contain

Re: [PATCH] tcm_vhost: Expose ABI version via VHOST_SCSI_GET_ABI_VERSION

2012-07-24 Thread Nicholas A. Bellinger
On Mon, 2012-07-23 at 18:56 -0700, Greg Kroah-Hartman wrote: > On Tue, Jul 24, 2012 at 01:26:20AM +, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > As requested by Anthony, here is a patch against > > target-pending/for-next-merge > > to expose an ABI version to userspace

Re: [Qemu-devel] [RFC PATCH 0/6] virtio-trace: Support virtio-trace

2012-07-24 Thread Blue Swirl
On Tue, Jul 24, 2012 at 2:36 AM, Yoshihiro YUNOMAE wrote: > Hi All, > > The following patch set provides a low-overhead system for collecting kernel > tracing data of guests by a host in a virtualization environment. > > A guest OS generally shares some devices with other guests or a host, so > re

Re: Re: [RFC PATCH 0/6] virtio-trace: Support virtio-trace

2012-07-24 Thread Masami Hiramatsu
(2012/07/24 19:02), Stefan Hajnoczi wrote: > On Tue, Jul 24, 2012 at 3:36 AM, Yoshihiro YUNOMAE > wrote: >> The performance of each method is compared as follows: >> [1] Native >> - only recording trace data to ring-buffer on a guest >> [2] Virtio-trace >> - running a trace agent on a

Re: [RFC PATCH 0/6] virtio-trace: Support virtio-trace

2012-07-24 Thread Masami Hiramatsu
(2012/07/24 11:36), Yoshihiro YUNOMAE wrote: > Therefore, we propose a new system "virtio-trace", which uses enhanced > virtio-serial and existing ring-buffer of ftrace, for collecting guest kernel > tracing data. In this system, there are 5 main components: > (1) Ring-buffer of ftrace in a guest

Re: [PATCH] tcm_vhost: Expose ABI version via VHOST_SCSI_GET_ABI_VERSION

2012-07-24 Thread Greg Kroah-Hartman
On Tue, Jul 24, 2012 at 01:26:20AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > As requested by Anthony, here is a patch against target-pending/for-next-merge > to expose an ABI version to userspace via a new VHOST_SCSI_GET_ABI_VERSION > ioctl operation. > > As mentioned in

Re: Re: [RFC PATCH 0/6] virtio-trace: Support virtio-trace

2012-07-24 Thread Stefan Hajnoczi
On Tue, Jul 24, 2012 at 12:03 PM, Masami Hiramatsu wrote: > (2012/07/24 19:02), Stefan Hajnoczi wrote: >> On Tue, Jul 24, 2012 at 3:36 AM, Yoshihiro YUNOMAE >> wrote: >>> The performance of each method is compared as follows: >>> [1] Native >>> - only recording trace data to ring-buffer on

Re: Re: [RFC PATCH 0/6] virtio-trace: Support virtio-trace

2012-07-24 Thread Stefan Hajnoczi
On Tue, Jul 24, 2012 at 12:19 PM, Yoshihiro YUNOMAE wrote: >>> Are you using text formatted ftrace? > No, currently using raw format, but we'd like to reformat it in text. Capturing the info necessary to translate numbers into symbols is one of the problems of host<->guest tracing so I'm curious

Re: [RFC 0/2] virtio: provide a way for host to monitor critical events in the device

2012-07-24 Thread Sasha Levin
On 07/24/2012 02:46 PM, Dor Laor wrote: > On 07/24/2012 03:30 PM, Sasha Levin wrote: >> On 07/24/2012 10:26 AM, Dor Laor wrote: >>> On 07/24/2012 07:55 AM, Rusty Russell wrote: On Mon, 23 Jul 2012 22:32:39 +0200, Sasha Levin wrote: > As it was discussed recently, there's currently n

Re: [RFC 0/2] virtio: provide a way for host to monitor critical events in the device

2012-07-24 Thread Dor Laor
On 07/24/2012 03:30 PM, Sasha Levin wrote: On 07/24/2012 10:26 AM, Dor Laor wrote: On 07/24/2012 07:55 AM, Rusty Russell wrote: On Mon, 23 Jul 2012 22:32:39 +0200, Sasha Levin wrote: As it was discussed recently, there's currently no way for the guest to notify the host about panics. Further

Re: [RFC 0/2] virtio: provide a way for host to monitor critical events in the device

2012-07-24 Thread Gleb Natapov
On Tue, Jul 24, 2012 at 02:31:25PM +0200, Sasha Levin wrote: > On 07/24/2012 02:28 PM, Gleb Natapov wrote: > > On Tue, Jul 24, 2012 at 02:26:33PM +0200, Sasha Levin wrote: > >> On 07/24/2012 09:44 AM, Gleb Natapov wrote: > >>> On Mon, Jul 23, 2012 at 10:32:39PM +0200, Sasha Levin wrote: > As i

Re: [RFC 0/2] virtio: provide a way for host to monitor critical events in the device

2012-07-24 Thread Sasha Levin
On 07/24/2012 02:28 PM, Gleb Natapov wrote: > On Tue, Jul 24, 2012 at 02:26:33PM +0200, Sasha Levin wrote: >> On 07/24/2012 09:44 AM, Gleb Natapov wrote: >>> On Mon, Jul 23, 2012 at 10:32:39PM +0200, Sasha Levin wrote: As it was discussed recently, there's currently no way for the guest to >>

Re: [RFC 0/2] virtio: provide a way for host to monitor critical events in the device

2012-07-24 Thread Sasha Levin
On 07/24/2012 10:26 AM, Dor Laor wrote: > On 07/24/2012 07:55 AM, Rusty Russell wrote: >> On Mon, 23 Jul 2012 22:32:39 +0200, Sasha Levin >> wrote: >>> As it was discussed recently, there's currently no way for the guest to >>> notify >>> the host about panics. Further more, there's no reasonabl

Re: [RFC 0/2] virtio: provide a way for host to monitor critical events in the device

2012-07-24 Thread Gleb Natapov
On Tue, Jul 24, 2012 at 02:26:33PM +0200, Sasha Levin wrote: > On 07/24/2012 09:44 AM, Gleb Natapov wrote: > > On Mon, Jul 23, 2012 at 10:32:39PM +0200, Sasha Levin wrote: > >> As it was discussed recently, there's currently no way for the guest to > >> notify > >> the host about panics. Further m

Re: [RFC 0/2] virtio: provide a way for host to monitor critical events in the device

2012-07-24 Thread Sasha Levin
On 07/24/2012 09:44 AM, Gleb Natapov wrote: > On Mon, Jul 23, 2012 at 10:32:39PM +0200, Sasha Levin wrote: >> As it was discussed recently, there's currently no way for the guest to >> notify >> the host about panics. Further more, there's no reasonable way to notify the >> host of other critical

Re: [RFC 0/2] virtio: provide a way for host to monitor critical events in the device

2012-07-24 Thread Sasha Levin
On 07/24/2012 06:55 AM, Rusty Russell wrote:> On Mon, 23 Jul 2012 22:32:39 +0200, Sasha Levin wrote: >> As it was discussed recently, there's currently no way for the guest to >> notify >> the host about panics. Further more, there's no reasonable way to notify the >> host of other critical even

Re: Re: [RFC PATCH 0/6] virtio-trace: Support virtio-trace

2012-07-24 Thread Yoshihiro YUNOMAE
Hi Stefan, Thank you for commenting on our patch set. (2012/07/24 20:03), Masami Hiramatsu wrote: (2012/07/24 19:02), Stefan Hajnoczi wrote: On Tue, Jul 24, 2012 at 3:36 AM, Yoshihiro YUNOMAE wrote: The performance of each method is compared as follows: [1] Native - only recording tr

Re: [RFC PATCH 0/6] virtio-trace: Support virtio-trace

2012-07-24 Thread Stefan Hajnoczi
On Tue, Jul 24, 2012 at 3:36 AM, Yoshihiro YUNOMAE wrote: > The performance of each method is compared as follows: > [1] Native > - only recording trace data to ring-buffer on a guest > [2] Virtio-trace > - running a trace agent on a guest > - a reader on a host opens FIFO using c

Re: [RFC 0/2] virtio: provide a way for host to monitor critical events in the device

2012-07-24 Thread Dor Laor
On 07/24/2012 07:55 AM, Rusty Russell wrote: On Mon, 23 Jul 2012 22:32:39 +0200, Sasha Levin wrote: As it was discussed recently, there's currently no way for the guest to notify the host about panics. Further more, there's no reasonable way to notify the host of other critical events such as a

Re: [RFC 0/2] virtio: provide a way for host to monitor critical events in the device

2012-07-24 Thread Gleb Natapov
On Mon, Jul 23, 2012 at 10:32:39PM +0200, Sasha Levin wrote: > As it was discussed recently, there's currently no way for the guest to notify > the host about panics. Further more, there's no reasonable way to notify the > host of other critical events such as an OOM kill. > > This short patch ser