Re: [PATCHv7 4/4] virtio_console: Add support for remoteproc serial

2012-10-22 Thread Rusty Russell
sjur.brandel...@stericsson.com writes: > From: Sjur Brændeland > > Add a simple serial connection driver called > VIRTIO_ID_RPROC_SERIAL (11) for communicating with a > remote processor in an asymmetric multi-processing > configuration. > > This implementation reuses the existing virtio_console >

Re: [PATCH v2 1/3] mm: highmem: export kmap_to_page for modules

2012-10-22 Thread Rusty Russell
Will Deacon writes: > Some virtio device drivers (9p) need to translate high virtual addresses > to physical addresses, which are inserted into the virtqueue for > processing by userspace. > > This patch exports the kmap_to_page symbol, so that the affected drivers > can be compiled as modules.

Re: [PATCH] vhost-blk: Add vhost-blk support v2

2012-10-22 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Thu, Oct 18, 2012 at 02:50:56PM +1030, Rusty Russell wrote: >> Asias He writes: >> >>> +#define BLK_HDR 0 >> >> >> >> What's this for, exactly? Please add a comment. >> > >> > The block headr is in the first and separate buffer. >> >> Please don't assume this!

Re: [PATCHv7 3/4] virtio_console: Merge struct buffer_token into struct port_buffer

2012-10-22 Thread Rusty Russell
sjur.brandel...@stericsson.com writes: > From: Sjur Brændeland > > Refactoring the splice functionality by unifying the approach for > sending scatter-lists and regular buffers. This simplifies > buffer handling and reduces code size. Splice will now allocate > a port_buffer and send_buf() and fre

Re: [PATCHv7 2/4] virtio_console: Use kmalloc instead of kzalloc

2012-10-22 Thread Rusty Russell
sjur.brandel...@stericsson.com writes: > From: Sjur Brændeland > > Avoid the more cpu expensive kzalloc when allocating buffers. > Originally kzalloc was intended for isolating the guest from > the host by not sending random guest data to the host. But device > isolation is not yet in place so kz

Re: [PATCHv7 1/4] virtio_console: Free buffer if splice fails

2012-10-22 Thread Rusty Russell
sjur.brandel...@stericsson.com writes: > From: Sjur Brændeland > > Free the allocated scatter list if send_pages fails in function > port_splice_write. > > Signed-off-by: Sjur Brændeland Didn't see Amit ack this, but applied anyway. Thanks, Rusty. ___

Re: [PATCH v2 1/3] mm: highmem: export kmap_to_page for modules

2012-10-22 Thread Andrew Morton
On Fri, 19 Oct 2012 14:03:31 +0100 Will Deacon wrote: > Some virtio device drivers (9p) need to translate high virtual addresses > to physical addresses, which are inserted into the virtqueue for > processing by userspace. > > This patch exports the kmap_to_page symbol, so that the affected driv

Re: [PATCH v2 2/3] virtio: 9p: correctly pass physical address to userspace for high pages

2012-10-22 Thread Andrew Morton
On Fri, 19 Oct 2012 14:03:32 +0100 Will Deacon wrote: > When using a virtio transport, the 9p net device may pass the physical > address of a kernel buffer to userspace via a scatterlist inside a > virtqueue. If the kernel buffer is mapped outside of the linear mapping > (e.g. highmem), then virt

Re: [PATCHv7 0/4] virtio_console: Add rproc_serial driver

2012-10-22 Thread Amit Shah
Hello Sjur, On (Mon) 15 Oct 2012 [09:57:32], sjur.brandel...@stericsson.com wrote: > From: Sjur Brændeland > > This patch-set introduces a new virtio type "rproc_serial" for communicating > with remote processors over shared memory. The driver depends on the > the remoteproc framework. As prepar