Re: [PATCH 2/2] vhost: handle polling failure

2012-12-27 Thread Wanlong Gao
On 12/27/2012 02:39 PM, Jason Wang wrote: Currently, polling error were ignored in vhost. This may lead some issues (e.g kenrel crash when passing a tap fd to vhost before calling TUNSETIFF). Fix this by: Can this kernel crash be reproduced by hand? Thanks, Wanlong Gao - extend the idea

Re: [RFC PATCH] virtio-net: reset virtqueue affinity when doing cpu hotplug

2012-12-27 Thread Michael S. Tsirkin
On Thu, Dec 27, 2012 at 11:34:16AM +0800, Jason Wang wrote: On 12/26/2012 06:46 PM, Michael S. Tsirkin wrote: On Wed, Dec 26, 2012 at 03:06:54PM +0800, Wanlong Gao wrote: Add a cpu notifier to virtio-net, so that we can reset the virtqueue affinity if the cpu hotplug happens. It improve

Re: [PATCH 1/2] vhost_net: correct error hanlding in vhost_net_set_backend()

2012-12-27 Thread Michael S. Tsirkin
On Thu, Dec 27, 2012 at 02:39:20PM +0800, Jason Wang wrote: Currently, polling error were ignored in vhost. This may lead some issues (e.g kenrel crash when passing a tap fd to vhost before calling TUNSETIFF). Fix this by: - extend the idea of vhost_net_poll_state to all vhost_polls -

Re: [PATCH v3 00/11] xen: Initial kexec/kdump implementation

2012-12-27 Thread Eric W. Biederman
Andrew Cooper andrew.coop...@citrix.com writes: On 27/12/2012 07:53, Eric W. Biederman wrote: The syscall ABI still has the wrong semantics. Aka totally unmaintainable and umergeable. The concept of domU support is also strange. What does domU support even mean, when the dom0 support is

Re: [PATCH v3 09/11] x86/xen/enlighten: Add init and crash kexec/kdump hooks

2012-12-27 Thread H. Peter Anvin
On 12/26/2012 06:18 PM, Daniel Kiper wrote: Add init and crash kexec/kdump hooks. Signed-off-by: Daniel Kiper daniel.ki...@oracle.com --- arch/x86/xen/enlighten.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) On the general issue of hooks: Hooks need their pre- and

Re: [PATCH v3 02/11] x86/kexec: Add extra pointers to transition page table PGD, PUD, PMD and PTE

2012-12-27 Thread Daniel Kiper
Hmm... this code is being redone at the moment... this might conflict. Is this available somewhere? May I have a look at it? Daniel PS I am on holiday until 02/01/2013 and I could not have access to my email box. Please be patient. At worst case I will send reply when I will be back

Re: [PATCH v3 06/11] x86/xen: Add i386 kexec/kdump implementation

2012-12-27 Thread Daniel Kiper
On 12/26/2012 06:18 PM, Daniel Kiper wrote: Add i386 kexec/kdump implementation. v2 - suggestions/fixes: - allocate transition page table pages below 4 GiB (suggested by Jan Beulich). Why? Sadly all addresses are passed via unsigned long variable to kexec hypercall. Daniel

Re: [PATCH v3 06/11] x86/xen: Add i386 kexec/kdump implementation

2012-12-27 Thread H. Peter Anvin
On 12/27/2012 03:23 PM, Daniel Kiper wrote: On 12/26/2012 06:18 PM, Daniel Kiper wrote: Add i386 kexec/kdump implementation. v2 - suggestions/fixes: - allocate transition page table pages below 4 GiB (suggested by Jan Beulich). Why? Sadly all addresses are passed via unsigned

Re: [PATCH v3 00/11] xen: Initial kexec/kdump implementation

2012-12-27 Thread Daniel Kiper
On 12/26/2012 06:18 PM, Daniel Kiper wrote: Hi, This set of patches contains initial kexec/kdump implementation for Xen v3. Currently only dom0 is supported, however, almost all infrustructure required for domU support is ready. Jan Beulich suggested to merge Xen x86 assembler code

Re: [PATCH v3 01/11] kexec: introduce kexec firmware support

2012-12-27 Thread Daniel Kiper
Daniel Kiper daniel.ki...@oracle.com writes: Some kexec/kdump implementations (e.g. Xen PVOPS) could not use default Linux infrastructure and require some support from firmware and/or hypervisor. To cope with that problem kexec firmware infrastructure was introduced. It allows a

Re: [PATCH v3 00/11] xen: Initial kexec/kdump implementation

2012-12-27 Thread Daniel Kiper
Andrew Cooper andrew.coop...@citrix.com writes: On 27/12/2012 07:53, Eric W. Biederman wrote: The syscall ABI still has the wrong semantics. Aka totally unmaintainable and umergeable. The concept of domU support is also strange. What does domU support even mean, when the dom0

Re: [PATCH v3 01/11] kexec: introduce kexec firmware support

2012-12-27 Thread Eric W. Biederman
Daniel Kiper daniel.ki...@oracle.com writes: Daniel Kiper daniel.ki...@oracle.com writes: Some kexec/kdump implementations (e.g. Xen PVOPS) could not use default Linux infrastructure and require some support from firmware and/or hypervisor. To cope with that problem kexec firmware

Re: [PATCH v3 06/11] x86/xen: Add i386 kexec/kdump implementation

2012-12-27 Thread Eric W. Biederman
H. Peter Anvin h...@zytor.com writes: On 12/27/2012 03:23 PM, Daniel Kiper wrote: On 12/26/2012 06:18 PM, Daniel Kiper wrote: Add i386 kexec/kdump implementation. v2 - suggestions/fixes: - allocate transition page table pages below 4 GiB (suggested by Jan Beulich). Why?

Re: [PATCH 2/2] vhost: handle polling failure

2012-12-27 Thread Jason Wang
On 12/27/2012 06:01 PM, Wanlong Gao wrote: On 12/27/2012 02:39 PM, Jason Wang wrote: Currently, polling error were ignored in vhost. This may lead some issues (e.g kenrel crash when passing a tap fd to vhost before calling TUNSETIFF). Fix this by: Can this kernel crash be reproduced

Re: [PATCH 1/2] vhost_net: correct error hanlding in vhost_net_set_backend()

2012-12-27 Thread Jason Wang
On 12/27/2012 09:03 PM, Michael S. Tsirkin wrote: On Thu, Dec 27, 2012 at 02:39:20PM +0800, Jason Wang wrote: Currently, polling error were ignored in vhost. This may lead some issues (e.g kenrel crash when passing a tap fd to vhost before calling TUNSETIFF). Fix this by: - extend the

Re: [PATCH 1/2] vhost_net: correct error hanlding in vhost_net_set_backend()

2012-12-27 Thread Jason Wang
On 12/27/2012 09:14 PM, Michael S. Tsirkin wrote: On Thu, Dec 27, 2012 at 02:39:19PM +0800, Jason Wang wrote: Fix the leaking of oldubufs and fd refcnt when fail to initialized used ring. Signed-off-by: Jason Wang jasow...@redhat.com --- drivers/vhost/net.c | 14 +++--- 1 files