Re: [PATCH 1/6] virtio_host: host-side implementation of virtio rings.

2013-01-22 Thread Asias He
On 01/17/2013 06:29 PM, Rusty Russell wrote: Getting use of virtio rings correct is tricky, and a recent patch saw an implementation of in-kernel rings (as separate from userspace). This patch attempts to abstract the business of dealing with the virtio ring layout from the access (userspace

Re: [PATCH 4/6] tools/virtio: add vring_test.

2013-01-22 Thread Asias He
On 01/17/2013 06:29 PM, Rusty Russell wrote: This is mainly to test the drivers/vhost/vringh.c code, but it also uses the drivers/virtio/virtio_ring.c code for the guest side. vringh_test.c does not compile here: (This series on top of 9a9284153d965a57edc7162a8e57c14c97f3a935) $ cd

Re: [QEMU PATCH v4 2/3] virtio-net: introduce a new macaddr control

2013-01-22 Thread Amos Kong
On Mon, Jan 21, 2013 at 05:08:26PM +0100, Stefan Hajnoczi wrote: On Sat, Jan 19, 2013 at 09:54:27AM +0800, ak...@redhat.com wrote: @@ -350,6 +351,18 @@ static int virtio_net_handle_mac(VirtIONet *n, uint8_t cmd, struct virtio_net_ctrl_mac mac_data; size_t s; +if (cmd

Re: [QEMU PATCH v4 1/3] virtio-net: remove layout assumptions for ctrl vq

2013-01-22 Thread Amos Kong
On Mon, Jan 21, 2013 at 05:03:30PM +0100, Stefan Hajnoczi wrote: On Sat, Jan 19, 2013 at 09:54:26AM +0800, ak...@redhat.com wrote: From: Michael S. Tsirkin m...@redhat.com Virtio-net code makes assumption about virtqueue descriptor layout (e.g. sg[0] is the header, sg[1] is the data

Re: [QEMU PATCH v4 1/3] virtio-net: remove layout assumptions for ctrl vq

2013-01-22 Thread Stefan Hajnoczi
On Tue, Jan 22, 2013 at 10:38:14PM +0800, Amos Kong wrote: On Mon, Jan 21, 2013 at 05:03:30PM +0100, Stefan Hajnoczi wrote: On Sat, Jan 19, 2013 at 09:54:26AM +0800, ak...@redhat.com wrote: From: Michael S. Tsirkin m...@redhat.com Virtio-net code makes assumption about virtqueue

Re: [PATCH 1/6] virtio_host: host-side implementation of virtio rings.

2013-01-22 Thread Sjur Brændeland
On Mon, Jan 21, 2013 at 3:36 AM, Rusty Russell ru...@rustcorp.com.au wrote: Sjur Brændeland sjur.brandel...@stericsson.com writes: On Thu, Jan 17, 2013 at 12:23 PM, Michael S. Tsirkin m...@redhat.com wrote: in otgher words, we might need to split a single desc to multiple iov entries.

[QEMU PATCH v5 0/3] virtio-net: fix of ctrl commands

2013-01-22 Thread Amos Kong
Currently virtio-net code relys on the layout of descriptor, this patchset removed the assumptions and introduced a control command to set mac address. Last patch is a trivial renaming. V2: check guest's iov_len V3: fix of migration compatibility make mac field in config space read-only when

[QEMU PATCH v5 1/3] virtio-net: remove layout assumptions for ctrl vq

2013-01-22 Thread Amos Kong
From: Michael S. Tsirkin m...@redhat.com Virtio-net code makes assumption about virtqueue descriptor layout (e.g. sg[0] is the header, sg[1] is the data buffer). This patch makes code not rely on the layout of descriptors. Signed-off-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Amos

[QEMU PATCH v5 2/3] virtio-net: introduce a new macaddr control

2013-01-22 Thread Amos Kong
In virtio-net guest driver, currently we write MAC address to pci config space byte by byte, this means that we have an intermediate step where mac is wrong. This patch introduced a new control command to set MAC address, it's atomic. VIRTIO_NET_F_CTRL_MAC_ADDR is a new feature bit for

[QEMU PATCH v5 3/3] virtio-net: rename ctrl rx commands

2013-01-22 Thread Amos Kong
This patch makes rx commands consistent with specification. Signed-off-by: Amos Kong ak...@redhat.com --- hw/virtio-net.c | 14 +++--- hw/virtio-net.h | 14 +++--- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index

Re: [RFC] virtio_console: Add DRIVER and INTERFACE to uevent.

2013-01-22 Thread Greg KH
On Tue, Jan 22, 2013 at 09:55:20AM +1030, Rusty Russell wrote: sjur.brandel...@stericsson.com writes: From: Sjur Brændeland sjur.brandel...@stericsson.com Add information so rproc-serial can be easily recogniced from user space. Add the following information to uevent:

Workshops in the CISTI'2013 - 8th Iberian Conference on IST

2013-01-22 Thread Maria Lemos
*** Workshop in the CISTI'2013 8th Iberian Conference on Information Systems and Technologies Lisbon, Portugal, June 19 - 23, 2013

Re: [PATCH] x86, Allow x2apic without IR on VMware platform.

2013-01-22 Thread Alok Kataria
Hi Peter, Ingo, Can you please consider this patch, it allows linux guests to use x2apic when running on VMware platform. Thanks, Alok On Thu, 2013-01-17 at 15:44 -0800, Alok Kataria wrote: Please consider this patch to allow x2apic without IR support when running on VMware platform. Tested

Re: [PATCH 1/6] virtio_host: host-side implementation of virtio rings.

2013-01-22 Thread Rusty Russell
Asias He as...@redhat.com writes: On 01/17/2013 06:29 PM, Rusty Russell wrote: Getting use of virtio rings correct is tricky, and a recent patch saw an implementation of in-kernel rings (as separate from userspace). This patch attempts to abstract the business of dealing with the virtio