Re: [PATCH net-next v2 4/4] virtio-net: initial debugfs support, export mergeable rx buffer size

2014-01-13 Thread Michael S. Tsirkin
On Sun, Jan 12, 2014 at 03:32:28PM -0800, Michael Dalton wrote: Hi Michael, On Sun, Jan 12, 2014 at 9:09 AM, Michael S. Tsirkin m...@redhat.com wrote: Can't we add struct attribute * to netdevice, and pass that in when creating the kobj? I like that idea, I think that will work and

Fwd: Re: [PATCH v4 RFC 0/3] virtio: add 'device_lost' to virtio_device

2014-01-13 Thread Heinz Graalfs
Rusty, a Happy New Year! how about my answer? What am I missing? Original Message Subject: Re: [PATCH v4 RFC 0/3] virtio: add 'device_lost' to virtio_device Date: Mon, 23 Dec 2013 09:39:13 +0100 From: Heinz Graalfs graa...@linux.vnet.ibm.com To: Rusty Russell

Re: [PATCH net-next v2 4/4] virtio-net: initial debugfs support, export mergeable rx buffer size

2014-01-13 Thread Ben Hutchings
On Mon, 2014-01-13 at 11:40 +0200, Michael S. Tsirkin wrote: On Sun, Jan 12, 2014 at 03:32:28PM -0800, Michael Dalton wrote: [...] The last issue is how the rx_queue_attribute 'show' function implementation for mergeable_rx_buffer_size will access the appropriate per-receive queue EWMA

Re: [PATCH net-next v2 4/4] virtio-net: initial debugfs support, export mergeable rx buffer size

2014-01-13 Thread Michael Dalton
On Mon, Jan 13, 2014 at 7:38 AM, Ben Hutchings bhutchi...@solarflare.com wrote: I don't think RPS should own this structure. It's just that there are currently no per-RX-queue attributes other than those defined by RPS. Agreed, there is useful attribute-independent functionality already built

Re: [PATCH net-next v2 4/4] virtio-net: initial debugfs support, export mergeable rx buffer size

2014-01-13 Thread Michael Dalton
Sorry I missed this important piece of information, it appears that netdev_queue (the TX equivalent of netdev_rx_queue) already has decoupled itself from CONFIG_XPS due to an attribute, queue_trans_timeout, that does not depend on XPS functionality. So it seems that something somewhat equivalent