Re: [PATCH] virtio_console: move early VQ enablement

On Mon, Oct 20, 2014 at 10:05 AM, Michael S. Tsirkin wrote: > On Mon, Oct 20, 2014 at 03:58:49PM +0200, Cornelia Huck wrote: >> Commit f5866db6 (virtio_console: enable VQs early) tried to make >> sure that DRIVER_OK was set when virtio_console started using its >> virtqueues. Doing this in add_por

Re: [PATCH v4 13/25] virtio_console: enable VQs early

On 10/20/14 at 04:10pm, Michael S. Tsirkin wrote: > On Mon, Oct 20, 2014 at 01:07:50PM +0100, Thomas Graf wrote: > > On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > > > virtio spec requires drivers to set DRIVER_OK before using VQs. > > > This is set automatically after probe returns, virtio co

Re: [PATCH v4 13/25] virtio_console: enable VQs early

On 10/20/14 at 05:04pm, Michael S. Tsirkin wrote: > Sure enough, this helps: > > Tested-by: Michael S. Tsirkin > Acked-by: Michael S. Tsirkin > > Pls repost as a top-level patch. Thanks for fixing this so promptly. ___ Virtualization mailing list Vir

Re: [PATCH v4 13/25] virtio_console: enable VQs early

On 10/20/14 at 02:42pm, Cornelia Huck wrote: > On Mon, 20 Oct 2014 13:07:50 +0100 > Thomas Graf wrote: > > > On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > > > virtio spec requires drivers to set DRIVER_OK before using VQs. > > > This is set automatically after probe returns, virtio console

Re: [PATCH v4 13/25] virtio_console: enable VQs early

On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > virtio spec requires drivers to set DRIVER_OK before using VQs. > This is set automatically after probe returns, virtio console violated this > rule by adding inbufs, which causes the VQ to be used directly within > probe. > > To fix, call virtio

[PATCH] virtio_ccw: remove unsued variable

Hi, 016c98c6f virtio: unify config_changed handling introduced a warning in virtio_ccw which is fixed by the following patch. Regards, Sebastian --- virtio_ccw: remove unsued variable Fix this warning: drivers/s390/kvm/virtio_ccw.c: In function ‘virtio_ccw_int_handler’: drivers/s390/kvm/virtio_

Re: [PATCH] virtio_ccw: remove unsued variable

On Mon, Oct 20, 2014 at 12:48:18PM +0200, Sebastian Ott wrote: > Hi, > > 016c98c6f virtio: unify config_changed handling > > introduced a warning in virtio_ccw which is fixed by the following patch. > > Regards, > Sebastian > --- > virtio_ccw: remove unsued variable s/unsued/unused/ > > Fix

Re: Virtio_config BUG with 3.18-rc1

On Mon, Oct 20, 2014 at 10:11:22AM -0400, Josh Boyer wrote: > Hi All, > > Booting my local KVM guest with a build of 3.18-rc1 this morning, it > hangs during the normal dracut splash screen When I configured the > guest to use a serial console, I got the output below. The guest is a > typical KV

Virtio_config BUG with 3.18-rc1

Hi All, Booting my local KVM guest with a build of 3.18-rc1 this morning, it hangs during the normal dracut splash screen When I configured the guest to use a serial console, I got the output below. The guest is a typical KVM guest created with virt-manager, using QXL as the display driver. Not

Re: [PATCH] virtio_console: move early VQ enablement

On Mon, Oct 20, 2014 at 03:58:49PM +0200, Cornelia Huck wrote: > Commit f5866db6 (virtio_console: enable VQs early) tried to make > sure that DRIVER_OK was set when virtio_console started using its > virtqueues. Doing this in add_port(), however, means that we try > to set DRIVER_OK again when when

Re: [PATCH v4 13/25] virtio_console: enable VQs early

On Mon, Oct 20, 2014 at 04:35:55PM +0300, Michael S. Tsirkin wrote: > On Mon, Oct 20, 2014 at 02:42:23PM +0200, Cornelia Huck wrote: > > On Mon, 20 Oct 2014 13:07:50 +0100 > > Thomas Graf wrote: > > > > > On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > > > > virtio spec requires drivers to se

[PATCH] virtio_console: move early VQ enablement

Commit f5866db6 (virtio_console: enable VQs early) tried to make sure that DRIVER_OK was set when virtio_console started using its virtqueues. Doing this in add_port(), however, means that we try to set DRIVER_OK again when when a port is dynamically added after the probe function is done. Let's m

Re: [PATCH v4 13/25] virtio_console: enable VQs early

On Mon, Oct 20, 2014 at 02:42:23PM +0200, Cornelia Huck wrote: > On Mon, 20 Oct 2014 13:07:50 +0100 > Thomas Graf wrote: > > > On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > > > virtio spec requires drivers to set DRIVER_OK before using VQs. > > > This is set automatically after probe return

Re: [PATCH v4 13/25] virtio_console: enable VQs early

On Mon, Oct 20, 2014 at 04:10:16PM +0300, Michael S. Tsirkin wrote: > On Mon, Oct 20, 2014 at 01:07:50PM +0100, Thomas Graf wrote: > > On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > > > virtio spec requires drivers to set DRIVER_OK before using VQs. > > > This is set automatically after probe

Re: [PATCH v4 13/25] virtio_console: enable VQs early

On Mon, Oct 20, 2014 at 01:07:50PM +0100, Thomas Graf wrote: > On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > > virtio spec requires drivers to set DRIVER_OK before using VQs. > > This is set automatically after probe returns, virtio console violated this > > rule by adding inbufs, which cause

Re: [PATCH v4 13/25] virtio_console: enable VQs early

On Mon, 20 Oct 2014 13:07:50 +0100 Thomas Graf wrote: > On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > > virtio spec requires drivers to set DRIVER_OK before using VQs. > > This is set automatically after probe returns, virtio console violated this > > rule by adding inbufs, which causes the

Re: [PATCH] virtio_ccw: remove unsued variable

On Mon, 20 Oct 2014 12:48:18 +0200 (CEST) Sebastian Ott wrote: > Hi, > > 016c98c6f virtio: unify config_changed handling > > introduced a warning in virtio_ccw which is fixed by the following patch. > > Regards, > Sebastian > --- > virtio_ccw: remove unsued variable > > Fix this warning: > dr