Re: [PATCH] virtio_net: fix use after free

2014-10-31 Thread Jason Wang
On 10/31/2014 11:36 AM, Eric Dumazet wrote: On Wed, 2014-10-15 at 16:23 +0300, Michael S. Tsirkin wrote: commit 0b725a2ca61bedc33a2a63d0451d528b268cf975 net: Remove ndo_xmit_flush netdev operation, use signalling instead. added code that looks at skb-xmit_more after the skb has been put

Re: [PATCH v2 4/6] hw_random: fix unregister race.

2014-10-31 Thread Herbert Xu
On Fri, Oct 31, 2014 at 10:28:00AM +1030, Rusty Russell wrote: Herbert Xu herb...@gondor.apana.org.au writes: On Thu, Sep 18, 2014 at 08:37:45PM +0800, Amos Kong wrote: From: Rusty Russell ru...@rustcorp.com.au The previous patch added one potential problem: we can still be reading

Re: [PATCH] virtio_ccw: remove unsued variable

2014-10-31 Thread Cornelia Huck
On Fri, 31 Oct 2014 10:31:19 +1030 Rusty Russell ru...@rustcorp.com.au wrote: Cornelia Huck cornelia.h...@de.ibm.com writes: On Tue, 28 Oct 2014 19:37:58 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Oct 28, 2014 at 04:39:12PM +0100, Sebastian Ott wrote: virtio_ccw: remove

Re: [PATCH] virtio_net: fix use after free

2014-10-31 Thread Eric Dumazet
On Fri, 2014-10-31 at 14:07 +0800, Jason Wang wrote: Since they are called before the possible free_old_xmit_skbs(), skb won't get freed at this time. Oh right, I forgot there is no completion handler yet, timer based or whatever. Thanks. ___