Re: [PATCH 1/2] virito: introduce methods of fixing device features

2014-11-13 Thread Cornelia Huck
On Thu, 13 Nov 2014 13:52:53 +0800 Jason Wang jasow...@redhat.com wrote: typo in subject-prefix: s/virito/virtio/ Buggy host may advertised buggy host features (a usual case is that host advertise a feature whose dependencies were missed). In this case, driver should detect and disable the

Re: [PATCH 2/2] virtio-net: fix buggy features advertised by host

2014-11-13 Thread Cornelia Huck
On Thu, 13 Nov 2014 13:52:54 +0800 Jason Wang jasow...@redhat.com wrote: This patch tries to detect the possible buggy features advertised by host and fix them. One example is booting virtio-net with only ctrl_vq disabled, qemu may still advertise many features which depends on it. This will

Re: [PATCH 1/2] virito: introduce methods of fixing device features

2014-11-13 Thread Jason Wang
On 11/13/2014 04:46 PM, Cornelia Huck wrote: On Thu, 13 Nov 2014 13:52:53 +0800 Jason Wang jasow...@redhat.com wrote: typo in subject-prefix: s/virito/virtio/ Will correct this. Buggy host may advertised buggy host features (a usual case is that host advertise a feature whose dependencies

Re: [PATCH 2/2] virtio-net: fix buggy features advertised by host

2014-11-13 Thread Jason Wang
On 11/13/2014 04:53 PM, Cornelia Huck wrote: On Thu, 13 Nov 2014 13:52:54 +0800 Jason Wang jasow...@redhat.com wrote: This patch tries to detect the possible buggy features advertised by host and fix them. One example is booting virtio-net with only ctrl_vq disabled, qemu may still advertise

Re: [PATCH 1/2] virito: introduce methods of fixing device features

2014-11-13 Thread Cornelia Huck
On Thu, 13 Nov 2014 17:11:30 +0800 Jason Wang jasow...@redhat.com wrote: On 11/13/2014 04:46 PM, Cornelia Huck wrote: On Thu, 13 Nov 2014 13:52:53 +0800 Jason Wang jasow...@redhat.com wrote: +static inline void virtio_disable_feature(struct virtio_device *vdev, +

Re: [RFC PATCH] virtio-mmio: support for multiple irqs

2014-11-13 Thread Shannon Zhao
On 2014/11/13 2:33, Pawel Moll wrote: On Wed, 2014-11-12 at 08:32 +, Shannon Zhao wrote: On 2014/11/11 23:11, Pawel Moll wrote: On Tue, 2014-11-04 at 09:35 +, Shannon Zhao wrote: As the current virtio-mmio only support single irq, so some advanced features such as vhost-net with irqfd

Re: [PATCH 1/2] virito: introduce methods of fixing device features

2014-11-13 Thread Jason Wang
On 11/13/2014 05:14 PM, Cornelia Huck wrote: On Thu, 13 Nov 2014 17:11:30 +0800 Jason Wang jasow...@redhat.com wrote: On 11/13/2014 04:46 PM, Cornelia Huck wrote: On Thu, 13 Nov 2014 13:52:53 +0800 Jason Wang jasow...@redhat.com wrote: +static inline void virtio_disable_feature(struct

Re: kernel BUG at drivers/block/virtio_blk.c:172!

2014-11-13 Thread Dongsu Park
On 12.11.2014 11:18, Jens Axboe wrote: On 11/11/2014 09:42 AM, Ming Lei wrote: The attached patch should fix the problem, and hope it is the last one, :-) Dongsu and Jeff, any of you test this variant? I think this is the last one, at least I hope so as well... Yes, I've just tested it

Re: [PATCH net] Revert drivers/net: Disable UFO through virtio in macvtap and tun

2014-11-13 Thread Jelle de Jong
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/11/14 20:02, Stefan Hajnoczi wrote: On Tue, Nov 11, 2014 at 05:12:58PM +, Ben Hutchings wrote: This reverts commit 88e0e0e5aa722b193c8758c8b45d041de5316924 for the tap drivers, but leaves UFO disabled in virtio_net. libvirt at least

[PULL] vhost: cleanups and fixes

2014-11-13 Thread Michael S. Tsirkin
The following changes since commit 206c5f60a3d902bc4b56dab2de3e88de5eb06108: Linux 3.18-rc4 (2014-11-09 14:55:29 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to

Re: [PATCH 52/56] drivers/char/virtio: support compiling out splice

2014-11-13 Thread Greg Kroah-Hartman
On Thu, Nov 13, 2014 at 10:23:29PM +0100, Pieter Smith wrote: Compile out splice support from virtio character driver when the splice-family of syscalls is not supported by the system (i.e. CONFIG_SYSCALL_SPLICE is undefined). Signed-off-by: Pieter Smith pie...@boesman.nl ---