Re: [PATCH] virtio-pci: fix host notifiers on bi-endian architectures

2015-03-11 Thread Greg Kurz
On Wed, 11 Mar 2015 21:06:05 +0100 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Mar 11, 2015 at 07:04:38PM +0100, Greg Kurz wrote: vhost is seriously broken with ppc64le guests, even in the supposedly supported case where the host is ppc64le and we don't need cross-endian support.

Re: [PATCH] virtio-pci: fix host notifiers on bi-endian architectures

2015-03-11 Thread Michael S. Tsirkin
On Wed, Mar 11, 2015 at 07:04:38PM +0100, Greg Kurz wrote: vhost is seriously broken with ppc64le guests, even in the supposedly supported case where the host is ppc64le and we don't need cross-endian support. The TX virtqueue fails to be handled by vhost and falls back to QEMU. Despite

KVM Forum 2015 Call for Participation

2015-03-11 Thread Paolo Bonzini
= KVM Forum 2015: Call For Participation August 19-21, 2015 - Sheraton Seattle - Seattle, WA (All submissions must be received before midnight May 1, 2015) = KVM is an

[PATCH] virtio-pci: fix host notifiers on bi-endian architectures

2015-03-11 Thread Greg Kurz
vhost is seriously broken with ppc64le guests, even in the supposedly supported case where the host is ppc64le and we don't need cross-endian support. The TX virtqueue fails to be handled by vhost and falls back to QEMU. Despite this unexpected scenario where RX is vhost and TX is QEMU, the guest

Re: [Qemu-ppc] [PATCH] virtio-pci: fix host notifiers on bi-endian architectures

2015-03-11 Thread Benjamin Herrenschmidt
On Wed, 2015-03-11 at 23:03 +0100, Greg Kurz wrote: /* The host notifier will be swapped in adjust_endianness() according to the * target default endianness. We need to negate this swap if the device uses * an endianness that is not the default (ppc64le for example). */ +static

Re: [Qemu-ppc] [PATCH] virtio-pci: fix host notifiers on bi-endian architectures

2015-03-11 Thread Greg Kurz
On Thu, 12 Mar 2015 09:18:38 +1100 Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Wed, 2015-03-11 at 23:03 +0100, Greg Kurz wrote: /* The host notifier will be swapped in adjust_endianness() according to the * target default endianness. We need to negate this swap if the device

Re: [PATCH] virtio_rpmsg: set DRIVER_OK before using device

2015-03-11 Thread Rusty Russell
Ohad Ben-Cohen o...@wizery.com writes: On Mon, Mar 9, 2015 at 10:41 AM, Michael S. Tsirkin m...@redhat.com wrote: On Sat, Mar 07, 2015 at 08:06:56PM +0100, Michael S. Tsirkin wrote: virtio spec requires that all drivers set DRIVER_OK before using devices. While rpmsg isn't yet included in the

Re: [PATCH] virtio: Remove virtio device during shutdown

2015-03-11 Thread Fam Zheng
On Wed, 03/11 10:06, Michael S. Tsirkin wrote: On Wed, Mar 11, 2015 at 04:09:17PM +0800, Fam Zheng wrote: Currently shutdown is nop for virtio devices, but the core code could remove things behind us such as MSI-X handler etc. For example in the case of virtio-scsi-pci, the device may still

Re: [PATCH] virtio: Remove virtio device during shutdown

2015-03-11 Thread Michael S. Tsirkin
On Wed, Mar 11, 2015 at 04:09:17PM +0800, Fam Zheng wrote: Currently shutdown is nop for virtio devices, but the core code could remove things behind us such as MSI-X handler etc. For example in the case of virtio-scsi-pci, the device may still try to send interupts, which will be on IRQ lines

[PATCH] virtio: Remove virtio device during shutdown

2015-03-11 Thread Fam Zheng
Currently shutdown is nop for virtio devices, but the core code could remove things behind us such as MSI-X handler etc. For example in the case of virtio-scsi-pci, the device may still try to send interupts, which will be on IRQ lines seeing MSI-X disabled. Those interrupts will be unhandled, and

[PATCH] uapi/virtio_scsi: allow overriding CDB/SENSE size

2015-03-11 Thread Michael S. Tsirkin
QEMU wants to use virtio scsi structures with a different VIRTIO_SCSI_CDB_SIZE/VIRTIO_SCSI_SENSE_SIZE, let's add ifdefs to allow overriding them. Keep the old defines under new names: VIRTIO_SCSI_CDB_DEFAULT_SIZE/VIRTIO_SCSI_SENSE_DEFAULT_SIZE, since that's what these values really are: defaults

Re: [PATCH] uapi/virtio_scsi: allow overriding CDB/SENSE size

2015-03-11 Thread Paolo Bonzini
On 11/03/2015 14:19, Michael S. Tsirkin wrote: QEMU wants to use virtio scsi structures with a different VIRTIO_SCSI_CDB_SIZE/VIRTIO_SCSI_SENSE_SIZE, let's add ifdefs to allow overriding them. Keep the old defines under new names:

Re: [PATCH] virtio_rpmsg: set DRIVER_OK before using device

2015-03-11 Thread Ohad Ben-Cohen
On Mon, Mar 9, 2015 at 10:41 AM, Michael S. Tsirkin m...@redhat.com wrote: On Sat, Mar 07, 2015 at 08:06:56PM +0100, Michael S. Tsirkin wrote: virtio spec requires that all drivers set DRIVER_OK before using devices. While rpmsg isn't yet included in the virtio 1 spec, previous spec versions

Re: [PATCH] uapi/virtio_scsi: allow overriding CDB/SENSE size

2015-03-11 Thread Michael S. Tsirkin
On Wed, Mar 11, 2015 at 02:31:51PM +0100, Paolo Bonzini wrote: On 11/03/2015 14:19, Michael S. Tsirkin wrote: QEMU wants to use virtio scsi structures with a different VIRTIO_SCSI_CDB_SIZE/VIRTIO_SCSI_SENSE_SIZE, let's add ifdefs to allow overriding them. Keep the old defines under

[PATCH net] virtio-net: correctly delete napi hash

2015-03-11 Thread Jason Wang
We don't delete napi from hash list during module exit. This will cause the following panic when doing module load and unload: BUG: unable to handle kernel paging request at 004e0075 IP: [816bd01b] napi_hash_add+0x6b/0xf0 PGD 3c5d5067 PUD 0 Oops: [#1] SMP ... Call Trace: