Re: [PATCH 1/2] kvm/x86: Hyper-V synthetic interrupt controller

2015-10-12 Thread Christian Borntraeger
Am 09.10.2015 um 16:42 schrieb Paolo Bonzini: > Christian, the question for you is towards the end... [] > >> --- a/virt/kvm/irqchip.c >> +++ b/virt/kvm/irqchip.c >> @@ -144,11 +144,13 @@ static int setup_routing_entry(struct >> kvm_irq_routing_table *rt, >> >> /* >> * Do not

Re: [PATCH 1/2] kvm/x86: Hyper-V synthetic interrupt controller

2015-10-12 Thread Paolo Bonzini
On 12/10/2015 10:48, Cornelia Huck wrote: > Going back to Paolo's original question, I think changing the check > to !KVM_IRQ_ROUTING_IRQCHIP makes sense, if I understand the code > correctly. They seem to be the only special one. Great. Roman, Denis, can you do this then? Thanks, Paolo

Re: [PATCH 1/2] kvm/x86: Hyper-V synthetic interrupt controller

2015-10-12 Thread Cornelia Huck
On Mon, 12 Oct 2015 09:54:41 +0200 Christian Borntraeger wrote: > Am 09.10.2015 um 16:42 schrieb Paolo Bonzini: > > Christian, the question for you is towards the end... > > > > [] > > > >> --- a/virt/kvm/irqchip.c > >> +++ b/virt/kvm/irqchip.c > >> @@ -144,11

Re: [PATCH 1/2] kvm/x86: Hyper-V synthetic interrupt controller

2015-10-12 Thread Roman Kagan
On Fri, Oct 09, 2015 at 04:42:33PM +0200, Paolo Bonzini wrote: > You need to add SYNIC vectors to the EOI exit bitmap, so that APICv > (Xeon E5 or higher, Ivy Bridge or newer) is handled correctly. You also > need to check the auto EOI exit bitmap in __apic_accept_irq, and avoid > going through

Re: [PATCH 1/2] kvm/x86: Hyper-V synthetic interrupt controller

2015-10-12 Thread Roman Kagan
On Mon, Oct 12, 2015 at 10:58:36AM +0200, Paolo Bonzini wrote: > On 12/10/2015 10:48, Cornelia Huck wrote: > > Going back to Paolo's original question, I think changing the check > > to !KVM_IRQ_ROUTING_IRQCHIP makes sense, if I understand the code > > correctly. They seem to be the only special

Re: [PATCH 2/2] kvm/x86: Hyper-V kvm exit

2015-10-12 Thread Roman Kagan
On Fri, Oct 09, 2015 at 04:41:15PM +0200, Paolo Bonzini wrote: > On 09/10/2015 15:39, Denis V. Lunev wrote: > > A new vcpu exit is introduced to notify the userspace of the > > changes in Hyper-V synic configuraion triggered by guest writing to the > > corresponding MSRs. > > Why is this exit

Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit

2015-10-12 Thread Eric Blake
On 10/12/2015 07:42 AM, Eric Blake wrote: > On 10/09/2015 07:39 AM, Denis V. Lunev wrote: >> From: Andrey Smetanin >> >> A new vcpu exit is introduced to notify the userspace of the >> changes in Hyper-V synic configuraion triggered by guest writing to the > >

Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit

2015-10-12 Thread Eric Blake
On 10/09/2015 07:39 AM, Denis V. Lunev wrote: > From: Andrey Smetanin > > A new vcpu exit is introduced to notify the userspace of the > changes in Hyper-V synic configuraion triggered by guest writing to the s/configuraion/configuration/ Is 'synic' intended? Is it

Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit

2015-10-12 Thread Denis V. Lunev
On 10/12/2015 04:42 PM, Eric Blake wrote: On 10/09/2015 07:39 AM, Denis V. Lunev wrote: From: Andrey Smetanin A new vcpu exit is introduced to notify the userspace of the changes in Hyper-V synic configuraion triggered by guest writing to the

Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit

2015-10-12 Thread Roman Kagan
On Mon, Oct 12, 2015 at 07:42:42AM -0600, Eric Blake wrote: > On 10/09/2015 07:39 AM, Denis V. Lunev wrote: > > From: Andrey Smetanin > > > > A new vcpu exit is introduced to notify the userspace of the > > changes in Hyper-V synic configuraion triggered by guest writing

Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit

2015-10-12 Thread Paolo Bonzini
On 12/10/2015 15:42, Eric Blake wrote: > > +related with Hyper-V emulation. Currently used to synchronize modified > > +Hyper-V synic state with userspace. > > Again, is 'synic' intended? Hmm, I see it throughout the patch, so it > looks intentional, but I keep trying to read it as a typo for

RE: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit

2015-10-12 Thread KY Srinivasan
> -Original Message- > From: Denis V. Lunev [mailto:d...@openvz.org] > Sent: Monday, October 12, 2015 6:46 AM > To: Eric Blake > Cc: Gleb Natapov ; qemu-de...@nongnu.org; > virtualization@lists.linux-foundation.org; rka...@virtuozzo.com; Paolo >