On Thu, 06/30 15:10, Dan Williams wrote:
> On Wed, Jun 29, 2016 at 6:59 PM, Fam Zheng wrote:
> > It is documented that KOBJ_ADD should be generated after the object's
> > attributes and children are ready. We can achieve this with the new
> > disk_gen_uevents interface.
> >
> >
On Wed, 06/29 23:38, Christoph Hellwig wrote:
> On Thu, Jun 30, 2016 at 02:35:54PM +0800, Fam Zheng wrote:
> > also more code and less flexible IMO. For example, we need at least two
> > variants, for attribute_group and device_attribute separately, right?
>
> Yes, or maybe just a calling
On Thu, Jun 30, 2016 at 02:45:30PM +0800, Jason Wang wrote:
> Hi all:
>
> This series tries to switch to use skb array in tun. This is used to
> eliminate the spinlock contention between producer and consumer. The
> conversion was straightforward: just introdce a tx skb array and use
> it instead
We used to queue tx packets in sk_receive_queue, this is less
efficient since it requires spinlocks to synchronize between producer
and consumer.
This patch tries to address this by:
- switch from sk_receive_queue to a skb_array, and resize it when
tx_queue_len was changed.
- introduce a new
This patch introduces a new event - NETDEV_CHANGE_TX_QUEUE_LEN, this
will be triggered when tx_queue_len. It could be used by net device
who want to do some processing at that time. An example is tun who may
want to resize tx array when tx_queue_len is changed.
Cc: John Fastabend
Hi all:
This series tries to switch to use skb array in tun. This is used to
eliminate the spinlock contention between producer and consumer. The
conversion was straightforward: just introdce a tx skb array and use
it instead of sk_receive_queue.
A minor issue is to keep the tx_queue_len
Signed-off-by: Michael S. Tsirkin
Signed-off-by: Jason Wang
---
include/linux/skb_array.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/skb_array.h b/include/linux/skb_array.h
index 678bfbf..2dd0d1e 100644
---
From: "Michael S. Tsirkin"
Sometimes, we need support resizing multiple queues at once. This is
because it was not easy to recover to recover from a partial failure
of multiple queues resizing.
Signed-off-by: Michael S. Tsirkin
Signed-off-by: Jason Wang
Signed-off-by: Michael S. Tsirkin
Signed-off-by: Jason Wang
---
include/linux/skb_array.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/include/linux/skb_array.h b/include/linux/skb_array.h
index 2dd0d1e..f4dfade 100644
---
Sometimes, we need zero length ring. But current code will crash since
we don't do any check before accessing the ring. This patch fixes this.
Signed-off-by: Jason Wang
---
include/linux/ptr_ring.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
On 2016年06月30日 13:59, Jason Wang wrote:
On 2016年06月30日 13:12, Jason Wang wrote:
On 2016年06月30日 12:56, John Fastabend wrote:
On 16-06-29 08:52 PM, Jason Wang wrote:
This patch introduces a new event - NETDEV_CHANGE_TX_QUEUE_LEN, this
will be triggered when tx_queue_len. It could be used
On Thu, Jun 30, 2016 at 02:35:54PM +0800, Fam Zheng wrote:
> also more code and less flexible IMO. For example, we need at least two
> variants, for attribute_group and device_attribute separately, right?
Yes, or maybe just a calling convention that just passes both.
On Wed, 06/29 23:24, Christoph Hellwig wrote:
> On Thu, Jun 30, 2016 at 09:59:41AM +0800, Fam Zheng wrote:
> > Documentation/kobject.txt:
> > > Use the KOBJ_ADD action for when the kobject is first added to the kernel.
> > > This should be done only after any attributes or children of the kobject
drivers/net/tun.c:1476:2-3: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
CC: Jason Wang
Signed-off-by: Fengguang Wu
---
tun.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
Hi,
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Jason-Wang/switch-to-use-tx-skb-array-in-tun/20160630-120656
coccinelle warnings: (new ones prefixed by >>)
>> drivers/net/tun.c:1476:2-3: Unneeded semicolon
Please review and p
On Thu, Jun 30, 2016 at 11:26:45AM +0530, Anshuman Khandual wrote:
> >> Did you get a chance to test the driver out ? I am still concerned about
> >> how to
> >> handle the struct address_space override problem within the struct page.
> >
> > Hi Anshuman,
> >
> > Slow but I am working on
On 2016年06月30日 13:12, Jason Wang wrote:
On 2016年06月30日 12:56, John Fastabend wrote:
On 16-06-29 08:52 PM, Jason Wang wrote:
This patch introduces a new event - NETDEV_CHANGE_TX_QUEUE_LEN, this
will be triggered when tx_queue_len. It could be used by net device
who want to do some
17 matches
Mail list logo