Re: virtio_net: ethtool supported link modes

2017-09-01 Thread Michael S. Tsirkin
On Fri, Sep 01, 2017 at 05:19:53PM +0100, Radu Rendec wrote: > On Fri, 2017-09-01 at 18:43 +0300, Michael S. Tsirkin wrote: > > On Thu, Aug 31, 2017 at 06:04:04PM +0100, Radu Rendec wrote: > > > Looking at the code in virtnet_set_link_ksettings, it seems the speed > > > and duplex can be set to

Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

2017-09-01 Thread Willem de Bruijn
>>> This is not a 50/50 split, which impliesTw that some packets from the >>> large >>> packet flow are still converted to copying. Without the change the rate >>> without queue was 80k zerocopy vs 80k copy, so this choice of >>> (vq->num >> 2) appears too conservative. >>> >>> However, testing

Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

2017-09-01 Thread Willem de Bruijn
On Thu, Aug 31, 2017 at 11:25 PM, Jason Wang wrote: > > > On 2017年08月31日 22:30, Willem de Bruijn wrote: >>> >>> Incomplete results at this stage, but I do see this correlation between >>> flows. It occurs even while not running out of zerocopy descriptors, >>> which I cannot

Re: [PATCH net] vhost_net: correctly check tx avail during rx busy polling

2017-09-01 Thread Michael S. Tsirkin
On Fri, Sep 01, 2017 at 05:02:50PM +0800, Jason Wang wrote: > We check tx avail through vhost_enable_notify() in the past which is > wrong since it only checks whether or not guest has filled more > available buffer since last avail idx synchronization which was just > done by

Re: virtio_net: ethtool supported link modes

2017-09-01 Thread Michael S. Tsirkin
On Thu, Aug 31, 2017 at 06:04:04PM +0100, Radu Rendec wrote: > Hello, > > Looking at the code in virtnet_set_link_ksettings, it seems the speed > and duplex can be set to any valid value. The driver will "remember" > them and report them back in virtnet_get_link_ksettings. > > However, the

[PATCH net] vhost_net: correctly check tx avail during rx busy polling

2017-09-01 Thread Jason Wang
We check tx avail through vhost_enable_notify() in the past which is wrong since it only checks whether or not guest has filled more available buffer since last avail idx synchronization which was just done by vhost_vq_avail_empty() before. What we really want is checking pending buffers in the

Re: [RFC PATCH v2 1/7] x86/paravirt: Add pv_idle_ops to paravirt ops

2017-09-01 Thread Yang Zhang
On 2017/8/29 21:55, Konrad Rzeszutek Wilk wrote: On Tue, Aug 29, 2017 at 11:46:35AM +, Yang Zhang wrote: So far, pv_idle_ops.poll is the only ops for pv_idle. .poll is called in idle path which will polling for a while before we enter the real idle state. In virtualization, idle path