Re: [PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers()

And after it is ready, we can go ahead with moving > > > it out of staging to drm. > > > > Please keep the todo item that it needs to be converted to atomic. And > > tbh, it's probably faster if you just submit it to dri-devel, assuming you > > have time to work on it. Fo

Re: [PATCH 1/3] vhost: fix skb leak in handle_rx()

On 2017年12月01日 13:54, w...@redhat.com wrote: From: Wei Xu Matthew found a roughly 40% tcp throughput regression with commit c67df11f(vhost_net: try batch dequing from skb array) as discussed in the following thread:

Re: [PATCH 3/3] tap: free skb if flags error

On 2017年12月01日 13:54, w...@redhat.com wrote: From: Wei Xu tap_recvmsg() supports accepting skb by msg_control after commit 3b4ba04acca8 ("tap: support receiving skb from msg_control"), the skb if presented should be freed within the function, otherwise it would be leaked.

Re: [PATCH 2/3] tun: free skb in early errors

On 2017年12月01日 13:54, w...@redhat.com wrote: From: Wei Xu tun_recvmsg() supports accepting skb by msg_control after commit ac77cfd4258f ("tun: support receiving skb through msg_control"), the skb if presented should be freed within the function, otherwise it would be leaked.

Re: [RFC] virtio-net: help live migrate SR-IOV devices

On Thu, Nov 30, 2017 at 12:48:22PM -0800, Jakub Kicinski wrote: > On Thu, 30 Nov 2017 15:54:40 +0200, Michael S. Tsirkin wrote: > > On Wed, Nov 29, 2017 at 07:51:38PM -0800, Jakub Kicinski wrote: > > > On Thu, 30 Nov 2017 11:29:56 +0800, Jason Wang wrote: > > > > On 2017年11月29日 03:27, Jesse

Re: [PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers()

; have time to work on it. For small drivers we tend to be fairly quick in > getting them into good enough shape. I have received the driver from Teddy and pushed it to https://github.com/sudipm-mukherjee/parport/tree/drm_smi for your first look into it. It is not even building with next-20171130 a

Re: [PATCH v18 01/10] idr: add #include

On Wed, 29 Nov 2017 16:58:17 -0800 Matthew Wilcox wrote: > On Wed, Nov 29, 2017 at 09:55:17PM +0800, Wei Wang wrote: > > The was removed from radix-tree.h by the following commit: > > f5bba9d11a256ad2a1c2f8e7fc6aabe6416b7890. > > > > Since that commit,

Re: [PATCH v18 06/10] virtio_ring: add a new API, virtqueue_add_one_desc

On Wed, Nov 29, 2017 at 09:55:22PM +0800, Wei Wang wrote: > Current virtqueue_add API implementation is based on the scatterlist > struct, which uses kaddr. This is inadequate to all the use case of > vring. For example: > - Some usages don't use IOMMU, in this case the user can directly pass >

RE: [PATCH v18 07/10] virtio-balloon: VIRTIO_BALLOON_F_SG

On Thursday, November 30, 2017 6:36 PM, Tetsuo Handa wrote: > Wei Wang wrote: > > +static inline int xb_set_page(struct virtio_balloon *vb, > > + struct page *page, > > + unsigned long *pfn_min, > > + unsigned long

Re: [PATCH v18 05/10] xbitmap: add more operations

On Thu, Nov 30, 2017 at 10:35:03PM +0900, Tetsuo Handa wrote: > According to xb_set_bit(), it seems to me that we are trying to avoid memory > allocation > for "struct ida_bitmap" when all set bits within a 1024-bits bitmap reside in > the first > 61 bits. > > But does such saving help? Is

Re: [RFC] virtio-net: help live migrate SR-IOV devices

On Thu, Nov 30, 2017 at 11:29:56AM +0800, Jason Wang wrote: > If my understanding is correct there's no need to for any extension of > virtio spec. There appears to be a concern that some existing configurations might use same MAC for an unrelated reason. Not sure what that could be, but for

Re: [RFC] virtio-net: help live migrate SR-IOV devices

On Thu, Nov 30, 2017 at 10:08:45AM +0200, achiad shochat wrote: > Re. problem #2: > Indeed the best way to address it seems to be to enslave the VF driver > netdev under a persistent anchor netdev. > And it's indeed desired to allow (but not enforce) PV netdev and VF > netdev to work in

Re: [RFC] virtio-net: help live migrate SR-IOV devices

On Wed, Nov 29, 2017 at 07:51:38PM -0800, Jakub Kicinski wrote: > On Thu, 30 Nov 2017 11:29:56 +0800, Jason Wang wrote: > > On 2017年11月29日 03:27, Jesse Brandeburg wrote: > > > Hi, I'd like to get some feedback on a proposal to enhance virtio-net > > > to ease configuration of a VM and that would

Re: [PATCH net,stable v2] vhost: fix skb leak in handle_rx()

On Thu, Nov 30, 2017 at 10:46:17AM +0800, Jason Wang wrote: > > > On 2017年11月29日 23:31, Michael S. Tsirkin wrote: > > On Wed, Nov 29, 2017 at 09:23:24AM -0500,w...@redhat.com wrote: > > > From: Wei Xu > > > > > > Matthew found a roughly 40% tcp throughput regression with